From: David Hunt <david.hunt@intel.com>
To: dev@dpdk.org
Cc: bruce.richardson@intel.com, David Hunt <david.hunt@intel.com>
Subject: [dpdk-dev] [PATCH v1 6/6] lib/power: switch empty poll to max cores config
Date: Thu, 9 Sep 2021 14:45:11 +0100 [thread overview]
Message-ID: <20210909134511.18871-7-david.hunt@intel.com> (raw)
In-Reply-To: <20210909134511.18871-1-david.hunt@intel.com>
empty poll algorithm uses NUM_NODES as 256, but should really use
RTE_MAX_LCORE, which is configurable.
Signed-off-by: David Hunt <david.hunt@intel.com>
---
lib/power/rte_power_empty_poll.c | 12 ++++++------
lib/power/rte_power_empty_poll.h | 4 +---
2 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/lib/power/rte_power_empty_poll.c b/lib/power/rte_power_empty_poll.c
index 975aa92997..fe20b9f7b2 100644
--- a/lib/power/rte_power_empty_poll.c
+++ b/lib/power/rte_power_empty_poll.c
@@ -373,7 +373,7 @@ rte_empty_poll_detection(struct rte_timer *tim, void *arg)
RTE_SET_USED(arg);
- for (i = 0; i < NUM_NODES; i++) {
+ for (i = 0; i < RTE_MAX_LCORE; i++) {
poll_stats = &(ep_params->wrk_data.wrk_stats[i]);
@@ -436,7 +436,7 @@ rte_power_empty_poll_stat_init(struct ep_params **eptr, uint8_t *freq_tlb,
*eptr = ep_params;
/* initialize all wrk_stats state */
- for (i = 0; i < NUM_NODES; i++) {
+ for (i = 0; i < RTE_MAX_LCORE; i++) {
if (rte_lcore_is_enabled(i) == 0)
continue;
@@ -476,7 +476,7 @@ rte_power_empty_poll_stat_update(unsigned int lcore_id)
{
struct priority_worker *poll_stats;
- if (lcore_id >= NUM_NODES)
+ if (lcore_id >= RTE_MAX_LCORE)
return -1;
poll_stats = &(ep_params->wrk_data.wrk_stats[lcore_id]);
@@ -495,7 +495,7 @@ rte_power_poll_stat_update(unsigned int lcore_id, uint8_t nb_pkt)
struct priority_worker *poll_stats;
- if (lcore_id >= NUM_NODES)
+ if (lcore_id >= RTE_MAX_LCORE)
return -1;
poll_stats = &(ep_params->wrk_data.wrk_stats[lcore_id]);
@@ -514,7 +514,7 @@ rte_power_empty_poll_stat_fetch(unsigned int lcore_id)
{
struct priority_worker *poll_stats;
- if (lcore_id >= NUM_NODES)
+ if (lcore_id >= RTE_MAX_LCORE)
return -1;
poll_stats = &(ep_params->wrk_data.wrk_stats[lcore_id]);
@@ -530,7 +530,7 @@ rte_power_poll_stat_fetch(unsigned int lcore_id)
{
struct priority_worker *poll_stats;
- if (lcore_id >= NUM_NODES)
+ if (lcore_id >= RTE_MAX_LCORE)
return -1;
poll_stats = &(ep_params->wrk_data.wrk_stats[lcore_id]);
diff --git a/lib/power/rte_power_empty_poll.h b/lib/power/rte_power_empty_poll.h
index 6ba0a37074..22678b4f4b 100644
--- a/lib/power/rte_power_empty_poll.h
+++ b/lib/power/rte_power_empty_poll.h
@@ -31,8 +31,6 @@ extern "C" {
#define NUM_PRIORITIES 2
-#define NUM_NODES 256 /* Max core number*/
-
/* Processor Power State */
enum freq_val {
LOW,
@@ -98,7 +96,7 @@ struct priority_worker {
struct stats_data {
- struct priority_worker wrk_stats[NUM_NODES];
+ struct priority_worker wrk_stats[RTE_MAX_LCORE];
/* flag to stop rx threads processing packets until training over */
bool start_rx;
--
2.17.1
prev parent reply other threads:[~2021-09-09 13:46 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 13:45 [dpdk-dev] build: Increase the default value of RTE_MAX_LCORE David Hunt
2021-09-09 13:45 ` [dpdk-dev] [PATCH v1 1/6] build: increase default of max lcores to 512 David Hunt
2021-09-09 14:37 ` Bruce Richardson
2021-09-10 6:51 ` David Marchand
2021-09-10 7:54 ` Bruce Richardson
2021-09-10 8:06 ` David Marchand
2021-09-10 8:24 ` Thomas Monjalon
2021-09-14 9:34 ` David Hunt
2021-09-14 10:00 ` David Marchand
2021-09-14 11:07 ` David Hunt
2021-09-14 11:29 ` David Marchand
2021-09-15 12:13 ` David Hunt
2021-11-17 15:55 ` Morten Brørup
2021-11-17 19:01 ` David Hunt
2021-09-15 12:11 ` [dpdk-dev] [PATCH v2] eal: add additional info if lcore exceeds max cores David Hunt
2021-09-16 12:34 ` David Marchand
2021-09-20 9:30 ` David Hunt
2021-09-21 11:50 ` [dpdk-dev] [PATCH v3 1/2] eal: add additional info if core list too long David Hunt
2021-09-21 11:50 ` [dpdk-dev] [PATCH v3 2/2] eal: add additional info if core mask " David Hunt
2021-09-21 12:00 ` Bruce Richardson
2021-09-21 11:57 ` [dpdk-dev] [PATCH v3 1/2] eal: add additional info if core list " Bruce Richardson
2021-09-21 12:04 ` David Hunt
2021-09-21 13:16 ` David Hunt
2021-09-21 13:20 ` Bruce Richardson
2021-09-21 13:51 ` David Marchand
2021-09-21 15:10 ` David Hunt
2021-09-22 12:29 ` [dpdk-dev] [PATCH v4 " David Hunt
2021-09-22 12:29 ` [dpdk-dev] [PATCH v4 2/2] eal: add additional info if core mask " David Hunt
2021-09-23 8:12 ` David Marchand
2021-09-23 10:21 ` David Hunt
2021-09-23 8:11 ` [dpdk-dev] [PATCH v4 1/2] eal: add additional info if core list " David Marchand
2021-09-23 9:47 ` David Hunt
2021-09-23 11:02 ` [dpdk-dev] [PATCH v5 " David Hunt
2021-09-23 11:02 ` [dpdk-dev] [PATCH v5 2/2] eal: add additional info if core mask " David Hunt
2021-11-02 17:45 ` David Marchand
2021-11-03 10:27 ` David Hunt
2021-11-03 10:29 ` David Marchand
2021-11-03 13:30 ` David Hunt
2021-11-03 14:32 ` [dpdk-dev] [PATCH v6 1/2] eal: add additional info if core list " David Hunt
2021-11-03 14:32 ` [dpdk-dev] [PATCH v6 2/2] eal: add additional info if core mask " David Hunt
2021-11-05 10:50 ` David Marchand
2021-09-09 13:45 ` [dpdk-dev] [PATCH v1 2/6] lib/power: reduce memory footprint of acpi lib David Hunt
2021-09-09 13:45 ` [dpdk-dev] [PATCH v1 3/6] lib/power: reduce memory footprint of pstate lib David Hunt
2021-09-09 13:45 ` [dpdk-dev] [PATCH v1 4/6] lib/power: reduce memory footprint of cppc lib David Hunt
2021-09-09 13:45 ` [dpdk-dev] [PATCH v1 5/6] lib/power: reduce memory footprint of channels David Hunt
2021-09-09 13:45 ` David Hunt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210909134511.18871-7-david.hunt@intel.com \
--to=david.hunt@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).