From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F5D6A0547; Fri, 10 Sep 2021 11:17:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1975C406B4; Fri, 10 Sep 2021 11:17:50 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 81601410FE for ; Fri, 10 Sep 2021 11:17:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631265467; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FwzL5t+Z5qZ3dyatH7ZMtgtJcXY0o251j3MscgP7dnA=; b=ZYZvzh0uGd/JCbFhsECVWuhlYElNPa2Axt7/M/NCoEii/qDOcXmbgTBzglZski8D7ELz2M +BGe6u5e1naCZUActCQmcZPVtA+Fgsk/x1FibWvFljuCt8aN05Fy7if19lJF3UjsDPa0RZ xjWMjYpnxGyPTlLylc6niB4f6kLoeMs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-353-alHqB-CZOo-YPyhdAPde9g-1; Fri, 10 Sep 2021 05:17:46 -0400 X-MC-Unique: alHqB-CZOo-YPyhdAPde9g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F28625076C; Fri, 10 Sep 2021 09:17:44 +0000 (UTC) Received: from max-t490s.redhat.com (unknown [10.39.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9D49F77BE7; Fri, 10 Sep 2021 09:17:42 +0000 (UTC) From: Maxime Coquelin To: dev@dpdk.org, chenbo.xia@intel.com, amorenoz@redhat.com, david.marchand@redhat.com, andrew.rybchenko@oktetlabs.ru, ferruh.yigit@intel.com, michaelba@nvidia.com, viacheslavo@nvidia.com Cc: stable@dpdk.org, nelio.laranjeiro@6wind.com, Maxime Coquelin Date: Fri, 10 Sep 2021 11:17:33 +0200 Message-Id: <20210910091734.7023-3-maxime.coquelin@redhat.com> In-Reply-To: <20210910091734.7023-1-maxime.coquelin@redhat.com> References: <20210910091734.7023-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-dev] [PATCH 2/3] app/testpmd: fix RSS hash type update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" port_rss_hash_key_update() initializes rss_conf with the RSS hash type and key provided by the user, but it calls rte_eth_dev_rss_hash_conf_get() before calling rte_eth_dev_rss_hash_update(), which overides the parsed config with current NIC's config. While the RSS key value is set again after, this is not the case of the key length and the type of hash. There is no need to read the RSS config from the NIC, let's just try to set the user defined one. Fixes: 8205e241b2b0 ("app/testpmd: add missing type to RSS hash commands") Cc: stable@dpdk.org Cc: nelio.laranjeiro@6wind.com Signed-off-by: Maxime Coquelin --- app/test-pmd/config.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 31d8ba1b91..451bda53b1 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -2853,18 +2853,14 @@ port_rss_hash_key_update(portid_t port_id, char rss_type[], uint8_t *hash_key, int diag; unsigned int i; - rss_conf.rss_key = NULL; + rss_conf.rss_key = hash_key; rss_conf.rss_key_len = hash_key_len; rss_conf.rss_hf = 0; for (i = 0; rss_type_table[i].str; i++) { if (!strcmp(rss_type_table[i].str, rss_type)) rss_conf.rss_hf = rss_type_table[i].rss_type; } - diag = rte_eth_dev_rss_hash_conf_get(port_id, &rss_conf); - if (diag == 0) { - rss_conf.rss_key = hash_key; - diag = rte_eth_dev_rss_hash_update(port_id, &rss_conf); - } + diag = rte_eth_dev_rss_hash_update(port_id, &rss_conf); if (diag == 0) return; -- 2.31.1