DPDK patches and discussions
 help / color / mirror / Atom feed
From: Wenjun Wu <wenjun1.wu@intel.com>
To: dev@dpdk.org, qi.z.zhang@intel.com
Cc: Wenjun Wu <wenjun1.wu@intel.com>, stable@dpdk.org
Subject: [dpdk-dev] [PATCH v1 2/2] net/iavf: fix RSS configuration failure
Date: Tue, 14 Sep 2021 16:35:13 +0800	[thread overview]
Message-ID: <20210914083513.341438-3-wenjun1.wu@intel.com> (raw)
In-Reply-To: <20210914083513.341438-1-wenjun1.wu@intel.com>

Due to share code limitation, when RSS for IP packets and IP fragment
packets coexists, they cannot share the same hash field.
As a result, independent configuration of default RSS for IP fragment
packets need to be removed.

This patch revert the original patch to fix this failure.

Fixes: c40525568480 ("net/iavf: fix default RSS hash for IP fragment packets")
Fixes: 9e29a278bc0c ("net/iavf: support default RSS for IP fragment")
Cc: stable@dpdk.org

Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
---
 drivers/net/iavf/iavf_hash.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c
index eba55ecea5..03dae5d999 100644
--- a/drivers/net/iavf/iavf_hash.c
+++ b/drivers/net/iavf/iavf_hash.c
@@ -623,16 +623,6 @@ iavf_rss_hash_set(struct iavf_adapter *ad, uint64_t rss_hf, bool add)
 		iavf_add_del_rss_cfg(ad, &rss_cfg, add);
 	}
 
-	if (rss_hf & ETH_RSS_FRAG_IPV4) {
-		rss_cfg.proto_hdrs = outer_ipv4_tmplt;
-		iavf_add_del_rss_cfg(ad, &rss_cfg, add);
-	}
-
-	if (rss_hf & ETH_RSS_FRAG_IPV6) {
-		rss_cfg.proto_hdrs = outer_ipv6_tmplt;
-		iavf_add_del_rss_cfg(ad, &rss_cfg, add);
-	}
-
 	vf->rss_hf = rss_hf & IAVF_RSS_HF_ALL;
 	return 0;
 }
-- 
2.25.1


  parent reply	other threads:[~2021-09-14  8:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14  8:35 [dpdk-dev] [PATCH v1 0/2] " Wenjun Wu
2021-09-14  8:35 ` [dpdk-dev] [PATCH v1 1/2] net/ice: " Wenjun Wu
2021-09-14  8:35 ` Wenjun Wu [this message]
2021-09-16  2:34   ` [dpdk-dev] [PATCH v2 " Wenjun Wu
2021-09-16  2:35   ` [dpdk-dev] [PATCH v2 2/2] net/iavf: " Wenjun Wu
2021-09-16  2:34 ` [dpdk-dev] [PATCH v2 0/2] " Wenjun Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210914083513.341438-3-wenjun1.wu@intel.com \
    --to=wenjun1.wu@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).