From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A165A0C43; Wed, 15 Sep 2021 07:47:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B9854003F; Wed, 15 Sep 2021 07:47:14 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 44EC64003C for ; Wed, 15 Sep 2021 07:47:13 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10107"; a="244584209" X-IronPort-AV: E=Sophos;i="5.85,294,1624345200"; d="scan'208";a="244584209" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2021 22:47:12 -0700 X-IronPort-AV: E=Sophos;i="5.85,294,1624345200"; d="scan'208";a="433290377" Received: from shwdenpg235.ccr.corp.intel.com ([10.253.106.22]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2021 22:47:09 -0700 From: Alvin Zhang To: qi.z.zhang@intel.com, ferruh.yigit@intel.com Cc: dev@dpdk.org, Alvin Zhang , Ajit Khaparde , Aman Deep Singh Date: Wed, 15 Sep 2021 13:47:04 +0800 Message-Id: <20210915054704.25192-1-alvinx.zhang@intel.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20210831095255.21156-1-alvinx.zhang@intel.com> References: <20210831095255.21156-1-alvinx.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v8] ethdev: add IPv4 and L4 checksum RSS offload types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch defines new RSS offload types for IPv4 and L4(TCP/UDP/SCTP) checksum, which are required when users want to distribute packets based on the IPv4 or L4 checksum field. For example "flow create 0 ingress pattern eth / ipv4 / end actions rss types ipv4-chksum end queues end / end", this flow causes all matching packets to be distributed to queues on basis of IPv4 checksum. Signed-off-by: Alvin Zhang Reviewed-by: Qi Zhang Acked-by: Ajit Khaparde Acked-by: Aman Deep Singh --- v6: rebase to eeedef70, update some note v7: fix code style issues v8: rebase to 22a9f34e67ea, update some note --- app/test-pmd/cmdline.c | 4 +++- app/test-pmd/config.c | 2 ++ doc/guides/rel_notes/release_21_11.rst | 5 +++++ lib/ethdev/rte_ethdev.h | 18 ++++++++++++++++++ 4 files changed, 28 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 7dd3965..a9efd02 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -2252,6 +2252,8 @@ struct cmd_config_rss { rss_conf.rss_hf = ETH_RSS_ECPRI; else if (!strcmp(res->value, "mpls")) rss_conf.rss_hf = ETH_RSS_MPLS; + else if (!strcmp(res->value, "ipv4-chksum")) + rss_conf.rss_hf = ETH_RSS_IPV4_CHKSUM; else if (!strcmp(res->value, "none")) rss_conf.rss_hf = 0; else if (!strcmp(res->value, "level-default")) { @@ -2323,7 +2325,7 @@ struct cmd_config_rss { .help_str = "port config all rss " "all|default|eth|vlan|ip|tcp|udp|sctp|ether|port|vxlan|geneve|" "nvgre|vxlan-gpe|l2tpv3|esp|ah|pfcp|ecpri|mpls|none|level-default|" - "level-outer|level-inner|", + "level-outer|level-inner|ipv4-chksum|", .tokens = { (void *)&cmd_config_rss_port, (void *)&cmd_config_rss_keyword, diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index f5765b3..9c66329 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -140,6 +140,8 @@ { "gtpu", ETH_RSS_GTPU }, { "ecpri", ETH_RSS_ECPRI }, { "mpls", ETH_RSS_MPLS }, + { "ipv4-chksum", ETH_RSS_IPV4_CHKSUM }, + { "l4-chksum", ETH_RSS_L4_CHKSUM }, { NULL, 0 }, }; diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst index 43d367b..388e6bd 100644 --- a/doc/guides/rel_notes/release_21_11.rst +++ b/doc/guides/rel_notes/release_21_11.rst @@ -87,6 +87,11 @@ New Features Added command-line options to specify total number of processes and current process ID. Each process owns subset of Rx and Tx queues. +* **Add new RSS offload types for IPv4/L4 checksum in RSS flow.** + + Add macros ETH_RSS_IPV4_CHKSUM and ETH_RSS_L4_CHKSUM, now IPv4 and + TCP/UDP/SCTP header checksum field can be used as input set for RSS. + Removed Items ------------- diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index d2b27c3..d0bbe33 100644 --- a/lib/ethdev/rte_ethdev.h +++ b/lib/ethdev/rte_ethdev.h @@ -537,6 +537,24 @@ struct rte_eth_rss_conf { #define ETH_RSS_PPPOE (1ULL << 31) #define ETH_RSS_ECPRI (1ULL << 32) #define ETH_RSS_MPLS (1ULL << 33) +#define ETH_RSS_IPV4_CHKSUM (1ULL << 34) + +/** + * The ETH_RSS_L4_CHKSUM works on checksum field of any L4 header. + * It is similar to ETH_RSS_PORT that they don't specify the specific type of + * L4 header. We define this macro to replace some specific L4 (TCP/UDP/SCTP) + * checksum type for constricting the use of RSS offload bits. + * + * Due to above reason, some old APIs (and configuration) won't support + * ETH_RSS_L4_CHKSUM, rte_flow will support it, in a RSS flow the pattern type + * can specify the L4 header type, for example + * "flow create 0 ingress pattern eth / ipv4 / tcp / end actions rss types \ + * l4-chksum end queues end / end" + * + * For the case that checksum is not used in a UDP header, it takes the + * reserved value 0 as input for the hash function. + */ +#define ETH_RSS_L4_CHKSUM (1ULL << 35) /* * We use the following macros to combine with above ETH_RSS_* for -- 1.8.3.1