From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, david.marchand@redhat.com,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Akhil Goyal <gakhil@marvell.com>,
Declan Doherty <declan.doherty@intel.com>,
David Hunt <david.hunt@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Jerin Jacob <jerinj@marvell.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Pavan Nikhilesh <pbhagavatula@marvell.com>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] lib: remove C++ include guard from private headers
Date: Wed, 15 Sep 2021 11:08:07 -0700 [thread overview]
Message-ID: <20210915110807.6cf0fd26@hermes.local> (raw)
In-Reply-To: <20210915164636.3015197-1-thomas@monjalon.net>
On Wed, 15 Sep 2021 18:46:35 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:
> The private headers are compiled internally with a C compiler.
> Thus extern "C" declaration is useless in such files.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
Makes sense, make sure it doesn't break Windows builds.
There is not a C++ application regression test in CI.
next prev parent reply other threads:[~2021-09-15 18:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 16:46 Thomas Monjalon
2021-09-15 18:08 ` Stephen Hemminger [this message]
2021-09-23 6:37 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210915110807.6cf0fd26@hermes.local \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.hunt@intel.com \
--cc=david.marchand@redhat.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gakhil@marvell.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=jerinj@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=ndabilpuram@marvell.com \
--cc=olivier.matz@6wind.com \
--cc=pbhagavatula@marvell.com \
--cc=thomas@monjalon.net \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).