From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id D6E76A0C41;
Wed, 15 Sep 2021 18:30:27 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id BBE36411B2;
Wed, 15 Sep 2021 18:30:27 +0200 (CEST)
Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com
[67.231.156.173])
by mails.dpdk.org (Postfix) with ESMTP id 964AA4014F
for <dev@dpdk.org>; Wed, 15 Sep 2021 18:30:25 +0200 (CEST)
Received: from pps.filterd (m0045851.ppops.net [127.0.0.1])
by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18FAZI8t024632;
Wed, 15 Sep 2021 09:30:22 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;
h=from : to : cc :
subject : date : message-id : in-reply-to : references : mime-version :
content-type; s=pfpt0220; bh=UIr+q4SeZIgqwQfhoNlwVDyPy5D4fwZ7uTRu4XyiwVw=;
b=FWzg5w9HWblQv7GwGfN6pgZeVqj0CLrrku+B9jWfh7jpbssO9pGxkBIxMMl1hZsWaNrc
rm5tJbDCqPQZw+Y/sE6GdweU79ateT18oIzeu81wu89Loe4ubhvTkyy8QwpHulUq4bQ/
FyXPNi/w+JI4cdkz4vFkUhKtHKulJ3Lf+RTjwOdpEslzHzIrceVVrMUE3Dq5m4VBhOSU
eGsZZHkLtm0SEoyT3Rm7CI/PrTMpWsMTGs3tTWfISSrmUbiwXsWATNI3fcHWqCvmqxtb
gq62Bkf36prSMldT3wftaqe6ZZDX4RZXCbUiyJTfNl+ZV8BqOj/I2Ra9B78pQ5PwfYFC DQ==
Received: from dc5-exch01.marvell.com ([199.233.59.181])
by mx0b-0016f401.pphosted.com with ESMTP id 3b3f6y19k8-3
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);
Wed, 15 Sep 2021 09:30:22 -0700
Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com
(10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.18;
Wed, 15 Sep 2021 09:30:19 -0700
Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com
(10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend
Transport; Wed, 15 Sep 2021 09:30:20 -0700
Received: from hyd1588t430.marvell.com (unknown [10.29.52.204])
by maili.marvell.com (Postfix) with ESMTP id C03245B6972;
Wed, 15 Sep 2021 09:30:12 -0700 (PDT)
From: Nithin Dabilpuram <ndabilpuram@marvell.com>
To: <konstantin.ananyev@intel.com>, <jerinj@marvell.com>, <gakhil@marvell.com>,
<roy.fan.zhang@intel.com>, <hemant.agrawal@nxp.com>, <matan@nvidia.com>
CC: <ndabilpuram@marvell.com>, <dev@dpdk.org>, <ferruh.yigit@intel.com>,
<radu.nicolau@intel.com>, <olivier.matz@6wind.com>, <g.singh@nxp.com>,
<declan.doherty@intel.com>, <jiawenwu@trustnetic.com>
Date: Wed, 15 Sep 2021 21:59:59 +0530
Message-ID: <20210915163001.26859-2-ndabilpuram@marvell.com>
X-Mailer: git-send-email 2.8.4
In-Reply-To: <20210915163001.26859-1-ndabilpuram@marvell.com>
References: <20210624102848.3878788-1-gakhil@marvell.com>
<20210915163001.26859-1-ndabilpuram@marvell.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Proofpoint-GUID: s8mjt9wlRpF-Kmo_FRxavYeuoLTk6_jl
X-Proofpoint-ORIG-GUID: s8mjt9wlRpF-Kmo_FRxavYeuoLTk6_jl
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
definitions=2021-09-15_04,2021-09-15_01,2020-04-07_01
Subject: [dpdk-dev] [PATCH v6 1/3] security: enforce semantics for Tx inline
processing
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Not all net PMD's/HW can parse packet and identify L2 header and
L3 header locations on Tx. This is inline with other Tx offloads
requirements such as L3 checksum, L4 checksum offload, etc,
where mbuf.l2_len, mbuf.l3_len etc, needs to be set for HW to be
able to generate checksum. Since Inline IPSec is also such a Tx
offload, some PMD's at least need mbuf.l2_len to be valid to
find L3 header and perform Outbound IPSec processing.
Hence, this patch updates documentation to enforce setting
mbuf.l2_len while setting PKT_TX_SEC_OFFLOAD in mbuf.ol_flags
for Inline IPSec Crypto / Protocol offload processing to
work on Tx.
Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
---
doc/guides/nics/features.rst | 2 ++
lib/mbuf/rte_mbuf_core.h | 2 ++
2 files changed, 4 insertions(+)
diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index a96e12d..4fce8cd 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -430,6 +430,7 @@ of protocol operations. See Security library and PMD documentation for more deta
* **[uses] rte_eth_rxconf,rte_eth_rxmode**: ``offloads:DEV_RX_OFFLOAD_SECURITY``,
* **[uses] rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_SECURITY``.
+* **[uses] mbuf**: ``mbuf.l2_len``.
* **[implements] rte_security_ops**: ``session_create``, ``session_update``,
``session_stats_get``, ``session_destroy``, ``set_pkt_metadata``, ``capabilities_get``.
* **[provides] rte_eth_dev_info**: ``rx_offload_capa,rx_queue_offload_capa:DEV_RX_OFFLOAD_SECURITY``,
@@ -451,6 +452,7 @@ protocol operations. See security library and PMD documentation for more details
* **[uses] rte_eth_rxconf,rte_eth_rxmode**: ``offloads:DEV_RX_OFFLOAD_SECURITY``,
* **[uses] rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_SECURITY``.
+* **[uses] mbuf**: ``mbuf.l2_len``.
* **[implements] rte_security_ops**: ``session_create``, ``session_update``,
``session_stats_get``, ``session_destroy``, ``set_pkt_metadata``, ``get_userdata``,
``capabilities_get``.
diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h
index bb38d7f..9d8e3dd 100644
--- a/lib/mbuf/rte_mbuf_core.h
+++ b/lib/mbuf/rte_mbuf_core.h
@@ -228,6 +228,8 @@ extern "C" {
/**
* Request security offload processing on the TX packet.
+ * To use Tx security offload, the user needs to fill l2_len in mbuf
+ * indicating L2 header size and where L3 header starts.
*/
#define PKT_TX_SEC_OFFLOAD (1ULL << 43)
--
2.8.4