DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Tal Shnaiderman <talshn@nvidia.com>
Cc: <dev@dpdk.org>, <thomas@monjalon.net>, <pallavi.kadam@intel.com>,
	<navasile@linux.microsoft.com>, <dmitrym@microsoft.com>,
	<stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal/windows: fix token pasting build warning
Date: Wed, 15 Sep 2021 22:25:14 +0300	[thread overview]
Message-ID: <20210915222514.259bc13b@sovereign> (raw)
In-Reply-To: <20210913165500.21636-1-talshn@nvidia.com>

2021-09-13 19:55 (UTC+0300), Tal Shnaiderman:
> When building DPDK on Windows in debug mode the following
> warning appear:
> 
> warning: token pasting of ',' and __VA_ARGS__ is a GNU extension
> [-Wgnu-zero-variadic-macro-arguments] #define open(path, flags, ...)
> _open(path, flags, ##__VA_ARGS__)
> 
> Modified the 'open' macro to avoid it.

Nit: "Modify" (present tense should be used here).

> 
> Fixes: 45d62067c237 ("eal: make OS shims internal")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
>  lib/eal/windows/include/rte_os_shim.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows/include/rte_os_shim.h
> index 33619745ab..eda8113662 100644
> --- a/lib/eal/windows/include/rte_os_shim.h
> +++ b/lib/eal/windows/include/rte_os_shim.h
> @@ -25,7 +25,7 @@
>  #define strncasecmp(s1, s2, count) _strnicmp(s1, s2, count)
>  #endif
>  
> -#define open(path, flags, ...) _open(path, flags, ##__VA_ARGS__)
> +#define open(...) _open(__VA_ARGS__)
>  #define read(fd, buf, n) _read(fd, buf, n)
>  #define write(fd, buf, n) _write(fd, buf, n)
>  #define close(fd) _close(fd)

Note: Three-argument form of open() is seldom used in DPDK and only once
in OS-independent code. However, rte_os_shim.h can be included
in platform-specific file and it should not prevent using 3-argument open().
This patch is probably the most simple and robust thing we can do.

Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

  reply	other threads:[~2021-09-15 19:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-13 16:55 Tal Shnaiderman
2021-09-15 19:25 ` Dmitry Kozlyuk [this message]
2021-09-23 17:17   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210915222514.259bc13b@sovereign \
    --to=dmitry.kozliuk@gmail.com \
    --cc=dev@dpdk.org \
    --cc=dmitrym@microsoft.com \
    --cc=navasile@linux.microsoft.com \
    --cc=pallavi.kadam@intel.com \
    --cc=stable@dpdk.org \
    --cc=talshn@nvidia.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).