DPDK patches and discussions
 help / color / mirror / Atom feed
From: Miao Li <miao.li@intel.com>
To: dev@dpdk.org
Cc: chenbo.xia@intel.com, maxime.coquelin@redhat.com, miao.li@intel.com
Subject: [dpdk-dev] [PATCH 1/5] net/virtio: implement rte_power_monitor API
Date: Sat, 18 Sep 2021 13:22:02 +0000	[thread overview]
Message-ID: <20210918132206.166694-2-miao.li@intel.com> (raw)
In-Reply-To: <20210918132206.166694-1-miao.li@intel.com>

This patch implements rte_power_monitor API in virtio PMD to reduce
power consumption when no packet come in. According to current semantics
of power monitor, this commit adds a callback function to decide whether
aborts the sleep by checking current value against the expected value and
virtio_get_monitor_addr to provide address to monitor. When no packet come
in, the value of address will not be changed and the running core will
sleep. Once packets arrive, the value of address will be changed and the
running core will wakeup.

Signed-off-by: Miao Li <miao.li@intel.com>
---
 drivers/net/virtio/virtio_ethdev.c | 53 ++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index e58085a2c9..d6e683aa9e 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -73,6 +73,8 @@ static int virtio_mac_addr_set(struct rte_eth_dev *dev,
 				struct rte_ether_addr *mac_addr);
 
 static int virtio_intr_disable(struct rte_eth_dev *dev);
+static int virtio_get_monitor_addr(void *rx_queue,
+				struct rte_power_monitor_cond *pmc);
 
 static int virtio_dev_queue_stats_mapping_set(
 	struct rte_eth_dev *eth_dev,
@@ -975,6 +977,7 @@ static const struct eth_dev_ops virtio_eth_dev_ops = {
 	.mac_addr_add            = virtio_mac_addr_add,
 	.mac_addr_remove         = virtio_mac_addr_remove,
 	.mac_addr_set            = virtio_mac_addr_set,
+	.get_monitor_addr        = virtio_get_monitor_addr,
 };
 
 /*
@@ -1306,6 +1309,56 @@ virtio_mac_addr_set(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr)
 	return 0;
 }
 
+#define CLB_VAL_IDX 0
+#define CLB_MSK_IDX 1
+#define CLB_MATCH_IDX 2
+static int
+virtio_monitor_callback(const uint64_t value,
+		const uint64_t opaque[RTE_POWER_MONITOR_OPAQUE_SZ])
+{
+	const uint64_t m = opaque[CLB_MSK_IDX];
+	const uint64_t v = opaque[CLB_VAL_IDX];
+	const uint64_t c = opaque[CLB_MATCH_IDX];
+
+	if (c)
+		return (value & m) == v ? -1 : 0;
+	else
+		return (value & m) == v ? 0 : -1;
+}
+
+static int
+virtio_get_monitor_addr(void *rx_queue, struct rte_power_monitor_cond *pmc)
+{
+	struct virtnet_rx *rxvq = rx_queue;
+	struct virtqueue *vq = virtnet_rxq_to_vq(rxvq);
+	if (vq == NULL)
+		return -EINVAL;
+	struct virtio_hw *hw = vq->hw;
+	if (virtio_with_packed_queue(hw)) {
+		struct vring_packed_desc *desc;
+		desc = vq->vq_packed.ring.desc;
+		pmc->addr = &desc[vq->vq_used_cons_idx].flags;
+		if (vq->vq_packed.used_wrap_counter)
+			pmc->opaque[CLB_VAL_IDX] =
+						VRING_PACKED_DESC_F_AVAIL_USED;
+		else
+			pmc->opaque[CLB_VAL_IDX] = 0;
+		pmc->opaque[CLB_MSK_IDX] = VRING_PACKED_DESC_F_AVAIL_USED;
+		pmc->opaque[CLB_MATCH_IDX] = 1;
+		pmc->size = sizeof(desc[vq->vq_used_cons_idx].flags);
+	} else {
+		pmc->addr = &vq->vq_split.ring.used->idx;
+		pmc->opaque[CLB_VAL_IDX] = vq->vq_used_cons_idx
+					& (vq->vq_nentries - 1);
+		pmc->opaque[CLB_MSK_IDX] = vq->vq_nentries - 1;
+		pmc->opaque[CLB_MATCH_IDX] = 0;
+		pmc->size = sizeof(vq->vq_split.ring.used->idx);
+	}
+	pmc->fn = virtio_monitor_callback;
+
+	return 0;
+}
+
 static int
 virtio_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)
 {
-- 
2.25.1


  reply	other threads:[~2021-09-18  5:20 UTC|newest]

Thread overview: 99+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-10 13:05 [dpdk-dev] [PATCH 0/5] CPU Enabling: Implement rte_power_monitor API in virtio/vhost PMD Miao Li
2021-09-10 13:05 ` [dpdk-dev] [PATCH 1/5] net/virtio: implement rte_power_monitor API Miao Li
2021-09-15  8:45   ` Xia, Chenbo
2021-09-17  6:40     ` Li, Miao
2021-09-10 13:05 ` [dpdk-dev] [PATCH 2/5] lib/vhost: " Miao Li
2021-09-15  8:51   ` Xia, Chenbo
2021-09-17  6:51     ` Li, Miao
2021-09-10 13:05 ` [dpdk-dev] [PATCH 3/5] net/vhost: " Miao Li
2021-09-10 13:05 ` [dpdk-dev] [PATCH 4/5] lib/power: modify return of queue_stopped Miao Li
2021-09-10 13:15   ` Burakov, Anatoly
2021-09-10 13:05 ` [dpdk-dev] [PATCH 5/5] examples/l3fwd-power: support virtio/vhost Miao Li
2021-09-10  7:24   ` Maxime Coquelin
2021-09-10  8:33     ` Li, Miao
2021-09-10  8:50       ` David Marchand
2021-09-13  1:41         ` Li, Miao
2021-09-18 13:22 ` [dpdk-dev] [PATCH 0/5] Implement rte_power_monitor API in virtio/vhost PMD Miao Li
2021-09-18 13:22   ` Miao Li [this message]
2021-09-18 13:22   ` [dpdk-dev] [PATCH 2/5] vhost: implement rte_power_monitor API Miao Li
2021-09-18 13:22   ` [dpdk-dev] [PATCH 3/5] net/vhost: " Miao Li
2021-09-18 13:22   ` [dpdk-dev] [PATCH 4/5] power: modify return of queue_stopped Miao Li
2021-09-18 13:22   ` [dpdk-dev] [PATCH 5/5] examples/l3fwd-power: support virtio/vhost Miao Li
2021-09-24 10:23   ` [dpdk-dev] [PATCH v3 0/5] Implement rte_power_monitor API in virtio/vhost PMD Miao Li
2021-09-24 10:23     ` [dpdk-dev] [PATCH v3 1/5] net/virtio: implement rte_power_monitor API Miao Li
2021-09-29  2:34       ` Xia, Chenbo
2021-09-24 10:23     ` [dpdk-dev] [PATCH v3 2/5] vhost: " Miao Li
2021-09-29  3:01       ` Xia, Chenbo
2021-10-11  5:16         ` Li, Miao
2021-09-24 10:23     ` [dpdk-dev] [PATCH v3 3/5] net/vhost: " Miao Li
2021-09-24 10:23     ` [dpdk-dev] [PATCH v3 4/5] power: modify return of queue_stopped Miao Li
2021-09-29  3:03       ` Xia, Chenbo
2021-10-11  5:18         ` Li, Miao
2021-09-24 10:23     ` [dpdk-dev] [PATCH v3 5/5] examples/l3fwd-power: support virtio/vhost Miao Li
2021-09-29  6:53       ` Xia, Chenbo
2021-10-11  5:22         ` Li, Miao
2021-10-12 14:22     ` [dpdk-dev] [PATCH v4 0/5] Implement rte_power_monitor API in virtio/vhost PMD Miao Li
2021-10-12 14:22       ` [dpdk-dev] [PATCH v4 1/5] net/virtio: implement rte_power_monitor API Miao Li
2021-10-12 14:22       ` [dpdk-dev] [PATCH v4 2/5] vhost: " Miao Li
2021-10-12 14:22       ` [dpdk-dev] [PATCH v4 3/5] net/vhost: " Miao Li
2021-10-12 14:22       ` [dpdk-dev] [PATCH v4 4/5] power: modify return of queue_stopped Miao Li
2021-10-12 14:22       ` [dpdk-dev] [PATCH v4 5/5] examples/l3fwd-power: support virtio/vhost Miao Li
2021-10-15 15:12       ` [dpdk-dev] [PATCH v5 0/5] Implement rte_power_monitor API in virtio/vhost PMD Miao Li
2021-10-15 15:12         ` [dpdk-dev] [PATCH v5 1/5] net/virtio: implement rte_power_monitor API Miao Li
2021-10-15 15:12         ` [dpdk-dev] [PATCH v5 2/5] vhost: " Miao Li
2021-10-15  7:38           ` Xia, Chenbo
2021-10-15  8:47             ` Li, Miao
2021-10-15 15:12         ` [dpdk-dev] [PATCH v5 3/5] net/vhost: " Miao Li
2021-10-15  7:39           ` Xia, Chenbo
2021-10-15  8:49             ` Li, Miao
2021-10-15 15:12         ` [dpdk-dev] [PATCH v5 4/5] power: modify return of queue_stopped Miao Li
2021-10-15  7:47           ` Xia, Chenbo
2021-10-15  8:50             ` Li, Miao
2021-10-15 15:12         ` [dpdk-dev] [PATCH v5 5/5] examples/l3fwd-power: support virtio/vhost Miao Li
2021-10-15  8:13           ` Xia, Chenbo
2021-10-15  8:51             ` Li, Miao
2021-10-15 17:09         ` [dpdk-dev] [PATCH v6 0/5] Implement rte_power_monitor API in virtio/vhost PMD Miao Li
2021-10-15 12:57           ` Maxime Coquelin
2021-10-18  1:54             ` Li, Miao
2021-10-15 17:09           ` [dpdk-dev] [PATCH v6 1/5] net/virtio: implement rte_power_monitor API Miao Li
2021-10-15 17:09           ` [dpdk-dev] [PATCH v6 2/5] vhost: " Miao Li
2021-10-15 17:09           ` [dpdk-dev] [PATCH v6 3/5] net/vhost: " Miao Li
2021-10-15 17:09           ` [dpdk-dev] [PATCH v6 4/5] power: modify return of queue_stopped Miao Li
2021-10-15 17:09           ` [dpdk-dev] [PATCH v6 5/5] examples/l3fwd-power: support virtio/vhost Miao Li
2021-10-18 14:16           ` [dpdk-dev] [PATCH v7 0/5] Implement rte_power_monitor API in virtio/vhost PMD Miao Li
2021-10-18 14:16             ` [dpdk-dev] [PATCH v7 1/5] net/virtio: implement rte_power_monitor API Miao Li
2021-10-21 16:50               ` Ferruh Yigit
2021-10-22  8:22                 ` Li, Miao
2021-10-21 16:59               ` Ferruh Yigit
2021-10-22  8:28                 ` Li, Miao
2021-10-22  8:51                   ` Li, Miao
2021-10-22  8:59                     ` Ferruh Yigit
2021-10-22  9:02                       ` Xia, Chenbo
2021-10-22 13:41               ` David Hunt
2021-10-18 14:16             ` [dpdk-dev] [PATCH v7 2/5] vhost: " Miao Li
2021-10-19  4:38               ` Xia, Chenbo
2021-10-22 12:34                 ` David Hunt
2021-10-18 14:16             ` [dpdk-dev] [PATCH v7 3/5] net/vhost: " Miao Li
2021-10-19  4:39               ` Xia, Chenbo
2021-10-22 12:01                 ` David Hunt
2021-10-18 14:16             ` [dpdk-dev] [PATCH v7 4/5] power: modify return of queue_stopped Miao Li
2021-10-21 16:48               ` Ferruh Yigit
2021-10-22  8:20                 ` Li, Miao
2021-10-22  9:01                   ` Ferruh Yigit
2021-10-22  9:05                     ` Li, Miao
2021-10-22 11:54                 ` David Hunt
2021-10-18 14:16             ` [dpdk-dev] [PATCH v7 5/5] examples/l3fwd-power: support virtio/vhost Miao Li
2021-10-19  4:39               ` Xia, Chenbo
2021-10-22 11:50                 ` David Hunt
2021-10-21 16:58               ` Ferruh Yigit
2021-10-21 12:35             ` [dpdk-dev] [PATCH v7 0/5] Implement rte_power_monitor API in virtio/vhost PMD Maxime Coquelin
2021-10-25 14:47             ` [dpdk-dev] [PATCH v8 0/5] Support power monitor " Miao Li
2021-10-25  7:06               ` Xia, Chenbo
2021-10-28  8:03                 ` Maxime Coquelin
2021-10-25 14:47               ` [dpdk-dev] [PATCH v8 1/5] net/virtio: support power monitor Miao Li
2021-10-25 14:47               ` [dpdk-dev] [PATCH v8 2/5] vhost: add power monitor support API Miao Li
2021-10-25 14:47               ` [dpdk-dev] [PATCH v8 3/5] net/vhost: support power monitor Miao Li
2021-10-25 14:47               ` [dpdk-dev] [PATCH v8 4/5] power: modify return of queue_stopped Miao Li
2021-10-25 14:47               ` [dpdk-dev] [PATCH v8 5/5] examples/l3fwd-power: support virtio/vhost Miao Li
2021-10-29 19:09                 ` Ferruh Yigit
2021-10-29 10:34               ` [dpdk-dev] [PATCH v8 0/5] Support power monitor in virtio/vhost PMD Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210918132206.166694-2-miao.li@intel.com \
    --to=miao.li@intel.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).