From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A29FA0C45; Wed, 22 Sep 2021 12:15:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C5EC41198; Wed, 22 Sep 2021 12:15:48 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id BC8FC41196 for ; Wed, 22 Sep 2021 12:15:45 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10114"; a="203717087" X-IronPort-AV: E=Sophos;i="5.85,313,1624345200"; d="scan'208";a="203717087" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2021 03:15:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,313,1624345200"; d="scan'208";a="474505516" Received: from silpixa00400308.ir.intel.com ([10.237.214.190]) by fmsmga007.fm.intel.com with ESMTP; 22 Sep 2021 03:15:15 -0700 From: Przemyslaw Zegan To: dev@dpdk.org Cc: gakhil@marvell.com, roy.fan.zhang@intel.com, Przemyslaw Zegan , pablo.de.lara.guarch@intel.com Date: Wed, 22 Sep 2021 11:15:11 +0100 Message-Id: <20210922101511.10395-1-przemyslawx.zegan@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210921132125.6109-1-przemyslawx.zegan@intel.com> References: <20210921132125.6109-1-przemyslawx.zegan@intel.com> Subject: [dpdk-dev] [dpdk-dev v2] app: fix buffer overrun X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch fixes a possible buffer overrun problem in crypto perf test. Previously when user configured aad size is over 12 bytes the copy of template aad will cause a buffer overrun. The problem is fixed by only copy up to 12 bytes of aad template. Fixes: 8a5b494a7f99 ("app/test-crypto-perf: add AEAD parameters") Cc: pablo.de.lara.guarch@intel.com Signed-off-by: Przemyslaw Zegan --- v2: - changed to correct fixed line. app/test-crypto-perf/cperf_test_vectors.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/app/test-crypto-perf/cperf_test_vectors.c b/app/test-crypto-perf/cperf_test_vectors.c index 0af01ff911..2c7e314ec8 100644 --- a/app/test-crypto-perf/cperf_test_vectors.c +++ b/app/test-crypto-perf/cperf_test_vectors.c @@ -548,12 +548,16 @@ cperf_test_vector_get_dummy(struct cperf_options *options) t_vec->aead_key.data = aead_key; if (options->aead_aad_sz) { - t_vec->aad.data = rte_malloc(NULL, + t_vec->aad.data = rte_zmalloc(NULL, options->aead_aad_sz, 16); if (t_vec->aad.data == NULL) { rte_free(t_vec); return NULL; } + + if(options->aead_aad_sz > 12) + options->aead_aad_sz = 12; + memcpy(t_vec->aad.data, aad, options->aead_aad_sz); t_vec->aad.phys_addr = rte_malloc_virt2iova(t_vec->aad.data); t_vec->aad.length = options->aead_aad_sz; -- 2.17.1 -------------------------------------------------------------- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.