From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 3DAACA0C47;
Wed, 22 Sep 2021 22:51:25 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id C7E90411EC;
Wed, 22 Sep 2021 22:51:24 +0200 (CEST)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
by mails.dpdk.org (Postfix) with ESMTP id 819D5411A8;
Wed, 22 Sep 2021 22:51:22 +0200 (CEST)
X-IPAS-Result: =?us-ascii?q?A2E+BADalkth/x0Y/QpagmIChGKWaZp4gXwLAQEBAQEBA?=
=?us-ascii?q?QEBCUEEAQGEfYJJJjQJDgECBAEBAQEDAgMBAQEBAQEDAQEBBQEBAQEBAQUCA?=
=?us-ascii?q?QEBAQKBIIUvRkABEAGBYyKEIgsBRoFRgnG0IzKBAYgVgWOBOgGJDYUugVVEg?=
=?us-ascii?q?RWCc3WEC4EGhTAEiRB7EzCXMot2nHItB4MvgTEGC50EGjGnBAG2TAtXhEeBY?=
=?us-ascii?q?YIVMxojgzlRGQ+dEFQ4AgYLAQEDCYhrhEeCRgEB?=
IronPort-PHdr: A9a23:cLaxcBdBthWByx4OjdxR8NvllGM+jt7LVj580XLHo4xHfqnrxZn+J
kuXvawr0AWRG9yFtLkd1rOempujcFRI2YyGvnEGfc4EfD4+ouJSoTYdBtWYA1bwNv/gYn9yN
s1DUFh44yPzahANS47xaFLIv3K98yMZFAnhOgppPOT1HZPZg9iq2+yo9JDffRlEiCCgbb5zL
hi6ohjdu8kLjYB/Nqs/1xzFr2dSde9L321oP1WTnxj95se04pFu9jlbtuwi+cBdT6j0Zrw0Q
rNEAjsoNWA1/9DrugLYTQST/HscU34ZnQRODgPY8Rz1RJbxsi/9tupgxCmXOND9QL4oVTi+6
apgVRnlgzoFOTEk6mHaksx+grxGrhyvpBJxxIHbbo6OOfZifa7QZ88WSHBdUspNUSFKH4Oyb
5EID+oEJetWtZPyp18KrRSkGwmsBf7kxDpSiXDrx6I61vkqHAbe3AM6G9IOtG7brMv0NKsIU
uC61rTHwi/Gb/5N2Df97pTIfQ4lof2WQb1wds/RxFApGgjYgVqetZbrMCmJ1uQRrWeb9exgW
PqyhmMjpQx8oDqiy8YyhoTLho8YylDK+TlkzIg6O9G1TEx2bMK4HZZUtyyWKYR4T8IhTm9nt
yg0yqAKtJ2lcCUIzpks2h3Ra+SffoSV/h7vTvidLDd2iX5/Zr6yiAy+/Vakx+D6S8K6ykxFr
jBfndnJrn0N0hvT5dWZRfZl5Ueh3CqP1xjU6uFZPUA4jarbJIAlwr43jpcdsUPNEDLxlkv3k
KKaalko9+ay5+TpZ7XqvJ6cN4loig7gNqQigNCwAeM9MgQWXmib//qz1KH78EHkXLlGlOM6n
6nXvZzAO8gWqbS1DxFR34o77hawFTam0NAWnXkdK1JFfQqKj5DzNFHKJPD3F+m/g1W2nDdo3
f/JI6fuApDWI3jClrfhYahy60pGxAUvytBf4opYCqsdL/LrRk/xqNvYAwciMwyo2enoE9F92
Z0FVG2SGq+WLaDSvUWP5uI1LOmGfJUVtyrlK/g5+/7uimc0lkIDcqm3xpYYdWi4EellI0mDZ
nrsmNgBQi82uV8yQfLChEWOUnhUfXnhcbg742QDAYaiBJnCDqOkjLWElHOjF5lSb35HTFOFH
X7tX4SCR/oILimVJ5kywXQ/SbG9Rtp5hlmVvwjgxu8/Rtc=
IronPort-Data: A9a23:2gJ5VqkcY4hu79rtpQP//E/o5gw3JERdPkR7XQ2eYbSJt1+Wr1Gzt
xIeDzuPOPjfNGH1f41/Pd+z8xgE7MeHxt9hSABurnwxQi4T+ZvOCP2ndXv9bniYRiHhoOOLz
Cm8hv3odZhsJpMJjk71atANi1Eij/nQLlbbILecY3ksLeNcpaNIZStLw4bVuKYx6TSCK17L6
Y6aT/H3Ygf/gmYlaDhMt8pvlTs21BjMkGJA1rABTa0T1LPuvyF94EU3fvnZw9PQG+G4L8biL
wrx5OjRElDxpn/BPuiYfoPTKSXmdJaJZFTT1SAGM0SVqkMqSiQais7XPReHAKtdo23hc9tZk
b2huXErIOuA02KldOk1CnFl/y9C0aJu3pDoelqNl8+pwBeXYUW94tp1JmMtBNhNkgp3KTkmG
f0wBhU2Sz+q37rthry+DOhqmsknasLsOevzuFk5lXeDUK1gG8yFGfSiCdxwhV/cguhWFPLab
tQYLzlmYB3FSxxJJloTTpk5mY9Eg1GlKWYD9A7P//dfD2777gpp25zRLObpRfuYGd9JwBqmr
GTX8DGsav0dHJnFodafyVq3mubFmS7TVJoeF/u/7PECqFGe2EQfEBEVE1yhrpGEZlWWVddEL
kMdonJ166Y3sk2tUtT5GRa/pRZooyIhZjaZKMVigCnl90Yey1rGboTYZlatsOAbifI=
IronPort-HdrOrdr: A9a23:mUG4b6s//EcorZzylECe2Ezv7skDYdV00zEX/kB9WHVpmwKj+f
xG+85rsSMc5wxwZJhNo7y90cq7MBbhHOBOkOos1N6ZNWGKhILCFuBfBOXZrAEIXBeUygda78
1dmtBFeb/NMWQ=
X-IronPort-AV: E=McAfee;i="6200,9189,10115"; a="223344225"
X-IronPort-AV: E=Sophos;i="5.85,315,1624345200"; d="scan'208";a="223344225"
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
22 Sep 2021 13:51:04 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.85,315,1624345200"; d="scan'208";a="550413120"
Received: from win-dpdk-pallavi.jf.intel.com (HELO localhost.localdomain)
([10.166.188.111])
by FMSMGA003.fm.intel.com with ESMTP; 22 Sep 2021 13:51:04 -0700
From: Pallavi Kadam <pallavi.kadam@intel.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, thomas@monjalon.net, ranjit.menon@intel.com,
dmitry.kozliuk@gmail.com, talshn@nvidia.com, Narcisa.Vasile@microsoft.com,
Vipin.Varghese@intel.com, pallavi.kadam@intel.com
Date: Wed, 22 Sep 2021 14:19:06 -0700
Message-Id: <20210922211906.2135-1-pallavi.kadam@intel.com>
X-Mailer: git-send-email 2.31.1.windows.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH] bus/pci: fix numa node return value
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On older CPUs, currently numa_node returns value only for socket 0.
Instead, application should be able to make correct decision and
also to keep consistent with the Linux code,
replace the return value to -1.
Fixes: ac7c98d04f2c ("bus/pci: ignore missing NUMA node on Windows")
Cc: talshn@nvidia.com
Cc: stable@dpdk.org
Reported-by: Vipin Varghese <Vipin.Varghese@intel.com>
Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
---
drivers/bus/pci/windows/pci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.c
index d39a7748b8..343ef6f33b 100644
--- a/drivers/bus/pci/windows/pci.c
+++ b/drivers/bus/pci/windows/pci.c
@@ -5,6 +5,7 @@
#include <rte_errno.h>
#include <rte_log.h>
#include <rte_eal.h>
+#include <rte_memory.h>
#include "private.h"
#include "pci_netuio.h"
@@ -243,7 +244,7 @@ get_device_resource_info(HDEVINFO dev_info,
DWORD error = GetLastError();
if (error == ERROR_NOT_FOUND) {
/* On older CPUs, NUMA is not bound to PCIe locality. */
- dev->device.numa_node = 0;
+ dev->device.numa_node = SOCKET_ID_ANY;
return ERROR_SUCCESS;
}
RTE_LOG_WIN32_ERR("SetupDiGetDevicePropertyW"
--
2.31.1.windows.1