From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E22EDA0C43; Thu, 23 Sep 2021 08:26:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E118410DD; Thu, 23 Sep 2021 08:26:31 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 4C7C4410DC for ; Thu, 23 Sep 2021 08:26:30 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18MJigw0016921; Wed, 22 Sep 2021 23:26:29 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=HeMZ7eKrjxqa7z/VcmUJOX7hhErrcxTogawOPP5DcrM=; b=LaQUnBbLSZJshMInks1rxT1t3EOHPY813S09FDQxmg2O35slrgAsrVKuoXi9AmQRrxNJ /SJp9RkdlRnhDiCeUGNP2d8jsawgy+jNJiAbObtHkpmFTD9XnLtuRVM3T7FNPvSpE83z fM8Y3JSbTkTcMjwzBWRtHJ8NGwtQeBVd/IMaoSyX7Idej1YgT6HSwFXlXQEu66k1OxfX 6jrL0OvIMD4Qu6vTn9rgnk/qwJyUFUBnTz6B1+tgl53A35CJnuVwvqxMl7PnEcmpgNZD ccmolPboUCZTpGxHvEU/iO9QKZarZVwbIgqR6v3e88HrOGO6P0B/M9mrtt5QmQkcoJxm Pw== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com with ESMTP id 3b8awj1ucu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 22 Sep 2021 23:26:29 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 22 Sep 2021 23:26:28 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Wed, 22 Sep 2021 23:26:27 -0700 Received: from localhost.localdomain (unknown [10.28.34.38]) by maili.marvell.com (Postfix) with ESMTP id D553F3F703F; Wed, 22 Sep 2021 23:26:25 -0700 (PDT) From: Gowrishankar Muthukrishnan To: CC: , , , Gowrishankar Muthukrishnan Date: Thu, 23 Sep 2021 11:56:19 +0530 Message-ID: <20210923062619.2285556-1-gmuthukrishn@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210923062146.2285376-1-gmuthukrishn@marvell.com> References: <20210923062146.2285376-1-gmuthukrishn@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-GUID: TMTkNmra0mSp85kutHVL1W3eDeDT4j0V X-Proofpoint-ORIG-GUID: TMTkNmra0mSp85kutHVL1W3eDeDT4j0V X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-23_02,2021-09-22_01,2020-04-07_01 Subject: [dpdk-dev] [v4] telemetry: fix json output buffer size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fix json output buffer size for a single largest value. Fixes: 52af6ccb2b39 ("telemetry: add utility functions for creating JSON") Signed-off-by: Gowrishankar Muthukrishnan --- v4: - corrected typo in commit message. v3: - use "len" param as buffer size. --- lib/telemetry/telemetry_json.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/telemetry/telemetry_json.h b/lib/telemetry/telemetry_json.h index ad270b9b30..f02a12f5b0 100644 --- a/lib/telemetry/telemetry_json.h +++ b/lib/telemetry/telemetry_json.h @@ -9,6 +9,7 @@ #include #include #include +#include /** * @file @@ -23,13 +24,13 @@ * @internal * Copies a value into a buffer if the buffer has enough available space. * Nothing written to buffer if an overflow ocurs. - * This function is not for use for values larger than 1k. + * This function is not for use for values larger than given buffer length. */ __rte_format_printf(3, 4) static inline int __json_snprintf(char *buf, const int len, const char *format, ...) { - char tmp[1024]; + char tmp[len]; va_list ap; int ret; -- 2.25.1