From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 929BEA0C43; Thu, 23 Sep 2021 18:58:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 18A7641260; Thu, 23 Sep 2021 18:58:52 +0200 (CEST) Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by mails.dpdk.org (Postfix) with ESMTP id 729CB41257 for ; Thu, 23 Sep 2021 18:58:51 +0200 (CEST) Received: by mail-pg1-f179.google.com with SMTP id r2so6954079pgl.10 for ; Thu, 23 Sep 2021 09:58:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4BzocLy5Ux58Nd1va/Ewnp5FhzrdYsPSH8kA3D1LIjg=; b=fvaTttzpCfjZqGsk0SiKpb/vUkxPKkLE45p6gV+sNvNG4VrVGakpF0WIh50hS1kJm0 47ig/8+lINFWxPuHB6xAXGVyqCYtkOHko7qCgkz9X4wZ8ZhmTgVoLBDLQJaxMeb3XVH/ B15fP8O4biZz25VBZi6Ab+Fuv0DoqlGkCG6PXjQbx0hfq+O3ccVP7dr9TBLldSP+C/lW A27ebf1dxA8ml2TVeIMJrbIzwM66WYDcbGKk2RsUTBE4CXJbp+7gEk/L14lCylLB/f4S Cy+8a5DRQXKbITQq+j3WDopQYtAG8cvzIcI3KFocLLZdiL/7DnKuhZ9nrjUNSkKtfMcv jCTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4BzocLy5Ux58Nd1va/Ewnp5FhzrdYsPSH8kA3D1LIjg=; b=jwHljFQympjMgv2lBBlEZdpxrJ8mLE5W5nykBKJ69tlbZJ7BErxHBHC7+Lcik1bYLq I8Exz6GjleYLD0Im7FkgO5Z/NObTbX/H0DW/yO0Zt2fDJdENfCAEMullmwJbe+JYSIx8 iukIzEcf4DLvc5oNZ8XK+7ZJhtuN2krN0gq9SRHwTQHfvcKs7/vdhPS0Hq9+OOiELBQ2 2fc843YW86HIJ6qMZXXxBXjN6uXcNW0pda4+n/gZZ3UygsoxQpbVr18MlWtTKA9wqFJh V7oa80F9J4A8ygNrMbTpd+SGfSYGdiUueg1+A0tSTTXw+cC5z8Zc0/N4x36Ydd4u4t18 ekHw== X-Gm-Message-State: AOAM530q8J4J9hqFvVSW7KesIkz8hHOMnjSYlE0zckmvy/8brMeHIwJP zm4AbWv1p7Q1DeEw6aplYLG97g== X-Google-Smtp-Source: ABdhPJyiC6W2HKW4V8pI2P7Bog812lnelJt35YGedY8MVVjymb+d8jtgJsYXBDGW+uTIw/2E6xoV/w== X-Received: by 2002:a62:64d3:0:b0:43d:ba3:1e2c with SMTP id y202-20020a6264d3000000b0043d0ba31e2cmr5226053pfb.5.1632416330476; Thu, 23 Sep 2021 09:58:50 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id b10sm6278584pfl.220.2021.09.23.09.58.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Sep 2021 09:58:50 -0700 (PDT) Date: Thu, 23 Sep 2021 09:58:47 -0700 From: Stephen Hemminger To: "Pattan, Reshma" Cc: "dev@dpdk.org" Message-ID: <20210923095847.78c0cc18@hermes.local> In-Reply-To: References: <20210903004732.109023-1-stephen@networkplumber.org> <20210916222630.71543-1-stephen@networkplumber.org> <20210916222630.71543-7-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v10 06/12] pdump: support pcapng and filtering X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 23 Sep 2021 16:11:42 +0000 "Pattan, Reshma" wrote: > > +/* > > + * Note: version numbers intentionally start at 3 > > + * in order to catch any application built with older out > > + * version of DPDK using incompatible client request format. > > + */ > > enum pdump_version { > > - V1 = 1 > > + PDUMP_CLIENT_LEGACY = 3, > > + PDUMP_CLIENT_PCAPNG = 4, > The version numbering was internal to library, applications do not have control over it, can't we start enumeration from 1? Although, DPDK does not support mixing versions between primary/secondary process. Someone is sure to try. I wanted to make sure that if user did something invalid like using old pdump (built with DPDK 20.11) and new application that it would fail in a direct manner.