From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6C98A0C43; Thu, 23 Sep 2021 09:35:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 976F54123E; Thu, 23 Sep 2021 09:35:41 +0200 (CEST) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by mails.dpdk.org (Postfix) with ESMTP id 233F3410DC for <dev@dpdk.org>; Thu, 23 Sep 2021 09:35:40 +0200 (CEST) Received: by mail-lf1-f51.google.com with SMTP id t10so23015994lfd.8 for <dev@dpdk.org>; Thu, 23 Sep 2021 00:35:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=06NTPlK2R7H5C82nIUKv00dxKnaRXA0lYYJKz+7HkE0=; b=cL3gRA7jE9wLk3xWcg3ZOvBemTmK0YKyjzkCKKHBA2nlBMp1CAiDmg3QntlijATI5e mey0gMRhVbLW4rPzEfCcM+UVDKEg5VRPQrIkE15sf0724nObt5SiRrhL+1/G/GRr/r2g FwSacWwwi2uFq3tVCf6tG5ImavLH+Ba1h9ZKh5UeMKL2AP/BPsPOqyJymxin9Q8JJ3mv PCnO+WEuzrIAdyfo8NSikN0JiQYC3jfHZjee7VYEiIk/bKDkzFXEI9D3HAhceFYJhOQL rIjjofNrDuffBRR1MxAtXFj9mEBG5UQP3mtlnDpO2OtCvXFYlkNvixfurg0+N6lOybNn FGvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=06NTPlK2R7H5C82nIUKv00dxKnaRXA0lYYJKz+7HkE0=; b=Lqq+KZrvNr/5dZEcryJG+k6OOHgl1xQWvgiWkdeTikBuWbK7ZfSrbTlxrR8hzx2Zrm jpIHnaNrD7e/SNE6JuXjWuF37WkFK7PNroYbVdMy18RDcXNCKdDukgLnA7wtugRz4BDa Pokswf9jkUHkiX1B6FJn0RK/R3f9ktMWjn7ZQngeV56oyPnlM8/QZjiyNGZ5xoElAf0i M5cJ579pDBSzDeMU7HKcQMDj7ZzCf65cVJVvrGgvtYV9YqZOF30KEQ4LF3MDaIM+dDIx 0aYh9A8MJaCBHiZpHG8pvSKsfpVgQvTBHqwI5RebNQUgGcsKuMdHbWMXqTP4PUOIB6KP jsnQ== X-Gm-Message-State: AOAM533mvLhmyfMXuDt7LTbytWiGSPIbg0qhQaDCPzwUTABkKSvvEGCB 5ckI8doytvoKqg/nMBY5q74= X-Google-Smtp-Source: ABdhPJy930w3YZNDxsuZK9E4mXdD9ZjygaA6uSyRFX4+EPC0Eq8LYMPlPPGzQfCbtlqkH9p0D+oVKQ== X-Received: by 2002:a2e:8852:: with SMTP id z18mr3763162ljj.412.1632382539555; Thu, 23 Sep 2021 00:35:39 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id n22sm380490lfq.119.2021.09.23.00.35.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Sep 2021 00:35:38 -0700 (PDT) Date: Thu, 23 Sep 2021 10:35:37 +0300 From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> To: Jie Zhou <jizh@linux.microsoft.com>, Aaron Conole <aconole@redhat.com> Cc: dev@dpdk.org, roretzla@microsoft.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, talshn@nvidia.com, thomas@monjalon.net Message-ID: <20210923103537.48e90b45@sovereign> In-Reply-To: <20210908221423.GA10148@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1629306834-6277-1-git-send-email-jizh@linux.microsoft.com> <1630729155-24584-1-git-send-email-jizh@linux.microsoft.com> <1630729155-24584-14-git-send-email-jizh@linux.microsoft.com> <f7tsfyg4i1v.fsf@redhat.com> <20210908221423.GA10148@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 13/13] app/test: enable subset of unit tests on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 2021-09-08 15:14 (UTC-0700), Jie Zhou: > On Tue, Sep 07, 2021 at 09:43:56AM -0400, Aaron Conole wrote: > > Jie Zhou <jizh@linux.microsoft.com> writes: > > > > > Enable a subset of unit tests on Windows. Currently not all the > > > dependencies (e.g. libraries and some functionalities) of all unit > > > tests are supported on Windows yet. > > > > > > Signed-off-by: Jie Zhou <jizh@linux.microsoft.com> > > > --- > > > > Hi Jie, > > > > How is it expected that a developer will add unit tests here? For > > example, let's pretend I develop some new test. Do I insert it into the > > non-windows section or the 'all' section? Will it ever be moved common > > (for example, do windows development team aim to provide some additional > > test / review cycles for new tests added)? This have some implication > > on how developers need to add tests - maybe there can be a documented > > process for getting code more common (between windows / linux / > > freebsd)? > > > > -Aaron > > > > PS: I would suggest a possible route is to update to the doc proposed in > > http://patches.dpdk.org/project/dpdk/patch/20210714164047.511561-1-aconole@redhat.com/ > > but it still isn't merged. > > Thank you Aaron for bringing up this great question! Totally agree that we need some discussion on what is the expectation for onboarding new unit tests from different OS teams. For new tests that definitely missing supports on certain OS(s), should it be authored in a way for across all OSs but skip not supported ones at the beginning? Or just onboard for supported OS thus only add to the non-windows section for example, and later DPDK Windows team move it to common section after porting? I will bring this up in DPDK Windows Community meeting and discuss there first. Yes, we should update the doc (after your change merged) on the process once reaching some agreement. Hi Aaron, Jie, Currently tests that should not run on certain platforms are disabled with #ifdef. This has an advantage that these tests mark themselves as skipped. There are no principal objections against this approach instead of many lists. Many tests files will need to be modified, but only mechanically. New tests for generic features should be cross-platform by default; why not? An exception I can think of is EAL that may implement some new API only for one OS. In this case the best we can do is to make sure the test code is not inherently bound to some OS. This is something we can document. For example, it should use <rte_ip.h> instead of including Unix network headers directly.