From: Ivan Malov <ivan.malov@oktetlabs.ru>
To: dev@dpdk.org
Cc: Andy Moreton <amoreton@xilinx.com>
Subject: [dpdk-dev] [PATCH v3 0/5] A means to negotiate delivery of Rx meta data
Date: Thu, 23 Sep 2021 14:20:07 +0300 [thread overview]
Message-ID: <20210923112012.14595-1-ivan.malov@oktetlabs.ru> (raw)
In-Reply-To: <20210902142359.28138-1-ivan.malov@oktetlabs.ru>
In 2019, commit [1] announced changes in DEV_RX_OFFLOAD namespace
intending to add new flags, RSS_HASH and FLOW_MARK. Since then,
only the former has been added. The problem hasn't been solved.
Applications still assume that no efforts are needed to enable
flow mark and similar meta data delivery.
The team behind net/sfc driver has to take over the efforts since
the problem has started impacting us. Riverhead, a cutting edge
Xilinx smart NIC family, has two Rx prefix types. Rx meta data
is available only from long Rx prefix. Switching between the
prefix formats can't happen in started state. Hence, we run
into the same problem which [1] was aiming to solve.
Rx meta data (mark, flag, tunnel ID) delivery is not an offload
on its own since the corresponding flows must be active to set
the data in the first place. Hence, adding offload flags
similar to RSS_HASH is not a good idea.
Patch [1/5] of this series adds a generic API to let applications
negotiate delivery of Rx meta data during initialisation period.
This way, an application knows right from the start which parts
of Rx meta data won't be delivered. Hence, no necessity to try
inserting flows requesting such data and handle the failures.
Major clients of the flow library like Open vSwitch will have
to be patched separately to benefit from the new approach.
[1] c5b2e78d1172 ("doc: announce ethdev API changes in offload flags")
Changes in v2:
* [1/5] has review notes from Jerin Jacob applied and the ack from Ray Kinsella added
* [2/5] has minor adjustments incorporated to follow changes in [1/5]
Changes in v3:
* [1/5] through [5/5] have review notes from Andy Moreton applied (mostly rewording)
* [1/5] has the ack from Jerin Jacob added
Ivan Malov (5):
ethdev: add API to negotiate delivery of Rx meta data
net/sfc: support API to negotiate delivery of Rx meta data
net/sfc: support flow mark delivery on EF100 native datapath
common/sfc_efx/base: add RxQ flag to use Rx prefix user flag
net/sfc: report user flag on EF100 native datapath
app/test-flow-perf/main.c | 21 ++++++++++
app/test-pmd/testpmd.c | 26 +++++++++++++
doc/guides/rel_notes/release_21_11.rst | 9 +++++
drivers/common/sfc_efx/base/ef10_rx.c | 54 ++++++++++++++++----------
drivers/common/sfc_efx/base/efx.h | 4 ++
drivers/common/sfc_efx/base/rhead_rx.c | 3 ++
drivers/net/sfc/sfc.h | 2 +
drivers/net/sfc/sfc_ef100_rx.c | 19 +++++++++
drivers/net/sfc/sfc_ethdev.c | 29 ++++++++++++++
drivers/net/sfc/sfc_flow.c | 11 ++++++
drivers/net/sfc/sfc_mae.c | 22 ++++++++++-
drivers/net/sfc/sfc_rx.c | 6 +++
lib/ethdev/ethdev_driver.h | 19 +++++++++
lib/ethdev/rte_ethdev.c | 25 ++++++++++++
lib/ethdev/rte_ethdev.h | 45 +++++++++++++++++++++
lib/ethdev/rte_flow.h | 12 ++++++
lib/ethdev/version.map | 3 ++
17 files changed, 287 insertions(+), 23 deletions(-)
--
2.20.1
next prev parent reply other threads:[~2021-09-23 11:20 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 14:23 [dpdk-dev] [PATCH 0/5] A means to negotiate support for Rx meta information Ivan Malov
2021-09-02 14:23 ` [dpdk-dev] [PATCH 1/5] ethdev: add API " Ivan Malov
2021-09-02 14:47 ` Jerin Jacob
2021-09-02 16:14 ` Kinsella, Ray
2021-09-03 9:34 ` Jerin Jacob
2021-09-02 14:23 ` [dpdk-dev] [PATCH 2/5] net/sfc: provide API to negotiate supported Rx meta features Ivan Malov
2021-09-02 14:23 ` [dpdk-dev] [PATCH 3/5] net/sfc: allow to use EF100 native datapath Rx mark in flows Ivan Malov
2021-09-02 14:23 ` [dpdk-dev] [PATCH 4/5] common/sfc_efx/base: add RxQ flag to use Rx prefix user flag Ivan Malov
2021-09-02 14:23 ` [dpdk-dev] [PATCH 5/5] net/sfc: allow to discern user flag on EF100 native datapath Ivan Malov
2021-09-03 0:15 ` [dpdk-dev] [PATCH v2 0/5] A means to negotiate support for Rx meta information Ivan Malov
2021-09-03 0:15 ` [dpdk-dev] [PATCH v2 1/5] ethdev: add API " Ivan Malov
2021-09-03 0:15 ` [dpdk-dev] [PATCH v2 2/5] net/sfc: provide API to negotiate supported Rx meta features Ivan Malov
2021-09-03 0:15 ` [dpdk-dev] [PATCH v2 3/5] net/sfc: allow to use EF100 native datapath Rx mark in flows Ivan Malov
2021-09-03 0:15 ` [dpdk-dev] [PATCH v2 4/5] common/sfc_efx/base: add RxQ flag to use Rx prefix user flag Ivan Malov
2021-09-03 0:15 ` [dpdk-dev] [PATCH v2 5/5] net/sfc: allow to discern user flag on EF100 native datapath Ivan Malov
2021-09-23 11:20 ` Ivan Malov [this message]
2021-09-23 11:20 ` [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data Ivan Malov
2021-09-30 14:59 ` Ori Kam
2021-09-30 15:07 ` Andrew Rybchenko
2021-09-30 19:07 ` Ivan Malov
2021-10-01 6:50 ` Andrew Rybchenko
2021-10-03 7:42 ` Ori Kam
2021-10-03 9:30 ` Ivan Malov
2021-10-03 11:01 ` Ori Kam
2021-10-03 17:30 ` Ivan Malov
2021-10-03 21:04 ` Ori Kam
2021-10-03 23:50 ` Ivan Malov
2021-10-04 6:56 ` Ori Kam
2021-10-04 11:39 ` Ivan Malov
2021-10-04 13:53 ` Andrew Rybchenko
2021-10-05 6:30 ` Ori Kam
2021-10-05 7:27 ` Andrew Rybchenko
2021-10-05 8:17 ` Ori Kam
2021-10-05 8:38 ` Andrew Rybchenko
2021-10-05 9:41 ` Ori Kam
2021-10-05 10:01 ` Andrew Rybchenko
2021-10-05 10:10 ` Ori Kam
2021-10-05 11:11 ` Andrew Rybchenko
2021-10-06 8:30 ` Thomas Monjalon
2021-10-06 8:38 ` Andrew Rybchenko
2021-10-06 9:14 ` Ori Kam
2021-09-30 21:48 ` Ajit Khaparde
2021-09-30 22:00 ` Ivan Malov
2021-09-30 22:12 ` Ajit Khaparde
2021-09-30 22:22 ` Ivan Malov
2021-10-03 7:05 ` Ori Kam
2021-09-23 11:20 ` [dpdk-dev] [PATCH v3 2/5] net/sfc: support " Ivan Malov
2021-09-23 11:20 ` [dpdk-dev] [PATCH v3 3/5] net/sfc: support flow mark delivery on EF100 native datapath Ivan Malov
2021-09-23 11:20 ` [dpdk-dev] [PATCH v3 4/5] common/sfc_efx/base: add RxQ flag to use Rx prefix user flag Ivan Malov
2021-09-23 11:20 ` [dpdk-dev] [PATCH v3 5/5] net/sfc: report user flag on EF100 native datapath Ivan Malov
2021-09-30 16:18 ` [dpdk-dev] [PATCH v3 0/5] A means to negotiate delivery of Rx meta data Thomas Monjalon
2021-09-30 19:30 ` Ivan Malov
2021-10-01 6:47 ` Andrew Rybchenko
2021-10-01 8:11 ` Thomas Monjalon
2021-10-01 8:54 ` Andrew Rybchenko
2021-10-01 9:32 ` Thomas Monjalon
2021-10-01 9:41 ` Andrew Rybchenko
2021-10-01 8:55 ` Ivan Malov
2021-10-01 9:48 ` Thomas Monjalon
2021-10-01 10:15 ` Andrew Rybchenko
2021-10-01 12:10 ` Thomas Monjalon
2021-10-04 9:17 ` Andrew Rybchenko
2021-10-04 23:50 ` [dpdk-dev] [PATCH v4 0/5] Negotiate the NIC's ability to deliver Rx metadata to the PMD Ivan Malov
2021-10-04 23:50 ` [dpdk-dev] [PATCH v4 1/5] ethdev: negotiate delivery of packet metadata from HW to PMD Ivan Malov
2021-10-05 12:03 ` Ori Kam
2021-10-05 12:50 ` Ivan Malov
2021-10-05 13:17 ` Andrew Rybchenko
2021-10-04 23:50 ` [dpdk-dev] [PATCH v4 2/5] net/sfc: support API to negotiate delivery of Rx metadata Ivan Malov
2021-10-04 23:50 ` [dpdk-dev] [PATCH v4 3/5] net/sfc: support flow mark delivery on EF100 native datapath Ivan Malov
2021-10-04 23:50 ` [dpdk-dev] [PATCH v4 4/5] common/sfc_efx/base: add RxQ flag to use Rx prefix user flag Ivan Malov
2021-10-04 23:50 ` [dpdk-dev] [PATCH v4 5/5] net/sfc: report user flag on EF100 native datapath Ivan Malov
2021-10-05 15:56 ` [dpdk-dev] [PATCH v5 0/5] ethdev: negotiate the NIC's ability to deliver Rx metadata to the PMD Ivan Malov
2021-10-05 15:56 ` [dpdk-dev] [PATCH v5 1/5] ethdev: negotiate delivery of packet metadata from HW to PMD Ivan Malov
2021-10-05 21:40 ` Ajit Khaparde
2021-10-06 6:04 ` Somnath Kotur
2021-10-06 6:10 ` Ori Kam
2021-10-06 7:22 ` Wisam Monther
2021-10-05 15:56 ` [dpdk-dev] [PATCH v5 2/5] net/sfc: support API to negotiate delivery of Rx metadata Ivan Malov
2021-10-05 15:56 ` [dpdk-dev] [PATCH v5 3/5] net/sfc: support flow mark delivery on EF100 native datapath Ivan Malov
2021-10-05 15:56 ` [dpdk-dev] [PATCH v5 4/5] common/sfc_efx/base: add RxQ flag to use Rx prefix user flag Ivan Malov
2021-10-05 15:56 ` [dpdk-dev] [PATCH v5 5/5] net/sfc: report user flag on EF100 native datapath Ivan Malov
2021-10-12 18:08 ` Ferruh Yigit
2021-10-12 19:39 ` Ivan Malov
2021-10-12 19:48 ` Ivan Malov
2021-10-12 19:38 ` [dpdk-dev] [PATCH v6 0/5] ethdev: negotiate the NIC's ability to deliver Rx metadata to the PMD Ivan Malov
2021-10-12 19:38 ` [dpdk-dev] [PATCH v6 1/5] ethdev: negotiate delivery of packet metadata from HW to PMD Ivan Malov
2021-10-12 19:38 ` [dpdk-dev] [PATCH v6 2/5] net/sfc: support API to negotiate delivery of Rx metadata Ivan Malov
2021-10-12 19:38 ` [dpdk-dev] [PATCH v6 3/5] net/sfc: support flow mark delivery on EF100 native datapath Ivan Malov
2021-10-12 19:38 ` [dpdk-dev] [PATCH v6 4/5] common/sfc_efx/base: add RxQ flag to use Rx prefix user flag Ivan Malov
2021-10-12 19:38 ` [dpdk-dev] [PATCH v6 5/5] net/sfc: report user flag on EF100 native datapath Ivan Malov
2021-10-12 19:46 ` [dpdk-dev] [PATCH v7 0/5] ethdev: negotiate the NIC's ability to deliver Rx metadata to the PMD Ivan Malov
2021-10-12 19:46 ` [dpdk-dev] [PATCH v7 1/5] ethdev: negotiate delivery of packet metadata from HW to PMD Ivan Malov
2021-10-12 19:46 ` [dpdk-dev] [PATCH v7 2/5] net/sfc: support API to negotiate delivery of Rx metadata Ivan Malov
2021-10-12 19:46 ` [dpdk-dev] [PATCH v7 3/5] net/sfc: support flow mark delivery on EF100 native datapath Ivan Malov
2021-10-12 19:46 ` [dpdk-dev] [PATCH v7 4/5] common/sfc_efx/base: add RxQ flag to use Rx prefix user flag Ivan Malov
2021-10-12 19:46 ` [dpdk-dev] [PATCH v7 5/5] net/sfc: report user flag on EF100 native datapath Ivan Malov
2021-10-12 23:25 ` [dpdk-dev] [PATCH v7 0/5] ethdev: negotiate the NIC's ability to deliver Rx metadata to the PMD Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210923112012.14595-1-ivan.malov@oktetlabs.ru \
--to=ivan.malov@oktetlabs.ru \
--cc=amoreton@xilinx.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).