From: jilei chen <chenjilei@cmss.chinamobile.com>
To: xiao.w.wang@intel.com
Cc: dev@dpdk.org, Jilei Chen <chenjilei@cmss.chinamobile.com>
Subject: [dpdk-dev] [PATCH] Enhance code readability when dma_map in ifc/ifcvp_vdpa
Date: Sun, 26 Sep 2021 23:57:57 +0800 [thread overview]
Message-ID: <20210926155757.7648-1-chenjilei@cmss.chinamobile.com> (raw)
From: Jilei Chen <chenjilei@cmss.chinamobile.com>
Signed-off-by: Jilei Chen <chenjilei@cmss.chinamobile.com>
---
drivers/net/ifc/ifcvf_vdpa.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ifc/ifcvf_vdpa.c b/drivers/net/ifc/ifcvf_vdpa.c
index da4667ba54..fe7ec87a8a 100644
--- a/drivers/net/ifc/ifcvf_vdpa.c
+++ b/drivers/net/ifc/ifcvf_vdpa.c
@@ -37,6 +37,8 @@
#define IFCVF_VDPA_MODE "vdpa"
#define IFCVF_SW_FALLBACK_LM "sw-live-migration"
+#define IFCVF_MAP 1
+#define IFCVF_UNMAP 0
static const char * const ifcvf_valid_arguments[] = {
IFCVF_VDPA_MODE,
@@ -535,7 +537,7 @@ update_datapath(struct ifcvf_internal *internal)
if (!rte_atomic32_read(&internal->running) &&
(rte_atomic32_read(&internal->started) &&
rte_atomic32_read(&internal->dev_attached))) {
- ret = ifcvf_dma_map(internal, 1);
+ ret = ifcvf_dma_map(internal, IFCVF_MAP);
if (ret)
goto err;
@@ -565,7 +567,7 @@ update_datapath(struct ifcvf_internal *internal)
if (ret)
goto err;
- ret = ifcvf_dma_map(internal, 0);
+ ret = ifcvf_dma_map(internal, IFCVF_UNMAP);
if (ret)
goto err;
@@ -869,7 +871,7 @@ ifcvf_sw_fallback_switchover(struct ifcvf_internal *internal)
unset_intr:
vdpa_disable_vfio_intr(internal);
unmap:
- ifcvf_dma_map(internal, 0);
+ ifcvf_dma_map(internal, IFCVF_UNMAP);
error:
return -1;
}
@@ -926,7 +928,7 @@ ifcvf_dev_close(int vid)
vdpa_disable_vfio_intr(internal);
/* unset DMA map for guest memory */
- ifcvf_dma_map(internal, 0);
+ ifcvf_dma_map(internal, IFCVF_UNMAP);
internal->sw_fallback_running = false;
} else {
--
2.12.2
next reply other threads:[~2021-09-26 20:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-26 15:57 jilei chen [this message]
2021-09-26 16:45 jilei chen
2021-09-27 2:09 ` Wang, Xiao W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210926155757.7648-1-chenjilei@cmss.chinamobile.com \
--to=chenjilei@cmss.chinamobile.com \
--cc=dev@dpdk.org \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).