From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A0C1A0548; Mon, 27 Sep 2021 13:21:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 030D040E3C; Mon, 27 Sep 2021 13:21:26 +0200 (CEST) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by mails.dpdk.org (Postfix) with ESMTP id 19D9E40686 for <dev@dpdk.org>; Mon, 27 Sep 2021 13:21:24 +0200 (CEST) Received: by mail-lf1-f53.google.com with SMTP id i4so75864499lfv.4 for <dev@dpdk.org>; Mon, 27 Sep 2021 04:21:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dqSWEj3AMdWpvavhVc12Oui0mT4Kbn1fDVDr/QbQqA0=; b=PxQU8DZzF0h+/sjJkWAygJqHBS1jMay4R8pLUjcq7HibS9aa65DF8gERr4caFRWdZY NqD6fWdPP31s0sgYh5Rpbj7gWPScXCzqTo6kddCSnMM72yhmVlp5Gr3GZhBCK9AdmzF3 tLrfzgQO8ayfQIDPSIt1/hDQ83lkVJdrjUsc+CpcDiM0hbyYBdgTcqIPeC3wxT3Ty6TP wqBcjYz+4S08uuRG1aEDra8yJDqj9QOecM++GCQ+G1i2CK0lOj20QBIMlyO31cszAcBk H16FtSF427M3o0qpX+F0CSRRkQVNM6GcaFtuLnRkBT1iwfDAbA/gFji1LuC5xMHctQMU 26zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dqSWEj3AMdWpvavhVc12Oui0mT4Kbn1fDVDr/QbQqA0=; b=xXrz9DTRUoKSd1KF28Pa3R0D9iNAo0U9qqZSBPbgPensdaCFHAJRVnNpO361lYekj2 iUJ1+A1jdXTlm3y5CPXIDd56NC0rI/G6LjTF0Py40IZ0oR55ak9YGT0onXeKlv6jRGru /IC0yOVPcsdv5SLSldSBAanxZ7Ec/vp9sxpylQwVVo+aEONXWvWz3fawYEZyAZRe0/QW hdIae7dIpLNd4HHcMpWGe26PIy3Uwv0NE3M04iFXpa3ckGt1xgLeCAxOrusd0BGurpvy tnyHETugFSMYgrHlYQS9N3u0BRJLdKTq5GoQFokOdY7dxKb3h2bD4py1zSg0bq8LieQX Jqdg== X-Gm-Message-State: AOAM530Iyz/sEOjihxgnPLa0cQqFqNmk7ADULM0qOwEm5C92FVXDSmVS jteEA10MczZZJV2LNPDru1k= X-Google-Smtp-Source: ABdhPJyEVmc2Bfl9aqbckHNUvAkFFQX0tBSv2NTYI45rNk8kclu1Qzs9b2MYzYcrrSFNuoT6+fq5Fg== X-Received: by 2002:a2e:9e53:: with SMTP id g19mr29120554ljk.478.1632741683537; Mon, 27 Sep 2021 04:21:23 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id u16sm672345lfo.160.2021.09.27.04.21.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 04:21:23 -0700 (PDT) Date: Mon, 27 Sep 2021 14:21:21 +0300 From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> To: Dmitry Kozlyuk <dkozlyuk@nvidia.com> Cc: <dev@dpdk.org>, Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>, "Thomas Monjalon" <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@intel.com>, "Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru> Message-ID: <20210927142121.7cafde58@sovereign> In-Reply-To: <20210901085516.3647814-3-dkozlyuk@nvidia.com> References: <20210901085516.3647814-1-dkozlyuk@nvidia.com> <20210901085516.3647814-3-dkozlyuk@nvidia.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC PATCH 2/2] ethdev: add capability to keep indirect actions on restart X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 2021-09-01 11:55 (UTC+0300), Dmitry Kozlyuk: > rte_flow_action_handle_create() did not mention what happens > with an indirect action when a device is stopped, possibly reconfigured, > and started again. It is natural for some indirect actions to be > persistent, like counters and meters; keeping others just saves > application time and complexity. However, not all PMDs can support it. > It is proposed to add a device capability to indicate if indirect actions > are kept across the above sequence or implicitly destroyed. > > It may happen that in the future a PMD acquires support for a type of > indirect actions that it cannot keep across a restart. It is undesirable > to stop advertising the capability so that applications that don't use > actions of the problematic type can still take advantage of it. > This is why PMDs are allowed to keep only a subset of indirect actions > provided that the vendor mandatorily documents it. > > If the device is being reconfigured in a way that is incompatible with > an existing indirect action, PMD is required to report an error. > This is mandatory, because flow API does not supply users with > capabilities, so this is the only way for a user to learn that > configuration is invalid. For example, if queue count changes and RSS > indirect action specifies queues that are going away, the user must > update the action before removing the queues or remove the action and > all flow rules that were using it. > > Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com> > Acked-by: Matan Azrad <matan@nvidia.com> > Acked-by: Ori Kam <orika@nvidia.com> > --- > doc/guides/prog_guide/rte_flow.rst | 12 ++++++++++++ > lib/ethdev/rte_ethdev.h | 5 +++++ > 2 files changed, 17 insertions(+) > > [...] Hello, any opinions? Just noticed that I forgot to Cc everyone in the cover letter with context: http://inbox.dpdk.org/dev/20210901085516.3647814-1-dkozlyuk@nvidia.com/