From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 37DD7A0032;
Wed, 29 Sep 2021 23:40:27 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 533804111F;
Wed, 29 Sep 2021 23:40:12 +0200 (CEST)
Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com
[209.85.221.51]) by mails.dpdk.org (Postfix) with ESMTP id AFACC410F2
for <dev@dpdk.org>; Wed, 29 Sep 2021 23:40:06 +0200 (CEST)
Received: by mail-wr1-f51.google.com with SMTP id d6so6509189wrc.11
for <dev@dpdk.org>; Wed, 29 Sep 2021 14:40:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google;
h=from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=yh0oVJn13XE2wUoqp8T0trW+xdSBLudc5er4oxGWPjc=;
b=G3jHG5Ukqm7JN6JomANp6DcIWN6Ka8KX2G7bVNwl7sxv4Lz11lHUFo4Ya4zchHRID2
5qd75HtrLurrnq7TeX6XjjSngWt1yi9M+FRTT3qYqwkcpPXYOR//34KbF1AS+YuU1fqQ
1/9ZLNgl7Ohskb71ZcbeAoiIusU0s/wqg1jcnChNnKUPEKZj/rWSVwyuztj0yWO7zZMR
OTei8qcCVjflEzHG2QmZmJIiKlOzkaUfp9n/VqigVz8lyNffGafC242UG3dkbbY80Ev5
B6udnSUyQpmHPDVh4e8vnF2m/Zg3xzLF4g9UZvr+h17Gw/1iPvt2maSv+kuBwVzFLAhN
n2IA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=yh0oVJn13XE2wUoqp8T0trW+xdSBLudc5er4oxGWPjc=;
b=mMBAgSaRW7Vu98tLkkrWGNfQMP953uY5kscy2E8qckk5iG/volJjoC/AyGUATOy9sB
g2zozlX4D4L0+ZxrAHJq8JAHk5aoisBbgNCiCv8QCQ5U9hJx9I1I4iwHOR3Ab8h4PqRe
lhkbf7wn4eYFaGIeiHv0Q0zc701mk+z2blqPXhrSLMlugtsPN+y+DlcLFlda+jAbpSng
hhiAtJaKjPbuJBYnvst65C+/TuBlncmUFgWx8YAND2S3f9j2b8ggCa8XHEdoC0sT/06k
vuS3QVgCzC1H6QtI4jzCwHWeD6d1pmnYFcDuys2qaNrkcdtnuL/BgfDI0V+qxUHV9G+U
6fwg==
X-Gm-Message-State: AOAM531FG0zeR9p3Pt1HYXE6MHlsOAli3FZUi3UciHU7KYl2LU8rrp0J
eO9j9nPye7jsnNhK+FtcvXJkOLe8w6w0Uw==
X-Google-Smtp-Source: ABdhPJyLMUgXjjxs9eFjVbqJ+jXKyjSOeIOL3utf71ORfuNW05kgZrmdMzBebpP2QJdvrclVxZzqvQ==
X-Received: by 2002:a05:6000:2c6:: with SMTP id
o6mr2504655wry.292.1632951606494;
Wed, 29 Sep 2021 14:40:06 -0700 (PDT)
Received: from gojira.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com.
[62.23.145.78])
by smtp.gmail.com with ESMTPSA id o19sm1079743wrg.60.2021.09.29.14.40.05
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 29 Sep 2021 14:40:06 -0700 (PDT)
From: Olivier Matz <olivier.matz@6wind.com>
To: dev@dpdk.org
Cc: Olivier Matz <olivier.matz@6wind.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Xueming Li <xuemingl@nvidia.com>, Gaetan Rivet <grive@u256.net>,
Ray Kinsella <mdr@ashroe.eu>
Date: Wed, 29 Sep 2021 23:39:42 +0200
Message-Id: <20210929213943.17817-5-olivier.matz@6wind.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20210929213943.17817-1-olivier.matz@6wind.com>
References: <20210924155740.20510-1-olivier.matz@6wind.com>
<20210929213943.17817-1-olivier.matz@6wind.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH v2 4/5] kvargs: remove experimental function to
compare string
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
The function was designed to be used as a handler for
rte_kvargs_process() to compare the value string in a kvlist. For
readability, its usages in DPDK have been replaced by
rte_kvargs_get_with_value() in previous commit.
Remove this function, as it is not used anymore.
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Reviewed-by: Xueming Li <xuemingl@nvidia.com>
---
lib/kvargs/rte_kvargs.c | 9 ---------
lib/kvargs/rte_kvargs.h | 26 --------------------------
lib/kvargs/version.map | 2 --
3 files changed, 37 deletions(-)
diff --git a/lib/kvargs/rte_kvargs.c b/lib/kvargs/rte_kvargs.c
index 20abb23183..11f624ef14 100644
--- a/lib/kvargs/rte_kvargs.c
+++ b/lib/kvargs/rte_kvargs.c
@@ -283,12 +283,3 @@ rte_kvargs_parse_delim(const char *args, const char * const valid_keys[],
free(copy);
return kvlist;
}
-
-int
-rte_kvargs_strcmp(const char *key __rte_unused,
- const char *value, void *opaque)
-{
- const char *str = opaque;
-
- return -abs(strcmp(str, value));
-}
diff --git a/lib/kvargs/rte_kvargs.h b/lib/kvargs/rte_kvargs.h
index e40df1bd2a..3c1754c3d9 100644
--- a/lib/kvargs/rte_kvargs.h
+++ b/lib/kvargs/rte_kvargs.h
@@ -197,32 +197,6 @@ int rte_kvargs_process(const struct rte_kvargs *kvlist,
unsigned rte_kvargs_count(const struct rte_kvargs *kvlist,
const char *key_match);
-/**
- * Generic kvarg handler for string comparison.
- *
- * This function can be used for a generic string comparison processing
- * on a list of kvargs.
- *
- * @param key
- * kvarg pair key.
- *
- * @param value
- * kvarg pair value.
- *
- * @param opaque
- * Opaque pointer to a string.
- *
- * @return
- * 0 if the strings match.
- * !0 otherwise or on error.
- *
- * Unlike strcmp, comparison ordering is not kept.
- * In order for rte_kvargs_process to stop processing on match error,
- * a negative value is returned even if strcmp had returned a positive one.
- */
-__rte_experimental
-int rte_kvargs_strcmp(const char *key, const char *value, void *opaque);
-
#ifdef __cplusplus
}
#endif
diff --git a/lib/kvargs/version.map b/lib/kvargs/version.map
index 82879b7140..0d42cd58a8 100644
--- a/lib/kvargs/version.map
+++ b/lib/kvargs/version.map
@@ -14,8 +14,6 @@ DPDK_22 {
EXPERIMENTAL {
global:
- rte_kvargs_strcmp;
-
# added in 21.11
rte_kvargs_get_with_value;
};
--
2.30.2