From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A784DA0032; Fri, 1 Oct 2021 11:51:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 258F74067A; Fri, 1 Oct 2021 11:51:20 +0200 (CEST) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by mails.dpdk.org (Postfix) with ESMTP id A3EF440040 for ; Fri, 1 Oct 2021 11:51:18 +0200 (CEST) Received: by mail-lf1-f53.google.com with SMTP id i19so33300333lfu.0 for ; Fri, 01 Oct 2021 02:51:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EXPpNFwcKjBXPd+KLe9lCdP43OMXgo0pKVQp7jaN8cs=; b=Ipe1fn81IQwdLrzgvP/7axVL72TxL5H+OcezziGEORqZHaTaTo364SHXgZGSxqaE+u cdBk7nuY8fdCW6R3zcjpkWVUMHULwlW4TVlOHYksy4RbJDs/AeG2e1KXNEFZqT+I3xy6 19kDd4KUeGVQNg5yO6YouAWqBXGt6DRMPaoO5DL/sy6gKJ7pG22e5QCKrzaUjW9f6EJV jNBUkRzJyE77Dg8ZVixzJ6ydhv/046rUGq2nKgOF6rImicxR42SZC8j1qBtwjNKeViY2 nry6ki7b9O0M7mk69OcqTfPU1LB8vMn/B2QUls8v7q+z5eNbSp0D1ip8M/2e2gybgph2 mWDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EXPpNFwcKjBXPd+KLe9lCdP43OMXgo0pKVQp7jaN8cs=; b=PnKG9mepmclmK/BF1XeLwfE6IwT1kabIvxJH/6MJaYKL7WJ+s/1P7lKL+LMOffNy8j gT482GbNMtmu/lXPPZHqE0woS0hSyGVM9Oxx7dgk4VN4JHV0WEufJQFqeLvKAaP6B+Li rlVIL8jEbq9sFtEmuao7eZIhgcqgScyJl9TRNilzKKDj7u0EqiQV6OiTSp8zyENIluU4 OmA5uD31jWPmz3LszOMxG6HADpO/7KxcyOwTjRTMlmpnZn8B2ZaCQNKBmDFspSe3lJsz xJq49A7+rhakTHtDku9U++pxU/texm+6+oV7gRhFLJseKWz0GENnXzpZzwBbEIEQx6Eo DKig== X-Gm-Message-State: AOAM5315n8LYwAI8VbZ9gqc8d4sbafqLhxzpnvo4X3Aq9E6Ue3HchVqx mxFHyMpqxFQ8/ESskWWlkAs= X-Google-Smtp-Source: ABdhPJwGNKJExI+DPVfFZHcOlbyjR6B+w5rRDJW09W6p8YAp+4/tu08b3ZCOS35r7swVjfat6svLpA== X-Received: by 2002:a05:6512:78:: with SMTP id i24mr4370066lfo.595.1633081878159; Fri, 01 Oct 2021 02:51:18 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id j8sm678734lfg.183.2021.10.01.02.51.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Oct 2021 02:51:17 -0700 (PDT) Date: Fri, 1 Oct 2021 12:51:17 +0300 From: Dmitry Kozlyuk To: David Marchand Cc: William Tu , Narcisa Ana Maria Vasile , Thomas Monjalon , dpdk-dev , Nick Connolly , Omar Cardona , Pallavi Kadam Message-ID: <20211001125117.28f546b2@sovereign> In-Reply-To: <20211001123605.00fa6402@sovereign> References: <20210823130343.87247-1-u9012063@gmail.com> <20210824162103.32783-1-u9012063@gmail.com> <20210920201111.GA7448@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20211001123605.00fa6402@sovereign> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v9] eal: remove sys/queue.h from public headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-10-01 12:36 (UTC+0300), Dmitry Kozlyuk: > 2021-10-01 09:27 (UTC+0200), David Marchand: > > [...] > > I just have a concern that headers get broken again if we have no check. > > Could buildtools/chkincs do the job (if we make this check work on Windows)? > > It's a valid caoncern and yes, chkincs would be a solution. > > I discovered that the real issue with chkincs was a space after shebang in > gen_c_file_for_header.py. If it is removed, find_program() is able to parse > the line and call the script with Python interpreter. However, spaces > *are* allowed after shebangs. Would you like me to submit a patch with a fix > just chkincs or shall I *instead* work with meson developers (I'll do that > anyway)? I'm asking because we have other files with extra spaces, so there's > a question if we should fix them, add a rule for the space, etc. Just re-checked with meson 0.57.0 (as recommended in Windows GSG) and hit no issue even with a space after "#!". Maybe it was a meson 0.47 issue on Windows at the time you disabled chkins there?