From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B97B3A0032; Fri, 1 Oct 2021 21:03:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 38F6141194; Fri, 1 Oct 2021 21:03:03 +0200 (CEST) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by mails.dpdk.org (Postfix) with ESMTP id 4237241183 for ; Fri, 1 Oct 2021 21:03:02 +0200 (CEST) Received: by mail-lf1-f45.google.com with SMTP id x27so42016417lfa.9 for ; Fri, 01 Oct 2021 12:03:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6QwUy9LgruB0XC+fF4LogTQVS+7oauBNvH0v9fh4YLk=; b=Cbaa6dMIjp8TRUMULONUNXbt5Lw6KkSXfcoQUmvEnpTH0aElGTtKIaGb9iNgBUv0LK uvGTfB5GJ1cbEjl3sxyLDiEeYhUguqmN9TJlxVCDcSakzgyvGBdLBQZnO3ejX9kcyPhU rJ3egaafKT84hhzk5hGYE5qBjktr93pMIr3ch3fje6NSXMROVKjS9Mnnmz7gmqlHebpe anRcdEDPRqrIx5rJYwUhsy+g9rlCFTh3JMYTF++mLCiKV6reB8HgOPlm1Jz/ZAqMnV93 0DWwAAuUFQ4qIng1ZG7+XWYVk8XhOT949pwDhvpMhE0mk7EfVLRdzyEW+rTwL9+XYP+Q XAag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6QwUy9LgruB0XC+fF4LogTQVS+7oauBNvH0v9fh4YLk=; b=wNGzmpTmZyjj0+YPyDsibW/Chr1bccYfd7Djn8DSB7pwI1esLvqginZW/L6IFz8IxC Mv5P3RK4avvGcekvVH3QGVJcFV/oIFi8+G9SSA3P26BcI7+gr+vQmhJCjpiF6qwWZ++K zzYEutecfIHakxxftOEJMgttdUtOfNxtePnX+X6rhV8J+PoXvjhkmeLxINYjCKyAvSsy ogVyH4AepqHDp6P8BUmwEN5bbJB8zidVB1/OhlxR8yQsOCDW2MLpaUYzbODWOPNCKuaI VaAdzX3JgLs3BpyO17w8w2HB4HbSDE1J8X0q7cvbIwh3mlEJpZ7kKww2ARlObaEMQ4vf ZfVQ== X-Gm-Message-State: AOAM532BpT9hfzQW7ay021busOec6J60xmAwGmoIFDShjkxkRRsio8DP VIRPjLD8W33pyuaVr+/dYuU= X-Google-Smtp-Source: ABdhPJxg3xjL0sZtUYvGIpTGBf/dCgH74/U+0ByTd0B4NN9mJYECXY8zcD7dMSCq3N9t6CDfTrjkXQ== X-Received: by 2002:a05:6512:c18:: with SMTP id z24mr3051965lfu.62.1633114981738; Fri, 01 Oct 2021 12:03:01 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id n9sm819327lfu.88.2021.10.01.12.03.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Oct 2021 12:03:01 -0700 (PDT) Date: Fri, 1 Oct 2021 22:03:00 +0300 From: Dmitry Kozlyuk To: William Tu Cc: dev@dpdk.org, pallavi.kadam@intel.com, talshn@nvidia.com Message-ID: <20211001220300.0a113830@sovereign> In-Reply-To: <20211002003344.594-5-u9012063@gmail.com> References: <20211002003344.594-1-u9012063@gmail.com> <20211002003344.594-5-u9012063@gmail.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v3 4/4] net/ixgbe: Add support for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi William, Recommended title: "net/ixgbe: build on Windows". 2021-10-01 17:33 (UTC-0700), William Tu: > This patch enables building the ixgbe driver for Windows. > It also enables its dependencies on security and cryptodev. > I tested on AWS using ixgbe VF device, using dpdk-testpmd. >=20 > Signed-off-by: William Tu I'm getting this error when building with MinGW: ../drivers/net/ixgbe/ixgbe_ethdev.c:6416:29: error: =E2=80=98IPPROTO_SCTP= =E2=80=99 undeclared (first use in this function); did you mean =E2=80=98IPPROTO_TCP= =E2=80=99? Can be fixed by defining IPPROTO_SCTP in e.g. ixgbe_osdep.h if not defined. Note that rte_os_shim.h cannot be used even in ixgbe_ethdev.c, because it defines `read()` macro, which causes another error: ../drivers/net/ixgbe/ixgbe_ethdev.c:4097:37: error: macro "read" passed 4 arguments, but takes just 3 4097 | if (mbx->ops.read(hw, &in_msg, 1, 0)) > [...] > diff --git a/drivers/net/ixgbe/base/meson.build b/drivers/net/ixgbe/base/= meson.build > index 22972c6b56..51a58a3183 100644 > --- a/drivers/net/ixgbe/base/meson.build > +++ b/drivers/net/ixgbe/base/meson.build > @@ -28,7 +28,14 @@ foreach flag: error_cflags > endif > endforeach > =20 > +inc =3D [] > +inc +=3D include_directories('../../../../lib/net') > +inc +=3D include_directories('../../../../lib/mbuf') > +inc +=3D include_directories('../../../../lib/mempool') > +inc +=3D include_directories('../../../../lib/ring') > + > base_lib =3D static_library('ixgbe_base', sources, > dependencies: static_rte_eal, > + include_directories: inc, > c_args: c_args) > base_objs =3D base_lib.extract_all_objects(recursive: true) Looks messy, you could just do this: dependencies: [static_rte_eal, static_rte_net] This works because all drivers/net have a standard dependency on lib/ethdev, which pulls lib/net in its turn.