From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52C40A0C4D; Mon, 4 Oct 2021 21:34:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 405FB40698; Mon, 4 Oct 2021 21:34:29 +0200 (CEST) Received: from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8]) by mails.dpdk.org (Postfix) with ESMTP id C7C924068F for ; Mon, 4 Oct 2021 21:34:27 +0200 (CEST) Received: from localhost (scalar.blr.asicdesigners.com [10.193.185.94]) by stargate.chelsio.com (8.14.7/8.14.7) with ESMTP id 194JYPeM019995; Mon, 4 Oct 2021 12:34:26 -0700 Date: Tue, 5 Oct 2021 01:02:06 +0530 From: Rahul Lakkireddy To: Ferruh Yigit Cc: dev@dpdk.org Message-ID: <20211004193205.GA17631@chelsio.com> References: <20211004172754.3461732-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211004172754.3461732-1-ferruh.yigit@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH] net/cxgbe: remove useless address check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Monday, October 10/04/21, 2021 at 18:27:54 +0100, Ferruh Yigit wrote: > reported by "gcc (GCC) 12.0.0 20211003 (experimental)": > > ../drivers/net/cxgbe/cxgbe_ethdev.c: > In function ‘cxgbe_dev_rx_queue_setup’: > ../drivers/net/cxgbe/cxgbe_ethdev.c:682:24: > error: the comparison will always evaluate as ‘true’ for the > address of ‘fl’ will never be NULL [-Werror=address] > 682 | if ((&rxq->fl) != NULL) > | ^~ > > Fixing it by removing useless check. > > Signed-off-by: Ferruh Yigit Looks good. Thanks for fixing it up. Reviewed-by: Rahul Lakkireddy