From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBE09A0C45; Tue, 5 Oct 2021 22:42:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9867540685; Tue, 5 Oct 2021 22:42:18 +0200 (CEST) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id A75444014F for ; Tue, 5 Oct 2021 22:42:17 +0200 (CEST) Received: by mail-pl1-f182.google.com with SMTP id j15so275743plh.7 for ; Tue, 05 Oct 2021 13:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JXlTuJqN07RQl/f30JxDBm9Eq3WtBdKcpl33Z7fcpVs=; b=uxcl5wplYW7wEhTSGDkMEU6mQCRZRFVBuHtIMTAm0vAEW8snQfiZAtIBD5e6MbzfQp +yLR5Z2TppO5/ZBZ87iVjDhvylulMWceF5I8qhaaufCYCFhRByV3gDkTMgueM3+SOl+t cNd2xlhUdA8ZT1nZKthgm3cXigWcg3nWahMeqJjLh5yUzBoZyItTmp7IMXSCgWejD5Mg pW4nmdryItcEGkE0loRBtyIhfQKoEeTr3HgxuiTHvzGP4PyjY7/dSZ5oANaFVF3rYc4Y HuXLnN1irsKmo5AnAUrj6IChPZAVb04w58wBK91uUKzgPiEEJNIkj96NJWCaACsNfEVj mu/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JXlTuJqN07RQl/f30JxDBm9Eq3WtBdKcpl33Z7fcpVs=; b=bDVwTdjXGWe/xB7Z60Ndvqff/s5ZutugAyKHjwNqTAMIcHT4ABAsHdu2JPKY0Q40aI qbsEG3tLSyGz4XD4QLCFg5ou/y1gdSc/wB0GfLPEkEw+liFaeh9ohgFLXMMeUBbf713m Lohv1r/Rpw7MWAwxw1uIdwYZp/CQvQFK8LQnoO9XVNxvDwiBQwzalzz9P78BHdLkiLC5 g/ZOfsDZdbJyqyeJ8EifjALeyO0gsns7paF1Ap+GnXP08HRKlZwZCyE42x+su7axoifX jEYgStjfNkbeyVk14kZtjVpi9oGvbdJj7h+1FUOGJMCp3jLx+mCNtJSpOqgrJRHy6G8Z f1UA== X-Gm-Message-State: AOAM533orW8la3rMm5qAGtxDQk8/VGWIdYin49ruha3zhHV7lOL6HaSd 5bUn/bn3VdtFNMQwhwRV+dqwPw== X-Google-Smtp-Source: ABdhPJwEQWV9DC+EyCeaw0NAlLyc31we8VhyyCvWjm6RhIqN9Yr2LJMNZX42m8YJ4lLuiIfqBxjBGQ== X-Received: by 2002:a17:902:7e4b:b0:13d:b90d:cdc1 with SMTP id a11-20020a1709027e4b00b0013db90dcdc1mr7348628pln.72.1633466536737; Tue, 05 Oct 2021 13:42:16 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id h24sm19274089pfn.180.2021.10.05.13.42.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 13:42:16 -0700 (PDT) Date: Tue, 5 Oct 2021 13:42:13 -0700 From: Stephen Hemminger To: Dmitry Kozlyuk Cc: dev@dpdk.org, Ali Alnubani , Gregory Etelson , David Marchand , Olivier Matz , Ray Kinsella Message-ID: <20211005134213.3ed96d4f@hermes.local> In-Reply-To: <20211005201545.179902-3-dmitry.kozliuk@gmail.com> References: <20211005005516.132377-1-dmitry.kozliuk@gmail.com> <20211005201545.179902-1-dmitry.kozliuk@gmail.com> <20211005201545.179902-3-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 2/2] cmdline: make struct rdline opaque X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 5 Oct 2021 23:15:45 +0300 Dmitry Kozlyuk wrote: > +++ b/app/test/test_cmdline_lib.c > @@ -83,18 +83,19 @@ test_cmdline_parse_fns(void) > static int > test_cmdline_rdline_fns(void) > { > - struct rdline rdl; > + struct rdline *rdl = NULL; Very minor nit. The variable does not need to be initialized since first statement assigns the value.