DPDK patches and discussions
 help / color / mirror / Atom feed
From: William Tu <u9012063@gmail.com>
To: dev@dpdk.org
Cc: navasile@microsoft.com, pallavi.kadam@intel.com,
	dmitry.kozliuk@gmail.com
Subject: [dpdk-dev] [PATCH v1] windows/netuio: fix pci resouce translation
Date: Thu,  7 Oct 2021 17:22:43 -0700	[thread overview]
Message-ID: <20211008002243.88955-1-u9012063@gmail.com> (raw)

When BAR array is filled like this
    * Bar[4] = c844000c <if this one is not the CM_RESOURCE_MEMORY_BAR>
    * Bar[5] = null
ex:
while ((descriptor->Type != CmResourceTypeMemory) ||
                 !(descriptor->Flags & CM_RESOURCE_MEMORY_BAR));
returns true, the loop continue and the decriptor will be NULL,
but it's not an error. So I fix it by setting the status to STATUS_SUCCESS.

Signed-off-by: William Tu <u9012063@gmail.com>
---
Found the issue when adding the e1000 PMD support.
http://inbox.dpdk.org/dev/20211007202451.90271-1-u9012063@gmail.com/T/#u
---
 windows/netuio/netuio_dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/windows/netuio/netuio_dev.c b/windows/netuio/netuio_dev.c
index b2deb10..0dd0055 100644
--- a/windows/netuio/netuio_dev.c
+++ b/windows/netuio/netuio_dev.c
@@ -207,7 +207,7 @@ netuio_map_hw_resources(WDFDEVICE Device, WDFCMRESLIST Resources, WDFCMRESLIST R
             next_descriptor++;
 
             if (descriptor == NULL) {
-                status = STATUS_DEVICE_CONFIGURATION_ERROR;
+                status = STATUS_SUCCESS;
                 goto end;
             }
         } while ((descriptor->Type != CmResourceTypeMemory) ||
-- 
2.31.1


             reply	other threads:[~2021-10-08  0:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-08  0:22 William Tu [this message]
2021-10-08 12:39 ` William Tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211008002243.88955-1-u9012063@gmail.com \
    --to=u9012063@gmail.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=navasile@microsoft.com \
    --cc=pallavi.kadam@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).