DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: "Kadam, Pallavi" <pallavi.kadam@intel.com>
Cc: <dev@dpdk.org>, William Tu <u9012063@gmail.com>,
	Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
	Dmitry Malloy <dmitrym@microsoft.com>
Subject: Re: [dpdk-dev] [PATCH] doc/windows_gsg: update section on driver installation
Date: Sat, 9 Oct 2021 23:20:16 +0300	[thread overview]
Message-ID: <20211009232016.49f62460@sovereign> (raw)
In-Reply-To: <7d8f6e0f-5a5a-54c8-22aa-151493dcd316@intel.com>

2021-10-09 12:38 (UTC-0700), Kadam, Pallavi:
> On 10/8/2021 2:11 PM, Dmitry Kozlyuk wrote:
> > [...]
> > +virt2phys
> > +~~~~~~~~~
> >   
> > -1. From Device Manager, Action menu, select "Add legacy hardware".
> > -2. It will launch the "Add Hardware Wizard". Click "Next".
> > -3. Select second option "Install the hardware that I manually select
> > -   from a list (Advanced)".
> > -4. On the next screen, "Kernel bypass" will be shown as a device class.
> > -5. Select it, and click "Next".
> > -6. The previously installed drivers will now be installed for the
> > -   "Virtual to physical address translator" device.
> > +Access to physical addresses is provided by a kernel-mode driver, virt2phys.
> > +It is mandatory for allocating physically-contiguous memory which is required
> > +by hardware PMDs.  
> 
> Should we add specific link to virt2phys README in this section as well?
> 
> https://git.dpdk.org/dpdk-kmods/tree/windows/README.rst

This link is given above and I consider it general information for all
drivers. However, reading it carefully, I think docs in dpdk-kmods could be
restructured as well:
* Keep windows/README.rst unchanged, except for Device Manager steps,
  which are actually specific to virt2phys.
* Create windows/virt2phys/README.rst with instructions above.
* Change windows/netuio/README.rst: remove the bulk of its content, as it
  repeats generic instructions, keep netuio-specific Device Manager part.
Then a specific link for virt2phys here would make sense
and there will be even less duplication in dpdk-kmods.
If no one objects, I'll do this in v2.
Thanks!

  reply	other threads:[~2021-10-09 20:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-08 21:11 Dmitry Kozlyuk
2021-10-09 19:38 ` Kadam, Pallavi
2021-10-09 20:20   ` Dmitry Kozlyuk [this message]
2021-10-10  1:28     ` William Tu
2021-10-11 16:33     ` Kadam, Pallavi
2021-10-11 19:15 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211009232016.49f62460@sovereign \
    --to=dmitry.kozliuk@gmail.com \
    --cc=dev@dpdk.org \
    --cc=dmitrym@microsoft.com \
    --cc=navasile@linux.microsoft.com \
    --cc=pallavi.kadam@intel.com \
    --cc=u9012063@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).