From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E700AA034F; Tue, 12 Oct 2021 04:32:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9BC4040E50; Tue, 12 Oct 2021 04:32:01 +0200 (CEST) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id 40A0840150 for ; Tue, 12 Oct 2021 04:32:01 +0200 (CEST) Received: by mail-pj1-f51.google.com with SMTP id ns7-20020a17090b250700b001a0937b87b7so949587pjb.1 for ; Mon, 11 Oct 2021 19:32:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+EXffM6dl6dfiUN1waPQPvSFl+IyZsfN7T1/lGTxfgA=; b=Qqp0+y2EZQAQnjadBtWvOXepU9IeWJOYV3soo3l32EGj1ObGI1eLGYbXUF8FxE1OUV 6qZW5kcyUA9pIq180tscXCzwHQvuUgRAP1LtYMNCa4J2Njw0sHUQtTLJ41tFGRyle6Bn 673gYJ2R6ziEpFzFzhzBuPNUrIoE6HTTQDUq0MP6AEWeCDhksrprpK4skTrNYDIR3ceo 40ZA5TWVA+qXzeXH7dWaVcl8ru7KwA6qb+v734jofSIi+kMJUA2Xnfg0VBmAFNgcixL9 Xy+/q8P3lzAqVMXWXMVkHXbFbibNZ0Fa8nmgyuS5zNPLHPK21HE7OpAn0N3pEZNSI1Hl 1bDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+EXffM6dl6dfiUN1waPQPvSFl+IyZsfN7T1/lGTxfgA=; b=l9lW6zbvp8ROPq1jZaVKrxuwzZ3HDZOQzHIMRph69kRn6xGPVpcHI/TJ6vpWObcpjU vIForVdvtOxvL9/MMqypcHLwYosncPvcfI9UI2Mp65xqGIk9gpeMBVQ9Un1hUJXC1j8r JJ8hMnWOp8WdjsxGNiuNOO9XHNTeM8j2iX3re6sHf46GtTV3NhC5gB3TpDoiyYFbTWjT qIS7tVTkHtRmXzWYcOEzrAalACKqbqUhAXRC+TJHXTslMscBBgC4qG68JIl8F0jgjHEa znSRKX9jjmh1YjDssj/eerv97In3F6Jvzn9YLojY4Yat9KDGaKLcJGBa5guN6Pb+JUSM IMXw== X-Gm-Message-State: AOAM530lWFpptR4rxPmRQ83Kbd4fyxbZRehb3apBxqamsMVoAkf9oudJ SPErdQjyupfdhzpbQnMvbm12hDgcSifzKw== X-Google-Smtp-Source: ABdhPJwN+R6NB/Tgl3T1GgQwtkfKZ+I5qa5xi47/dUy7kHfWaYpoKEdk/1UYJVyzKijszo3JAFwwNw== X-Received: by 2002:a17:90a:307:: with SMTP id 7mr3029143pje.176.1634005920167; Mon, 11 Oct 2021 19:32:00 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id h6sm740688pji.6.2021.10.11.19.31.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Oct 2021 19:31:59 -0700 (PDT) Date: Mon, 11 Oct 2021 19:31:56 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: dev@dpdk.org Message-ID: <20211011193156.6d3ea245@hermes.local> In-Reply-To: <20211001162705.442298-1-stephen@networkplumber.org> References: <20210903004732.109023-1-stephen@networkplumber.org> <20211001162705.442298-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v12 00/12] Packet capture framework update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 1 Oct 2021 09:26:53 -0700 Stephen Hemminger wrote: > This patch set is a more complete version of the the enhanced > packet capture support described last year. > > The new capture library and utility are: > - faster avoids lots of extra I/O, does bursting, etc. > - gives more information (multiple ports, queues, etc) > - has a better user interface (same as Wireshark dumpcap) > - fixes structural problems with VLAN's and timestamps > > There are no blocker items. > The following are worth noting: > * bogus checkpatch warnings > - the correct flag to open is O_CREAT > - intentionally keeping macro with goto since that > was in original code and is clearer > - the tempfile name can not be const since it is > overwritten by tmpfile() call > > * enabling BPF tests causes CI to see a pre-existing bug > https://bugs.dpdk.org/show_bug.cgi?id=811 > > * future filtering for stripped VLAN tags needs collabration > with libpcap project to fix pcap_compile_filter(). > > v12 > - fixes for capture offloaded VLAN tags. > look at direction flag and handle QinQ offload. > > v11 > - address review comments for pdump (patch 6) > > v10: > - fix to rte_bpf_dump to handle more instructions > make sure all bpf_test cases are decoded > > v9: > - incorporate suggested change to BPF XOR > - make autotest for pcapng more complete by reading the > resulting file with libpcap > > v8: > - enable BPF tests in autotest > - add more BPF test strings > - use rte_strscpy to satisfy checkpatch > - merge MAINTAINERS (put this in with existing pdump) > > v7: > - add functional tests for pcapng lib > - bug fix for error returns in pcapng lib > - handle long osname on FreeBSD > - resolve almost all checkpatch issues > > v5: > - minor build and checkpatch fixes for RHEL/FreeBSD > - disable lib/pdump on Windows. It was not useful before > and now pdump depends on bpf. > > v4: > - minor checkpatch fixes. > Note: some of the checkpatch warnings are bogus and won't be fixed. > - fix build of dumpcap on FreeBSD > > v3: > - introduce packet filters using classic BPF to eBPF converter > required small fix to DPDK BPF interpreter > - introduce function to decode eBPF instructions > - add option to dumpcap to show both classic BPF and eBPF result > - drop some un-useful stubs > - minor checkpatch warning cleanup > > v2: > fix formatting of packet blocks > fix the new packet capture statistics > fix crash when primary process exits > record start/end time > various whitespace/checkpatch warnings > > > > Stephen Hemminger (12): > lib: pdump is not supported on Windows > librte_pcapng: add new library for writing pcapng files > bpf: allow self-xor operation > bpf: add function to convert classic BPF to DPDK BPF > bpf: add function to dump eBPF instructions > pdump: support pcapng and filtering > app/dumpcap: add new packet capture application > test: add test for bpf_convert > test: add a test for pcapng library > test: enable bpf autotest > doc: changes for new pcapng and dumpcap > MAINTAINERS: add entry for new packet capture features > > MAINTAINERS | 11 +- > app/dumpcap/main.c | 844 ++++++++++++++++++ > app/dumpcap/meson.build | 16 + > app/meson.build | 1 + > app/test/meson.build | 6 + > app/test/test_bpf.c | 200 +++++ > app/test/test_pcapng.c | 272 ++++++ > doc/api/doxy-api-index.md | 1 + > doc/api/doxy-api.conf.in | 1 + > .../howto/img/packet_capture_framework.svg | 96 +- > doc/guides/howto/packet_capture_framework.rst | 67 +- > doc/guides/prog_guide/index.rst | 1 + > doc/guides/prog_guide/pcapng_lib.rst | 24 + > doc/guides/prog_guide/pdump_lib.rst | 28 +- > doc/guides/rel_notes/release_21_11.rst | 10 + > doc/guides/tools/dumpcap.rst | 86 ++ > doc/guides/tools/index.rst | 1 + > lib/bpf/bpf_convert.c | 575 ++++++++++++ > lib/bpf/bpf_dump.c | 139 +++ > lib/bpf/bpf_validate.c | 9 +- > lib/bpf/meson.build | 6 + > lib/bpf/rte_bpf.h | 39 + > lib/bpf/version.map | 7 + > lib/meson.build | 6 +- > lib/pcapng/meson.build | 8 + > lib/pcapng/pcapng_proto.h | 129 +++ > lib/pcapng/rte_pcapng.c | 613 +++++++++++++ > lib/pcapng/rte_pcapng.h | 194 ++++ > lib/pcapng/version.map | 12 + > lib/pdump/meson.build | 2 +- > lib/pdump/rte_pdump.c | 427 ++++++--- > lib/pdump/rte_pdump.h | 113 ++- > lib/pdump/version.map | 8 + > 33 files changed, 3733 insertions(+), 219 deletions(-) > create mode 100644 app/dumpcap/main.c > create mode 100644 app/dumpcap/meson.build > create mode 100644 app/test/test_pcapng.c > create mode 100644 doc/guides/prog_guide/pcapng_lib.rst > create mode 100644 doc/guides/tools/dumpcap.rst > create mode 100644 lib/bpf/bpf_convert.c > create mode 100644 lib/bpf/bpf_dump.c > create mode 100644 lib/pcapng/meson.build > create mode 100644 lib/pcapng/pcapng_proto.h > create mode 100644 lib/pcapng/rte_pcapng.c > create mode 100644 lib/pcapng/rte_pcapng.h > create mode 100644 lib/pcapng/version.map > Anything outstanding on this patchset? Would like this to make 20.11 The only failures in CI are false positives: ie bogus checkpatch, and ice RHEL7 build