From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76B14A0C47; Tue, 12 Oct 2021 10:06:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 05A5040142; Tue, 12 Oct 2021 10:06:52 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam08on2053.outbound.protection.outlook.com [40.107.102.53]) by mails.dpdk.org (Postfix) with ESMTP id 166A34003C for ; Tue, 12 Oct 2021 10:06:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZX/bo/F3Hy1TFuCIxQt3aBx3ZmIZ5TwYMnG+qeT0AYbHBWTmnr6W1ZKaoDNGuY76lKI8jyeqUhWlNeqYly6g3CP1/1fNk3kAk1XULleBKT4a4cokgjq6jlOFNIvDLIHBhFDreDBKOSRVLKA8QP9bP8dHpJGXg4Aq5a4JUuFKz60limd30gBBFzALHFVLr9LjFHSs5VSSPziMZuvLU9Rk+XV2ZDWgjDJ3y0j0YnN03Q9RSsbc2gMiOegeNU1OA9uZCT13RBOgqwtTQOxrImoYhKhwuIK0WiR0k8v4YT/q1wy9ILDbRNc1c+zGz+/iAvnB76WrNYHzwwrrC8pZilhikw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vPptAHo5sh3xJr9DqAFzWn5kpqzqmignqKXq8GIezSk=; b=htyaEO5iu7wroVUbCiUL+SLf0tKf1t1fuiULu4jXWqQ1nUXxLxNKnCVarq5ujXIq9zxySkxvtpubVkw8SgRDO8EzW4xFMnXLu4EIisYnKirii06Mc6sG5c59WwMFMdD2yL7S1tMRjyuthvGX90VXlmVP/QbiaElBGmTZr16klzj7UXw8nRz5VfjwHzRWlODR9j+aJyyw+Mzpqbsx3u/93r0UwbWGLvoGaYJAtP35/1f8qAxseJ2QCJOubwJbPX2xRENR94+rpdHJB94BLg9aDq+bWz8pCYOLGvwB7pxq2V50alYJeapX1/ISgpy42ZpTuDgz4VYfwxDpQ0YQaX/wQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vPptAHo5sh3xJr9DqAFzWn5kpqzqmignqKXq8GIezSk=; b=sPGfP5a5z2UvLObwIscNYw0Et7P9R7ZNLZK0FunAG58hMTvmppw4y5K0q5qNeiPVbEVP97KJn7QHZSOLOWBxrAabjHWaceGIUJk4ztXENpCZYZOofz4kPnkg1Yo/CJQ+eTfAMHBfxZPharn5D+R+RFHklbCxBy6CeHGcDUy3fAA+O5EeWw3bVtyjzF4m/RGKYyAeTPqvj8Om/3iDd7cWsMUDc/bpBmRE/k5c08YtY4G9k8flt/tE7SyNI256ulAmL/ZfnPw4Zrx8xxaeWjG7nye968XRVaUmHJqxFsQbDDrNPhKVFQaE1EOiYmmXQ0n+vFYHQu07ydFLvYGT3arpbQ== Received: from MW4PR03CA0099.namprd03.prod.outlook.com (2603:10b6:303:b7::14) by DM4PR12MB5117.namprd12.prod.outlook.com (2603:10b6:5:390::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Tue, 12 Oct 2021 08:06:49 +0000 Received: from CO1NAM11FT013.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b7:cafe::11) by MW4PR03CA0099.outlook.office365.com (2603:10b6:303:b7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 08:06:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT013.mail.protection.outlook.com (10.13.174.227) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 08:06:49 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 12 Oct 2021 08:06:46 +0000 From: Viacheslav Ovsiienko To: CC: , , , , , Date: Tue, 12 Oct 2021 11:06:26 +0300 Message-ID: <20211012080631.28504-1-viacheslavo@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20210910141609.8410-1-viacheslavo@nvidia.com> References: <20210910141609.8410-1-viacheslavo@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9d725394-fafc-4d2e-8674-08d98d573e09 X-MS-TrafficTypeDiagnostic: DM4PR12MB5117: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2512; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 83HWXNSx1IFvP5fOXUOYm+CAxS4OeTeSvQCUr7q8+UmkM2OiWRaUvsdd1+urHCMM4Ryu6MSbaR02VQGtb+3mSvtqVqbOZyY5b4NYh8OHlslWs6wKDDJEoj1Y/d3WokkHLm4oF15rcyHPpaH7ZNo3NugH/tBkeLR6CxYXvzaHuENFaFPGFv9XayuPmWTKs5AH6gHK8e9xDVhkIRRZZ1/Wgx6NAQ0Z//QlBd08ivRfx2gJ1a1W+ZFnghqlNOcWSY8CFa93kqzxcbcJES577T7svoD3oMC7hSa+1T1uA45S0w1EKvGmNf//6r6aeLLf3/ZdpIVFNQvv4I+0CDE0QBEAcwm1MpvatYOP/5YIwX06kiCt6QICrQ/XLHFzqKinUzjgveCNr23bFjvCSvCVR7jNV3ON50n8UgZZDMa5WeEr2d7+qAck71tcGEwoAaQ7LC3ambygMTHG6TfD7mq2eW367pWwxYyb+9CwaKwiBjT1wlYmBaNisbPmc8pDSFiEtWanHX/7cTdIaX7iY7+WzCDKu84zW9gb3QGvItklsnHmQm0AnESjfijKwV+mVneLghM/lcZv2wpbe+8I3XxOAuDK2pVcQEFOj6TeubnluPX4Nk94Kf8qgqnodaDJ725j1kgljcX05pPwoaoqC1P7KqM/Ps6QtT3FSZ9Ha4LdRPt/5N+iHyRT5cTmi1xVXzeKzPU4rOoBGMZWA065comxgqn5Zm3uwa8f7v1y0yvd8m6po+yuipXAlokc/B19jaYi7TQ7whx6mi8jaTcltLP+nHUVL64DeGMCWt03HirEGvSt/RkMcXB98YVTE8LB8NYHLr/xhC0tcrp1bUvH2vrgNiLcfw== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(47076005)(16526019)(966005)(26005)(2906002)(82310400003)(6916009)(316002)(5660300002)(15650500001)(55016002)(8676002)(356005)(186003)(54906003)(7636003)(70206006)(36756003)(86362001)(4326008)(8936002)(36860700001)(6286002)(1076003)(83380400001)(70586007)(426003)(336012)(7696005)(6666004)(2616005)(508600001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 08:06:49.1049 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9d725394-fafc-4d2e-8674-08d98d573e09 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT013.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5117 Subject: [dpdk-dev] [PATCH v3 0/5] ethdev: update modify field flow action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The generic modify field flow action introduced in [1] has some issues related to the immediate source operand: - immediate source can be presented either as an unsigned 64-bit integer or pointer to data pattern in memory. There was no explicit pointer field defined in the union - the byte ordering for 64-bit integer was not specified. Many fields have lesser lengths and byte ordering is crucial. - how the bit offset is applied to the immediate source field was not defined and documented - 64-bit integer size is not enough to provide MAC and IPv6 addresses In order to cover the issues and exclude any ambiguities the following is done: - introduce the explicit pointer field in rte_flow_action_modify_data structure - replace the 64-bit unsigned integer with 16-byte array - update the modify field flow action documentation Appropriate commit message has been removed. [1] commit 73b68f4c54a0 ("ethdev: introduce generic modify flow action") [2] RFC: http://patches.dpdk.org/project/dpdk/patch/20210910141609.8410-1-viacheslavo@nvidia.com/ [3] Deprecation notice: http://patches.dpdk.org/project/dpdk/patch/20210803085754.643180-1-orika@nvidia.com/ [4] v1 - http://patches.dpdk.org/project/dpdk/cover/20211001195223.31909-1-viacheslavo@nvidia.com/ [5] v2 - http://patches.dpdk.org/project/dpdk/patch/20211010234547.1495-2-viacheslavo@nvidia.com/ v2: - comments addressed - documentation updated - typos fixed - mlx5 PMD updated v3: - comments addressed - documentation updated - typos fixed Signed-off-by: Viacheslav Ovsiienko Viacheslav Ovsiienko (5): ethdev: update modify field flow action ethdev: fix missed experimental tag for modify field action app/testpmd: update modify field flow action support app/testpmd: fix hex string parser in flow commands net/mlx5: update modify field action app/test-pmd/cmdline_flow.c | 60 ++++++++++++++++++-------- doc/guides/prog_guide/rte_flow.rst | 24 ++++++++++- doc/guides/rel_notes/deprecation.rst | 4 -- doc/guides/rel_notes/release_21_11.rst | 7 +++ drivers/net/mlx5/mlx5_flow_dv.c | 50 ++++++++++++--------- lib/ethdev/rte_flow.h | 19 ++++++-- 6 files changed, 116 insertions(+), 48 deletions(-) -- 2.18.1