From: Przemyslaw Zegan <przemyslawx.zegan@intel.com>
To: dev@dpdk.org
Cc: gakhil@marvell.com, roy.fan.zhang@intel.com,
Przemyslaw Zegan <przemyslawx.zegan@intel.com>,
pablo.de.lara.guarch@intel.com
Subject: [dpdk-dev] [dpdk-dev v4] app: fix buffer overrun
Date: Tue, 12 Oct 2021 12:56:11 +0000 [thread overview]
Message-ID: <20211012125611.2774670-1-przemyslawx.zegan@intel.com> (raw)
In-Reply-To: <20211011080452.2710095-1-przemyslawx.zegan@intel.com>
This patch fixes a possible buffer overrun problem in crypto perf test.
Previously when user configured aad size is over 12 bytes the copy of template aad will cause a buffer overrun.
The problem is fixed by only copy up to 12 bytes of aad template.
Fixes: 8a5b494a7f99 ("app/test-crypto-perf: add AEAD parameters")
Cc: pablo.de.lara.guarch@intel.com
Signed-off-by: Przemyslaw Zegan <przemyslawx.zegan@intel.com>
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
---
v4:
- rebased on top of latest master
v3:
- replaced hardcoded values by sizeof(aad)
v2:
- changed to correct fixed line.
app/test-crypto-perf/cperf_test_vectors.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/app/test-crypto-perf/cperf_test_vectors.c b/app/test-crypto-perf/cperf_test_vectors.c
index 4bba405961..314e2b7710 100644
--- a/app/test-crypto-perf/cperf_test_vectors.c
+++ b/app/test-crypto-perf/cperf_test_vectors.c
@@ -590,6 +590,10 @@ cperf_test_vector_get_dummy(struct cperf_options *options)
rte_free(t_vec);
return NULL;
}
+
+ if(options->aead_aad_sz > sizeof(aad))
+ options->aead_aad_sz = sizeof(aad);
+
memcpy(t_vec->aad.data, aad, options->aead_aad_sz);
t_vec->aad.phys_addr = rte_malloc_virt2iova(t_vec->aad.data);
t_vec->aad.length = options->aead_aad_sz;
--
2.30.2
next prev parent reply other threads:[~2021-10-12 12:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 13:21 [dpdk-dev] [PATCH] " Przemyslaw Zegan
2021-09-21 14:41 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2021-09-22 10:15 ` [dpdk-dev] [dpdk-dev v2] " Przemyslaw Zegan
2021-10-05 14:45 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-10-11 8:04 ` [dpdk-dev] [dpdk-dev v3] " Przemyslaw Zegan
2021-10-11 10:45 ` Zhang, Roy Fan
2021-10-12 12:56 ` Przemyslaw Zegan [this message]
2021-10-16 13:44 ` [dpdk-dev] [EXT] [dpdk-dev v4] " Akhil Goyal
2021-10-16 13:46 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211012125611.2774670-1-przemyslawx.zegan@intel.com \
--to=przemyslawx.zegan@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).