From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B05DEA0C4C; Tue, 12 Oct 2021 22:26:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 50640410F4; Tue, 12 Oct 2021 22:26:21 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2056.outbound.protection.outlook.com [40.107.93.56]) by mails.dpdk.org (Postfix) with ESMTP id C799F410EE for ; Tue, 12 Oct 2021 22:26:19 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ki0mpIrXHJ/2doIzv0Ac06zRHRY1T17FSICpHlS7lKNgKjY21NdF5PaVt18lmLT6VFmhl9Vh5qyG9eTG6y18osG4N3mY9cofBlgldpnaz+e8RMVFnYYEem4BmcarZ8JNpNpgwzBAIIfT/t304RCrAsWIsWQDAE5KUNHZGqCJIYuuxg1ECBcShuUTFS7uuuxZS4XJxmVGE2+ConLJKPO1Uitij51UhAPQx5FGcvot9fRNCd81X8xuAQIbhRvsohIPTwm9dBF4OvQaofB/7BUgZrSt4eUmd+fzkxQMqTQMnKCmSP6McoEAayRJuT0nxZ2+7aJjeU6ZopeABDvoNrP78Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kgjv6hwL0e2zt4EISd1gMxOQCiVprAKNNRjvaOVAsAE=; b=RkD/3IUbF7fzC+5LaN5Sis8uaoj9mhjnhLK0Q1eVvVB+F/dTo+xLfGW6ITFAEWHLbEj0GIiaHQ4ElcQxIXiPt+ub3egNHMu4vmI5lM6uzJax/oRA7l/iljfhtZ87Lk1Y1vWRN61SQErz+IUxzDHgkpHgh481ulHYCFOPB2u7W1QEK2513RdMjs4pKb+De7gvF+YUq/yyjbhRcquFIKLgujANIzNRUYEkC0y9Vt7t8z1TzFCIdUPxgat+7cOTwQOOx/M3idOPn/ECp0x8xdiu/s0pWPuuC4ukyXtWOjS6w72e2Lx7/3cVHDqJ21tQlc9Ih+51XDZHAPKhmWqKXlqYJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kgjv6hwL0e2zt4EISd1gMxOQCiVprAKNNRjvaOVAsAE=; b=fcNxRbzJhjMLFLVAvUIEjRm3qiF3qe36gkZHMZ814riLJIwBwx4kQixKfX0RIQeNNAvXFvqT9iIuNz0jHACXsM515psfk9IU4uWbyRPCsY/nC3pZtplom9zSLudEhiUWkhC4MUAIVAJTMP1CiF5pyJxHays6MlANorEWZuqPQwJLwUsckjBDRWRvYeCO+QwOWHYdBVmU0Dviol+sSAqfc6uFVChzXXELt+AQ+FIgAn/Gx0BGhPoc4KY00nXyQb78bAUjgj3Zbu5/AcvNwBZa57q6SVTudUyF+w58jPOsxreuDvT4p8saTjYK6wKZEByCrpjCRjHay8mN3Dn7rzBs2A== Received: from DM6PR13CA0069.namprd13.prod.outlook.com (2603:10b6:5:134::46) by BYAPR12MB3639.namprd12.prod.outlook.com (2603:10b6:a03:db::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Tue, 12 Oct 2021 20:26:18 +0000 Received: from DM6NAM11FT013.eop-nam11.prod.protection.outlook.com (2603:10b6:5:134:cafe::87) by DM6PR13CA0069.outlook.office365.com (2603:10b6:5:134::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.7 via Frontend Transport; Tue, 12 Oct 2021 20:26:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT013.mail.protection.outlook.com (10.13.173.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4587.18 via Frontend Transport; Tue, 12 Oct 2021 20:26:17 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 12 Oct 2021 20:26:10 +0000 From: Viacheslav Ovsiienko To: CC: , , , , , Date: Tue, 12 Oct 2021 23:25:52 +0300 Message-ID: <20211012202557.30295-1-viacheslavo@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20210910141609.8410-1-viacheslavo@nvidia.com> References: <20210910141609.8410-1-viacheslavo@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 89b42d76-f4d5-4851-c005-08d98dbe8b66 X-MS-TrafficTypeDiagnostic: BYAPR12MB3639: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3383; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7pwiGXsdV/RJwencpreun1b/rmyZ7zF5UKFtjW6EYnrXvtEl1fUpN/BUsQMThWgQ4Nk8s8i7GMTn1dRgwrQrglmz8+yYfm4DxRN0cz4NQyfnotY9JjliBjMu7JAyEpTd2iVqZspw9zVMx3NFB3pushcUfVi57Ct/I/QTweb5E7w3mE7DtOuWs9LmX1oFfk6pZb36xOYJD6TT9t2ogB1p7B/dBz9p131CQOatPeJETubq3KWeVLVQf2563/s943AtFFZJ34MwrYvjnBxx9e64hkqREJcxjZF70SqCJCxJ694u9JGxLaXAvDLMHiT/ut4Tk2aV/RMpKJCmjSOaffB1k/0eeZT2w18Gz9QFV1wJJsrwOuNexY5TCu719oYQpZISyhyDcsq5LAuV9Nw0fIi1HkfkZWH84ZObiS6r/YeslVUCnMg9w2NmLNCE41KiO7aar407VNsDkdMPPAPtQee0VzFQjtLnT9NTnFFSi3PY1hQBEAvHkygAfBpW+jHy7NNm6WQhkTD4mmwAQ9flvncS3R+AVW5SoaxWi68plcxvAoibCYFPnwDY1umTiFDxJuf+hwmOaCzlziIG+90jNoCZr34mqgsRI+bwQj2T6cMlCVc1OFYHYzwKiwOYugstXAR6S9/9u+CDXMEPuNtkJeTTzvH4STO9IViM6U55fn/D8JJfi52YlEjLNMVDI9SOULk6J+hbCOgllHHAk+8tgnxC0Z1HTXrd1gTm4TCgGQHjLs+BdC9N32Tc2Nw9mc2hfhFdCr1kLiplSzpJPhaxOjaBgMEH2WNTQ7t0AkEyzXAs83WI/ZjVvs+v+iWbfekSlOI6ud3olk3vk6li5YKretiVOg== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(86362001)(1076003)(426003)(6916009)(82310400003)(5660300002)(2906002)(36756003)(4326008)(8676002)(2616005)(54906003)(70206006)(7696005)(6666004)(83380400001)(8936002)(336012)(15650500001)(356005)(316002)(70586007)(508600001)(6286002)(26005)(7636003)(47076005)(36860700001)(55016002)(966005)(186003)(16526019); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 20:26:17.0705 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 89b42d76-f4d5-4851-c005-08d98dbe8b66 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT013.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3639 Subject: [dpdk-dev] [PATCH v5 0/5] ethdev: update modify field flow action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The generic modify field flow action introduced in [1] has some issues related to the immediate source operand: - immediate source can be presented either as an unsigned 64-bit integer or pointer to data pattern in memory. There was no explicit pointer field defined in the union - the byte ordering for 64-bit integer was not specified. Many fields have lesser lengths and byte ordering is crucial. - how the bit offset is applied to the immediate source field was not defined and documented - 64-bit integer size is not enough to provide MAC and IPv6 addresses In order to cover the issues and exclude any ambiguities the following is done: - introduce the explicit pointer field in rte_flow_action_modify_data structure - replace the 64-bit unsigned integer with 16-byte array - update the modify field flow action documentation Appropriate commit message has been removed. [1] commit 73b68f4c54a0 ("ethdev: introduce generic modify flow action") [2] RFC: http://patches.dpdk.org/project/dpdk/patch/20210910141609.8410-1-viacheslavo@nvidia.com/ [3] Deprecation notice: http://patches.dpdk.org/project/dpdk/patch/20210803085754.643180-1-orika@nvidia.com/ [4] v1 - http://patches.dpdk.org/project/dpdk/cover/20211001195223.31909-1-viacheslavo@nvidia.com/ [5] v2 - http://patches.dpdk.org/project/dpdk/patch/20211010234547.1495-2-viacheslavo@nvidia.com/ [6] v3 - http://patches.dpdk.org/project/dpdk/cover/20211012080631.28504-1-viacheslavo@nvidia.com/ [7] v4 - http://patches.dpdk.org/project/dpdk/cover/20211012104919.13145-1-viacheslavo@nvidia.com/ v2: - comments addressed - documentation updated - typos fixed - mlx5 PMD updated v3: - comments addressed - documentation updated - typos fixed v4: - removed errorneously added Ack by Ori K. for mlx5 patch - mlx5 patch updated - bug fixes and cleanup v5: - fix compilation issue with unused variable in mlx5 Viacheslav Ovsiienko (5): ethdev: update modify field flow action ethdev: fix missed experimental tag for modify field action app/testpmd: update modify field flow action support app/testpmd: fix hex string parser in flow commands net/mlx5: update modify field action app/test-pmd/cmdline_flow.c | 60 ++++++++---- doc/guides/prog_guide/rte_flow.rst | 24 ++++- doc/guides/rel_notes/deprecation.rst | 4 - doc/guides/rel_notes/release_21_11.rst | 7 ++ drivers/net/mlx5/mlx5_flow_dv.c | 123 ++++++++----------------- lib/ethdev/rte_flow.h | 19 +++- 6 files changed, 127 insertions(+), 110 deletions(-) -- 2.18.1