From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com, stable@dpdk.org,
Lance Richardson <lance.richardson@broadcom.com>
Subject: [dpdk-dev] [PATCH v4 2/3] net/bnxt: fix Rx queue state on start
Date: Tue, 12 Oct 2021 14:18:44 -0700 [thread overview]
Message-ID: <20211012211845.71121-3-ajit.khaparde@broadcom.com> (raw)
In-Reply-To: <20211012211845.71121-1-ajit.khaparde@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 1536 bytes --]
Fix Rx queue state on device start.
The state of Rx queues could be incorrect in some cases
because instead of updating the state for all the Rx queues,
we are updating it for queues in a VNIC.
Fixes: 0105ea1296c9 ("net/bnxt: support runtime queue setup")
Cc: stable@dpdk.org
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Reviewed-by: Lance Richardson <lance.richardson@broadcom.com>
---
drivers/net/bnxt/bnxt_ethdev.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index aa7e7fdc85..a98f93ab29 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -482,12 +482,6 @@ static int bnxt_setup_one_vnic(struct bnxt *bp, uint16_t vnic_id)
rxq->vnic->fw_grp_ids[j] = INVALID_HW_RING_ID;
else
vnic->rx_queue_cnt++;
-
- if (!rxq->rx_deferred_start) {
- bp->eth_dev->data->rx_queue_state[j] =
- RTE_ETH_QUEUE_STATE_STARTED;
- rxq->rx_started = true;
- }
}
PMD_DRV_LOG(DEBUG, "vnic->rx_queue_cnt = %d\n", vnic->rx_queue_cnt);
@@ -824,6 +818,16 @@ static int bnxt_start_nic(struct bnxt *bp)
}
}
+ for (j = 0; j < bp->rx_nr_rings; j++) {
+ struct bnxt_rx_queue *rxq = bp->rx_queues[j];
+
+ if (!rxq->rx_deferred_start) {
+ bp->eth_dev->data->rx_queue_state[j] =
+ RTE_ETH_QUEUE_STATE_STARTED;
+ rxq->rx_started = true;
+ }
+ }
+
rc = bnxt_hwrm_cfa_l2_set_rx_mask(bp, &bp->vnic_info[0], 0, NULL);
if (rc) {
PMD_DRV_LOG(ERR,
--
2.30.1 (Apple Git-130)
next prev parent reply other threads:[~2021-10-12 21:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 3:23 [dpdk-dev] [PATCH 0/3] patchset for bnxt PMD Ajit Khaparde
2021-10-07 3:23 ` [dpdk-dev] [PATCH 1/3] net/bnxt: create aggregration rings when needed Ajit Khaparde
2021-10-07 3:23 ` [dpdk-dev] [PATCH 2/3] net/bnxt: fix Rx queue state on start Ajit Khaparde
2021-10-07 3:23 ` [dpdk-dev] [PATCH 3/3] net/bnxt: enhance support for RSS action Ajit Khaparde
2021-10-07 16:54 ` [dpdk-dev] [PATCH 0/3] patchset for bnxt PMD Ajit Khaparde
2021-10-12 18:14 ` Ferruh Yigit
2021-10-12 18:16 ` Ajit Khaparde
2021-10-12 19:03 ` Ajit Khaparde
2021-10-12 19:49 ` Ferruh Yigit
2021-10-12 20:30 ` Ajit Khaparde
2021-10-12 20:39 ` Ajit Khaparde
2021-10-12 21:14 ` [dpdk-dev] [PATCH v3 " Ajit Khaparde
2021-10-12 21:14 ` [dpdk-dev] [PATCH v3 1/3] net/bnxt: create aggregration rings when needed Ajit Khaparde
2021-10-12 21:14 ` [dpdk-dev] [PATCH v3 2/3] net/bnxt: fix Rx queue state on start Ajit Khaparde
2021-10-12 21:14 ` [dpdk-dev] [PATCH v3 3/3] net/bnxt: enhance support for RSS action Ajit Khaparde
2021-10-12 21:18 ` [dpdk-dev] [PATCH v4 0/3] patchset for bnxt PMD Ajit Khaparde
2021-10-12 21:18 ` [dpdk-dev] [PATCH v4 1/3] net/bnxt: create aggregration rings when needed Ajit Khaparde
2021-10-12 21:18 ` Ajit Khaparde [this message]
2021-10-12 21:18 ` [dpdk-dev] [PATCH v4 3/3] net/bnxt: enhance support for RSS action Ajit Khaparde
2021-10-12 21:47 ` [dpdk-dev] [PATCH v4 0/3] patchset for bnxt PMD Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211012211845.71121-3-ajit.khaparde@broadcom.com \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=lance.richardson@broadcom.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).