From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4FCDA0C55; Wed, 13 Oct 2021 20:45:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A52A241134; Wed, 13 Oct 2021 20:45:38 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2087.outbound.protection.outlook.com [40.107.92.87]) by mails.dpdk.org (Postfix) with ESMTP id 4401E4111B for ; Wed, 13 Oct 2021 20:45:36 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XeKYeOGEbWcAhp3bi14XT0WPiJmOIWa1eQtZe736ml4Pt/qox+26lKNhIFI+dx+9VyniEWzFVg2ZsfglTYbsz63mdsnKSKMH2zr8nvfDF8CVsr6RxI4DnycYVrp5vG6vrckvSYE2exK3e5L2tl1yO62lhEwiCyTp5MNCltrE4pLKcG87h/5Gh8c4muH/0hS76Kf497R5IZ2CTuWkEMMhXze6TrIIKN5wQesixY3v7WSoNN5figVRs8Heb028F5nbaDNfvSLZCz52anG2WIOHiQA39RuFTRICSmLo3z3VR6YxEC+zohNAqqfEzlnFNyxWZwXmY/WD5Df7zjVi0NWoXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0ydwqfgx/Xk1JwZgGMFDtwRgDOnRF9FR6zn7JyYG1r0=; b=H+ieFSnPTrfEwaobKRGkdfxSWLrTpx0oGqLY3uaKsEc1Xd1QiwDrJ946p84ugh31MBnkkGK9J6XHf27jhqQzK2r1/VyvJLyPoxrvGw2B/WdtHDxZ3vd4tDscnw1f7UcDGEuuhrn0hFC5ouXtuyFwd7feriIrVDDVH8RHFbWlh6VjK/35Zp2GJdmAK1r3D/Bxgz+alsNnvNeVcR9i/DfUQcYJon3iqzLig7UwhR1Bz46iZxg8CGoJClHUa98mZVb+NqdOGnsR3yohBFwvQu0xU8irb8tCVGNikqaFwUNM9FVmNGu38tGeWunlv+WqOl8tV3x1oC9poy71c6/QqiDuGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0ydwqfgx/Xk1JwZgGMFDtwRgDOnRF9FR6zn7JyYG1r0=; b=b/0GaaFwtaVjem2iBNkuiWN2CoNMQdc7pDZw1JdYjSSFxzn5wz7sjt0wRn1k3G0kpft2xHbss3TCoxpJqOIWvhbJFu3nqNQKyHmt5zUinQKjQpW0JVlcWWgjv2ZhjJKu72LfQevHfhY9G9qFuSpzIMaQ0xeCoK5zIjlOU82cjxGk9PUgZ78QYw2OL2io7ckIa8NkElVf7K4YIWkMuq3HpSn8YKmfkuPo5hL0k/fzMjaI2bTzMDDJn4HN6tnHOav190NcsBPbLJDa9yLqksca9P44rC1U1PQaZdeX6BzkXZOudcpB7+EDMXZ++ht7DDqOOchAWbqSVSP6I033Kf819A== Received: from MW3PR06CA0029.namprd06.prod.outlook.com (2603:10b6:303:2a::34) by DM6PR12MB4619.namprd12.prod.outlook.com (2603:10b6:5:7c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Wed, 13 Oct 2021 18:45:35 +0000 Received: from CO1NAM11FT058.eop-nam11.prod.protection.outlook.com (2603:10b6:303:2a:cafe::83) by MW3PR06CA0029.outlook.office365.com (2603:10b6:303:2a::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend Transport; Wed, 13 Oct 2021 18:45:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT058.mail.protection.outlook.com (10.13.174.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4608.15 via Frontend Transport; Wed, 13 Oct 2021 18:45:34 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 13 Oct 2021 18:45:31 +0000 From: Viacheslav Ovsiienko To: CC: , , , , , Date: Wed, 13 Oct 2021 21:45:11 +0300 Message-ID: <20211013184516.25338-1-viacheslavo@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20210910141609.8410-1-viacheslavo@nvidia.com> References: <20210910141609.8410-1-viacheslavo@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e7ab9e37-8649-4e25-0314-08d98e79a402 X-MS-TrafficTypeDiagnostic: DM6PR12MB4619: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3383; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z8x1i32+Dlax+228AUGYOzI/txdMzlomchtsRNfDY8QupVku9BdUb7hwODQh9URr0qp7ghqlLohZiJ/2gLNHDOxV3OGPoClbOVDZwcReWR1M15eTTyLc6Iv156tKmGBxGFd44yJIwiKG4fh4BJsvfZKBZ8uVW1Po7qvXrkH5WdKxbpycPElwENRrmRBG3x+J8HMAb5nCbabE8RSiRJDcZntafX5+e8OyJALedreZGttFA96zCjf0siLLXM/eiqbb836oXpNimnGS39CbzDYHVrHIXJOHedi3Kcf70Wd79RCoDg0af/vECrNSmykuH/ZnASEJoZM72/Vr2IuR7LIBCJb7Uahc2LCmWSLYVJAcQ1LLqOuq/Phsef/LGEfaP6CLLlMwW63+WXYY+eFx8SxZzsRl3Yb+Nq9kCWpkFjOLEordzPhfac5ih2J96tdQDQJ5LhW/3c/7MWzBdJhBtrN0augIRbOxhb5uhWm8ziKDVgfEkH5XeSeqcWyipUDDe588sYITOub1pNWiTTQuIfM6b4Ve8TVgeQzWKTTvtcTAm4btrPYtXs33bKO+ZEbraOBPSGMsNtEPKyGimnQERz24L+zhw7H2MFzp2C+loLOx1r2pqTD8k4W2/K0Qw4hErPEHlgghkMkf2ZMECwf4vqrQ/cKfwTdfACbcqSNjeZ1s3AolkndwEIAeFnoMSqnfa+Hn0bXE9r5eqJ6lg6KiizztbJDY0HBPdHduzFIg/lSz9jE5EW8okXsTjdzE4tWTTn/m4bztsz43MLPgN7gVTw6SDCArTFjpW/9arFetDu4KAQ7mru3lHljDGyt7Rsqlt3pW28a3Yy0jfeYEDa8brMGc1g== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(83380400001)(316002)(2616005)(70206006)(6666004)(966005)(47076005)(36860700001)(7636003)(2906002)(70586007)(82310400003)(356005)(86362001)(16526019)(36756003)(186003)(55016002)(4326008)(6916009)(1076003)(7696005)(8936002)(54906003)(508600001)(15650500001)(26005)(426003)(5660300002)(8676002)(6286002)(336012); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 18:45:34.1689 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e7ab9e37-8649-4e25-0314-08d98e79a402 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT058.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4619 Subject: [dpdk-dev] [PATCH v6 0/5] ethdev: update modify field flow action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The generic modify field flow action introduced in [1] has some issues related to the immediate source operand: - immediate source can be presented either as an unsigned 64-bit integer or pointer to data pattern in memory. There was no explicit pointer field defined in the union - the byte ordering for 64-bit integer was not specified. Many fields have lesser lengths and byte ordering is crucial. - how the bit offset is applied to the immediate source field was not defined and documented - 64-bit integer size is not enough to provide MAC and IPv6 addresses In order to cover the issues and exclude any ambiguities the following is done: - introduce the explicit pointer field in rte_flow_action_modify_data structure - replace the 64-bit unsigned integer with 16-byte array - update the modify field flow action documentation Appropriate commit message has been removed. [1] commit 73b68f4c54a0 ("ethdev: introduce generic modify flow action") [2] RFC: http://patches.dpdk.org/project/dpdk/patch/20210910141609.8410-1-viacheslavo@nvidia.com/ [3] Deprecation notice: http://patches.dpdk.org/project/dpdk/patch/20210803085754.643180-1-orika@nvidia.com/ [4] v1 - http://patches.dpdk.org/project/dpdk/cover/20211001195223.31909-1-viacheslavo@nvidia.com/ [5] v2 - http://patches.dpdk.org/project/dpdk/patch/20211010234547.1495-2-viacheslavo@nvidia.com/ [6] v3 - http://patches.dpdk.org/project/dpdk/cover/20211012080631.28504-1-viacheslavo@nvidia.com/ [7] v4 - http://patches.dpdk.org/project/dpdk/cover/20211012104919.13145-1-viacheslavo@nvidia.com/ [8] v5 - http://patches.dpdk.org/project/dpdk/patch/20211012202557.30295-2-viacheslavo@nvidia.com/ v2: - comments addressed - documentation updated - typos fixed - mlx5 PMD updated v3: - comments addressed - documentation updated - typos fixed v4: - removed errorneously added Ack by Ori K. for mlx5 patch - mlx5 patch updated - bug fixes and cleanup v5: - fix compilation issue with unused variable in mlx5 v6: - fix compilation issue with unused variable in mlx5 Viacheslav Ovsiienko (5): ethdev: update modify field flow action ethdev: fix missed experimental tag for modify field action app/testpmd: update modify field flow action support app/testpmd: fix hex string parser in flow commands net/mlx5: update modify field action app/test-pmd/cmdline_flow.c | 60 ++++++++---- doc/guides/prog_guide/rte_flow.rst | 24 ++++- doc/guides/rel_notes/deprecation.rst | 4 - doc/guides/rel_notes/release_21_11.rst | 7 ++ drivers/net/mlx5/mlx5_flow_dv.c | 128 +++++++++---------------- lib/ethdev/rte_flow.h | 19 +++- 6 files changed, 131 insertions(+), 111 deletions(-) -- 2.18.1