From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B4FEA034F; Fri, 15 Oct 2021 18:28:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 38B5D411AD; Fri, 15 Oct 2021 18:27:53 +0200 (CEST) Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by mails.dpdk.org (Postfix) with ESMTP id B58A94117C for ; Fri, 15 Oct 2021 18:27:49 +0200 (CEST) Received: by mail-lf1-f47.google.com with SMTP id r19so42856939lfe.10 for ; Fri, 15 Oct 2021 09:27:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rp1Bb1XJSHXd9hdUDhS9BrMlzFrVcOXUFD5VzFUGerI=; b=Iu3ROXJoFmFd+3s1nVFfz8vkqHuSrSwEvCFZicYQDQQ91nBzpXAytycT2WxxbsrjII RgUb0REhbzfra9n63jWeAbevyvEVi+CHRIwUDnU5cQ+s6PqJeBPN+bCGBmCd2iIkMi6v 3LEczoWinVCssokHz/xr5o15yDhgikevUVNdcG/jUbd6PHXX/tj4w+XtzUZr3lCeqpYc Cs+LkJan1jUFOsM2YFaeCCP+Uf+g+h4to1V7gBWGIw35NYsh/j3d0BSDtV00addGTEyh xLvgkWUxEBIrpLvCTMHYbXZHkJmlWQu28gu00YqOv3H6+eaxXwRdqOtacB00cObLDHUF 0idw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rp1Bb1XJSHXd9hdUDhS9BrMlzFrVcOXUFD5VzFUGerI=; b=LcnrucgavDwOcqw9BzhVSzwXpEG8a8BBe/xzGH3Es+abL8WkpVWbL2jEehPIMi14QG 0yxqD+5W/wKaGrqiRctgSq5yYFZsPqG5SxG1nTfKYKw4hsVc78Twd+RoFmhuWr5S/yVN x1d/4LUM4D4406rpHdnn5Tf50zJYCifAAQU+iXQvBRVZNYMOIbZzPoUpIjwa8BkVYRSZ eR+GTQW2NtMicTm55QWZGMAlb9SZt8z7Afl9eeyq+ns7rUl1YjoGg1Y2cEpj8ZJASKdy T0v1Bj55a/lrqUn1pkJ5cPEqX3Au7qZXaxF4C3ycYILLelRh7fRSJ3MO8jW5o8pSewYm /o/g== X-Gm-Message-State: AOAM532OWPXvK7x+cws6dYm2XxnldUngal2/iWW3R1sz827qED0l5QnK OrviG1ozXP08dmR5CaENfVzE2Q== X-Google-Smtp-Source: ABdhPJz74lO8jkMi6HrMzNpA+mKhDe4kRsWaMI+D3s6c8xEMV3myGX6RcWOYsYEz/4k0DyV58/knHg== X-Received: by 2002:a2e:90b:: with SMTP id 11mr14084734ljj.186.1634315269393; Fri, 15 Oct 2021 09:27:49 -0700 (PDT) Received: from DESKTOP-U5LNN3J.localdomain (89-79-181-52.dynamic.chello.pl. [89.79.181.52]) by smtp.gmail.com with ESMTPSA id b3sm559219lfe.58.2021.10.15.09.27.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Oct 2021 09:27:48 -0700 (PDT) From: Michal Krawczyk To: ferruh.yigit@intel.com Cc: dev@dpdk.org, upstream@semihalf.com, shaibran@amazon.com, ndagan@amazon.com, igorch@amazon.com, Michal Krawczyk , stable@dpdk.org Date: Fri, 15 Oct 2021 18:26:58 +0200 Message-Id: <20211015162701.16324-5-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211015162701.16324-1-mk@semihalf.com> References: <20211014201858.9571-1-mk@semihalf.com> <20211015162701.16324-1-mk@semihalf.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 4/7] net/ena: indicate missing scattered Rx capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" ENA can't be forced to always pass single descriptor for the Rx packet. Even if the passed buffer size is big enough to hold the data, we can't make assumption that the HW won't use extra descriptor because of internal optimizations. This assumption may be true, but only for some of the FW revisions, which may differ depending on the used AWS instance type. As the scattered Rx support on the Rx path already exists, the driver just needs to announce DEV_RX_OFFLOAD_SCATTER capability by turning on the rte_eth_dev_data::scattered_rx option. Fixes: 1173fca25af9 ("ena: add polling-mode driver") Cc: stable@dpdk.org Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index c2bd2f12af..35db2e8356 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -1929,8 +1929,14 @@ static int ena_dev_configure(struct rte_eth_dev *dev) dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH; dev->data->dev_conf.txmode.offloads |= DEV_TX_OFFLOAD_MULTI_SEGS; + /* Scattered Rx cannot be turned off in the HW, so this capability must + * be forced. + */ + dev->data->scattered_rx = 1; + adapter->tx_selected_offloads = dev->data->dev_conf.txmode.offloads; adapter->rx_selected_offloads = dev->data->dev_conf.rxmode.offloads; + return 0; } @@ -1978,7 +1984,7 @@ static uint64_t ena_get_rx_port_offloads(struct ena_adapter *adapter) if (adapter->offloads.rx_offloads & ENA_RX_RSS_HASH) port_offloads |= DEV_RX_OFFLOAD_RSS_HASH; - port_offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME; + port_offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME | DEV_RX_OFFLOAD_SCATTER; return port_offloads; } -- 2.25.1