From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 9CF2AA0C43;
Mon, 18 Oct 2021 15:00:54 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 2D1C1410EB;
Mon, 18 Oct 2021 15:00:46 +0200 (CEST)
Received: from NAM10-BN7-obe.outbound.protection.outlook.com
(mail-bn7nam10on2085.outbound.protection.outlook.com [40.107.92.85])
by mails.dpdk.org (Postfix) with ESMTP id C05FD410F6
for <dev@dpdk.org>; Mon, 18 Oct 2021 15:00:43 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=gcBBJrUGDV2zfNQfwBcjd8ip+7eDGR5dIn6/pe/sYW8UF1kfqV5YF50CvEE/HJUrmnwnJQGRpCxYTKQfz5laFJIaOrhW+zGyZBrdrbFqz62p8xhTxO0WA6qNgIzC0wzj+fV55Rf9G6L7951TvLEuYMNN9nskXAtU3Itn5Y2ctVYACGFRVnB8YtXT4NPqAvT7w/CvJLb57jbOXbxeCJkC7L+1UElZgMoi8PexhmBOSJpFj30mtI6p7vLFB9kEqaLauqQdSGuoVimjUDVU7+EZ/bBy0HtpGlRxHe5mW75xVtfRyX7VXhQ6fWPdCIQYEviVT4Zuvi5wIFIoELyZbLpoaw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=/iiL1nMgiMkbYTUOHNuFoZGIN69qjAPB3VVVQQr/7qY=;
b=gavwqLRVDZwnkyw08QEEusMTNvFjvISEqn3ojeCACNpMRmsGNWC8es2QRxO93jTtdUMlzsL7CqtaxsxsFAt5PCCUav9gcZj83a+YsZCeLOPCPOIgv+8ywcA0VnH/FQm9lR9NyH1/nRCswQlAnwTCtBNGPf7Qy8r5637jAdBy2OmL3kauPUnIdtrb3DaDskwjXHWMU0NQmTRlXRXpUSQ2Yri7dyho7Orq3h4reWKZVTeLZ2tzsdfr01V7ylYS8JFn/ZMKX0FG0pbjikzhFm5AylxRDPQxWNI2hNKXT3kfL11t+nsKN+n4XIh2oE0NJYkvgnfmOK4Xh91GWUyaqrtSkg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com;
dmarc=pass (p=quarantine sp=quarantine pct=100) action=none
header.from=nvidia.com; dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
s=selector2;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=/iiL1nMgiMkbYTUOHNuFoZGIN69qjAPB3VVVQQr/7qY=;
b=KheXxR4CWlsi6Mf+LYjgBtkmOuWcBi/8W9fmJn6cN+E9EeEb8EHpI/N8cKQbQKeq1Usu3VtTIzgYfFqfXVF6+/JJX9ZYeSs8jzdKE8c1UeWc6PXCzAp5lCHck6OroVJrFwDvsKHY+Fb5sho+1c2FXFWgKmCW+N1JsEDsyrs6AWVnyoLbnHbQlCYa9L6g/T2mPU0y5gLWR46UklmjfBYnGSy6uBLpEF4J461NymnVmQU+ZMXN4iPW9AGuWI6QBUzAocCTT4j3kkdj4wSuFNI61mtU5RGxdj4orVl0AnVySeUZQHxsqUMSJ6j2nZjJ4NJMeqgHmBtOuQENW9oh7dtiFQ==
Received: from MWHPR18CA0028.namprd18.prod.outlook.com (2603:10b6:320:31::14)
by BYAPR12MB3573.namprd12.prod.outlook.com (2603:10b6:a03:df::10)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Mon, 18 Oct
2021 13:00:40 +0000
Received: from CO1NAM11FT019.eop-nam11.prod.protection.outlook.com
(2603:10b6:320:31:cafe::e3) by MWHPR18CA0028.outlook.office365.com
(2603:10b6:320:31::14) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend
Transport; Mon, 18 Oct 2021 13:00:40 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34)
smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed)
header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
216.228.112.34 as permitted sender) receiver=protection.outlook.com;
client-ip=216.228.112.34; helo=mail.nvidia.com;
Received: from mail.nvidia.com (216.228.112.34) by
CO1NAM11FT019.mail.protection.outlook.com (10.13.175.57) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id
15.20.4608.15 via Frontend Transport; Mon, 18 Oct 2021 13:00:40 +0000
Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com
(172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 18 Oct
2021 13:00:28 +0000
From: Xueming Li <xuemingl@nvidia.com>
To: <dev@dpdk.org>
CC: <xuemingl@nvidia.com>, Jerin Jacob <jerinjacobk@gmail.com>, Ferruh Yigit
<ferruh.yigit@intel.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Thomas Monjalon
<thomas@monjalon.net>, Lior Margalit <lmargalit@nvidia.com>, "Ananyev
Konstantin" <konstantin.ananyev@intel.com>, Xiaoyun Li <xiaoyun.li@intel.com>
Date: Mon, 18 Oct 2021 20:59:39 +0800
Message-ID: <20211018125942.2067353-4-xuemingl@nvidia.com>
X-Mailer: git-send-email 2.33.0
In-Reply-To: <20211018125942.2067353-1-xuemingl@nvidia.com>
References: <20210727034204.20649-1-xuemingl@nvidia.com>
<20211018125942.2067353-1-xuemingl@nvidia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Originating-IP: [172.20.187.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
HQMAIL107.nvidia.com (172.20.187.13)
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cf181ac0-69fa-4105-db44-08d99237498c
X-MS-TrafficTypeDiagnostic: BYAPR12MB3573:
X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr
X-Microsoft-Antispam-PRVS: <BYAPR12MB3573D74299CE161F98032C0BA1BC9@BYAPR12MB3573.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2887;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 4CV577fJh+bCGulibBLgE1IXvJJOVTbNFARvTajQ+VyoSGN5DFtMYC4jjj8B1yOP6MCkrIRVo4FEBjYPT6OF2o+rkUVJYs8Pxw+fOgszwlvMmxACE5MsEFk5kuoioJDBI9R20nK0v1rb89yySuc/yA3t7rZcwa0TB1ogbnpBR42w6TF/C6P2/xoFEGnpvGvuY/h5hzyhM6V1Ahvqt4KgCzuV5N6t6rd9jUxl9CiUBoLi3Pn6MaGMV2xLDUTFv6Z/AGE40AGsB+4HYlN+EUTyR1PxyHMdBSrG3AyclDBD1FfMN9SQx0kHbSv0aJJF3cIKrVWSOfQnSmEK4ri06hSmKUMmOA65OPvWxpeD2eLxFDGefM1+ED7IXof6wjz6ixF/Kl0zTtBsL0Xl1vCId1iHEnFca4GktlECG3P7un0L3ZqObeQKSY6aX1wuvPhxqA06UvmDKa9AV5iLO2c0B5qMQORgQVdUnBy9Ah9KQqis9ekgDqfPp+UvGpKolQkB0GseJzv7tWg08JsO0fSg+pOnrHzCHNidQC6M5/sEbJE99Zkef8z0mYN9g4311h6Ni0Wcv0Mb9KENWxKykAZpgpbKhLdBLSrzD8qylTvW3ruaZNlcmpvY7nwU0m8TfDuywOw6Ij7lDEBYVD6l8+ZMz8/V41k+hpvgCPEiMvNz8ZGgJu7LlAKFzwFQwnD1c2wRMwGxzFsUgaQai2rkJPi1qliwVg==
X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;
SFS:(4636009)(36840700001)(46966006)(6286002)(6916009)(55016002)(508600001)(86362001)(70206006)(2616005)(6666004)(336012)(83380400001)(8936002)(2906002)(26005)(16526019)(36756003)(316002)(356005)(1076003)(4326008)(186003)(54906003)(5660300002)(47076005)(7696005)(70586007)(7636003)(8676002)(426003)(36860700001)(82310400003);
DIR:OUT; SFP:1101;
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 13:00:40.0782 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: cf181ac0-69fa-4105-db44-08d99237498c
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];
Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT019.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3573
Subject: [dpdk-dev] [PATCH v8 3/6] app/testpmd: new parameter to enable
shared Rx queue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Adds "--rxq-share=X" parameter to enable shared RxQ, share if device
supports, otherwise fallback to standard RxQ.
Share group number grows per X ports. X defaults to MAX, implies all
ports join share group 1. Queue ID is mapped equally with shared Rx
queue ID.
Forwarding engine "shared-rxq" should be used which Rx only and update
stream statistics correctly.
Signed-off-by: Xueming Li <xuemingl@nvidia.com>
---
app/test-pmd/config.c | 7 ++++++-
app/test-pmd/parameters.c | 13 +++++++++++++
app/test-pmd/testpmd.c | 20 +++++++++++++++++---
app/test-pmd/testpmd.h | 2 ++
doc/guides/testpmd_app_ug/run_app.rst | 7 +++++++
5 files changed, 45 insertions(+), 4 deletions(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index c0616dcd2fd..f8fb8961cae 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -2713,7 +2713,12 @@ rxtx_config_display(void)
printf(" RX threshold registers: pthresh=%d hthresh=%d "
" wthresh=%d\n",
pthresh_tmp, hthresh_tmp, wthresh_tmp);
- printf(" RX Offloads=0x%"PRIx64"\n", offloads_tmp);
+ printf(" RX Offloads=0x%"PRIx64, offloads_tmp);
+ if (rx_conf->share_group > 0)
+ printf(" share_group=%u share_qid=%u",
+ rx_conf->share_group,
+ rx_conf->share_qid);
+ printf("\n");
}
/* per tx queue config only for first queue to be less verbose */
diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index 3f94a82e321..30dae326310 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -167,6 +167,7 @@ usage(char* progname)
printf(" --tx-ip=src,dst: IP addresses in Tx-only mode\n");
printf(" --tx-udp=src[,dst]: UDP ports in Tx-only mode\n");
printf(" --eth-link-speed: force link speed.\n");
+ printf(" --rxq-share: number of ports per shared rxq groups, defaults to MAX(1 group)\n");
printf(" --disable-link-check: disable check on link status when "
"starting/stopping ports.\n");
printf(" --disable-device-start: do not automatically start port\n");
@@ -607,6 +608,7 @@ launch_args_parse(int argc, char** argv)
{ "rxpkts", 1, 0, 0 },
{ "txpkts", 1, 0, 0 },
{ "txonly-multi-flow", 0, 0, 0 },
+ { "rxq-share", 2, 0, 0 },
{ "eth-link-speed", 1, 0, 0 },
{ "disable-link-check", 0, 0, 0 },
{ "disable-device-start", 0, 0, 0 },
@@ -1271,6 +1273,17 @@ launch_args_parse(int argc, char** argv)
}
if (!strcmp(lgopts[opt_idx].name, "txonly-multi-flow"))
txonly_multi_flow = 1;
+ if (!strcmp(lgopts[opt_idx].name, "rxq-share")) {
+ if (optarg == NULL) {
+ rxq_share = UINT32_MAX;
+ } else {
+ n = atoi(optarg);
+ if (n >= 0)
+ rxq_share = (uint32_t)n;
+ else
+ rte_exit(EXIT_FAILURE, "rxq-share must be >= 0\n");
+ }
+ }
if (!strcmp(lgopts[opt_idx].name, "no-flush-rx"))
no_flush_rx = 1;
if (!strcmp(lgopts[opt_idx].name, "eth-link-speed")) {
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 97ae52e17ec..123142ed110 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -498,6 +498,11 @@ uint8_t record_core_cycles;
*/
uint8_t record_burst_stats;
+/*
+ * Number of ports per shared Rx queue group, 0 disable.
+ */
+uint32_t rxq_share;
+
unsigned int num_sockets = 0;
unsigned int socket_ids[RTE_MAX_NUMA_NODES];
@@ -3393,14 +3398,23 @@ dev_event_callback(const char *device_name, enum rte_dev_event_type type,
}
static void
-rxtx_port_config(struct rte_port *port)
+rxtx_port_config(portid_t pid)
{
uint16_t qid;
uint64_t offloads;
+ struct rte_port *port = &ports[pid];
for (qid = 0; qid < nb_rxq; qid++) {
offloads = port->rx_conf[qid].offloads;
port->rx_conf[qid] = port->dev_info.default_rxconf;
+
+ if (rxq_share > 0 &&
+ (port->dev_info.dev_capa & RTE_ETH_DEV_CAPA_RXQ_SHARE)) {
+ /* Non-zero share group to enable RxQ share. */
+ port->rx_conf[qid].share_group = pid / rxq_share + 1;
+ port->rx_conf[qid].share_qid = qid; /* Equal mapping. */
+ }
+
if (offloads != 0)
port->rx_conf[qid].offloads = offloads;
@@ -3558,7 +3572,7 @@ init_port_config(void)
port->dev_conf.rxmode.mq_mode = ETH_MQ_RX_NONE;
}
- rxtx_port_config(port);
+ rxtx_port_config(pid);
ret = eth_macaddr_get_print_err(pid, &port->eth_addr);
if (ret != 0)
@@ -3772,7 +3786,7 @@ init_port_dcb_config(portid_t pid,
memcpy(&rte_port->dev_conf, &port_conf, sizeof(struct rte_eth_conf));
- rxtx_port_config(rte_port);
+ rxtx_port_config(pid);
/* VLAN filter */
rte_port->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_VLAN_FILTER;
for (i = 0; i < RTE_DIM(vlan_tags); i++)
diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index 5863b2f43f3..3dfaaad94c0 100644
--- a/app/test-pmd/testpmd.h
+++ b/app/test-pmd/testpmd.h
@@ -477,6 +477,8 @@ extern enum tx_pkt_split tx_pkt_split;
extern uint8_t txonly_multi_flow;
+extern uint32_t rxq_share;
+
extern uint16_t nb_pkt_per_burst;
extern uint16_t nb_pkt_flowgen_clones;
extern int nb_flows_flowgen;
diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst
index 640eadeff73..ff5908dcd50 100644
--- a/doc/guides/testpmd_app_ug/run_app.rst
+++ b/doc/guides/testpmd_app_ug/run_app.rst
@@ -389,6 +389,13 @@ The command line options are:
Generate multiple flows in txonly mode.
+* ``--rxq-share=[X]``
+
+ Create queues in shared Rx queue mode if device supports.
+ Group number grows per X ports. X defaults to MAX, implies all ports
+ join share group 1. Forwarding engine "shared-rxq" should be used
+ which Rx only and update stream statistics correctly.
+
* ``--eth-link-speed``
Set a forced link speed to the ethernet port::
--
2.33.0