From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A610EA0C43; Mon, 18 Oct 2021 19:25:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A90F40142; Mon, 18 Oct 2021 19:25:21 +0200 (CEST) Received: from AZHDRRW-EX02.NVIDIA.COM (azhdrrw-ex02.nvidia.com [20.64.145.131]) by mails.dpdk.org (Postfix) with ESMTP id 785BD40141; Mon, 18 Oct 2021 19:25:19 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by mxs.oss.nvidia.com (10.13.234.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.858.15; Mon, 18 Oct 2021 10:25:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dZdMjBT9gOlI8Y5iLUlWkNftq+CoQ5nnAG5jGXuPcdYWWK0HiX0TZyp03GLf+vLc7H+u9bTo5ZfQ9omOpV48B1ex4oRTuu9kNRBd+dIrrEKAn1nzCV241/ibg1PgnZXBjyT4mR5fcI7h9vChY/qQCJKnBISSPaB3nc4ZG/gKdXdT4dq1YT4fIEwpNhtd4KGb56jlu7IqRJQ5ZLBpZgB0pYdgoynsJQ7bjF7e7hjVL7hSczflojtpYogVHtiGpujCfoLMW2TJm0zbqp2qrOH8rzewxFMu+DDnci2gvQU1fHi8T37/cORGemwjg8uGlkSbNEqgUv8fq1BX8RwZ4Alv0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OEnfeRAPcY09GHX3N2lJcqQ245tEZ0OAoK0kWSX7h7w=; b=IBnqjCZbOaZr+R4k/3wJPGgJHTHAYddih3BAHBkEGCCKfcMGpx5Bj8RDgNB0/FMDyxv0ya52PliVHOp/C5Kcb1oEX2W8uvsOWqxemC0zDZxQSJfok1FkwIrlssc3HVdYkaC+LFQ/Srz7585Sr1EgqfhR+kDhEB8+NY95HtKTikvgVmVpPKKeiv4mDxoqZXKT9qpwHZ4TdCmYtM6nmw6VoWayWzZVdifSMMTlrhb37uRy6T2U06BWBndDNah6f4KKoD6gdwAZk2e9L6bxz/dR1wRonEb3D3hpL2iXMno7Ftt4FDPhstR48yQ+oufqFU8KLSpO+ZJ8NCEyrLDhCmd9hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OEnfeRAPcY09GHX3N2lJcqQ245tEZ0OAoK0kWSX7h7w=; b=mtwKXlWc7R8PWsAMn/zZC8npl5vwhOowI9YdbSKMIRbezvX61EK47IFppAweI2HClrDykk+472/EnK/nuMmkxGo0gD2VtKWkM2WwtcM6VwJG1GudHXw7f+a0GfO6zmHhYuoSr1CtSD1Edo+Mv6oyN8Q/+y0EGYddOTFiQ51nEugV3obAerPNZRljgQjFgAdEUTIvB0YZN+ZFHzP26SCdjXiOrxZbvSJT56+0eZWZwq/X+t5INFdDk2C1IWIq5VyQDVAxklx2VH5h0iEtd2EiFUtBucQEkBu6F9dkYrjc4fmrnUiVOd+sGSLnneOSzrKC+Z6TL6V0sYQQnYYSlYIPzA== Received: from MWHPR20CA0010.namprd20.prod.outlook.com (2603:10b6:300:13d::20) by SA0PR12MB4557.namprd12.prod.outlook.com (2603:10b6:806:9d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Mon, 18 Oct 2021 17:25:17 +0000 Received: from CO1NAM11FT012.eop-nam11.prod.protection.outlook.com (2603:10b6:300:13d:cafe::e8) by MWHPR20CA0010.outlook.office365.com (2603:10b6:300:13d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend Transport; Mon, 18 Oct 2021 17:25:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT012.mail.protection.outlook.com (10.13.175.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4608.15 via Frontend Transport; Mon, 18 Oct 2021 17:25:13 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 18 Oct 2021 17:25:10 +0000 From: Dmitry Kozlyuk To: CC: Michael Baum , , Matan Azrad , Viacheslav Ovsiienko Date: Mon, 18 Oct 2021 20:24:56 +0300 Message-ID: <20211018172456.3335320-1-dkozlyuk@nvidia.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 22352fc7-f9b4-49c2-6fb2-08d9925c3f1b X-MS-TrafficTypeDiagnostic: SA0PR12MB4557: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1060; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Gr05cbi5fqLCvLy/6PanZFU6m7tYxL/mfzOSPVUbeenr+TpD6+GTKAHYoG0RbrKbYpguFTddMiuHBppgK9aVhvJjBjcAvsULtoG/ViPtYOedkKXYKSGZ5EmNOAaT4JUZyBFVjRNvjEcWOoPPH2SU4wwHm9KFCwkol5q+Jd8iCPww9sHTt9F1kcVr1xDhHFfhYLW+ccRWujuh4mZpP4Z5vj9F7G9dVv9iD78y1nFNrE4ph8fuSxmLTXcEDtS9TinrOGZxwYEJWiw8s2CksP1U9XHhOSXWqW5onh4Aj8tq9suh93wuaoZx9eu9K6ubtsdNZ+r1DQ3kXvwD03V8nAdwCToHwFgqH+EotZx7J6wB5cjo2hHVnfBq72s0Sdotb/jWF0ermYCSfpcwkhZevHXit2W3iFTmyxrNeDvEtg8pcAx1VCJ6wypLdc+XZ13GiGlVzGt3tuFgqEEpgKCxRnD4CkK0oPIefKOmd2PNhT3Hjt7pBugr1fG4SEtWJrVaapjSTw+1e7ufvHrMLOMNqHqYURLNRlKcWR1SuOqC8QRc44sSTizeOfllIjDzaj06S6N3Rnt4dAyUSDjwhxeUgDSGB4WVzk5aYsgzWLUWx4YWBzrJjjXat/GyCxRWZimOki2AJWC43t6qN85+JAwXTY/cDb40xBdWDmp1TnjOnT3+2HJ73eeU8dkCd9U6gBc+Llt4fc1C99LGUgdua11wCase2Q== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(5660300002)(336012)(70586007)(2616005)(426003)(6286002)(82310400003)(316002)(55016002)(107886003)(26005)(2906002)(508600001)(6916009)(8676002)(6666004)(16526019)(36860700001)(47076005)(70206006)(7636003)(54906003)(356005)(4326008)(450100002)(36756003)(186003)(7696005)(1076003)(86362001)(8936002)(83380400001); DIR:OUT; SFP:1101; X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 17:25:13.7938 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 22352fc7-f9b4-49c2-6fb2-08d9925c3f1b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT012.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4557 Subject: [dpdk-dev] [PATCH] net/mlx5: fix RxQ resource cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" mlx5_rxq_start() allocates rxq_ctrl->obj and frees it on failure, but did not set it to NULL. Later mlx5_rxq_release() could not recognize this object is already freed and attempted to release its resources, resulting in a crash: Configuring Port 0 (socket 0) mlx5_common: Failed to create RQ using DevX mlx5_common: Can't create DevX RQ object. mlx5_net: Port 0 Rx queue 0 RQ creation failure. Segmentation fault Set rxq_ctrl->obj to NULL after it is freed to skip resource release. Fixes: 1260a87b2889 ("net/mlx5: share Rx control code") Cc: Michael Baum Cc: stable@dpdk.org Signed-off-by: Dmitry Kozlyuk Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_trigger.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c index 54173bfacb..0ecdd776fc 100644 --- a/drivers/net/mlx5/mlx5_trigger.c +++ b/drivers/net/mlx5/mlx5_trigger.c @@ -182,6 +182,7 @@ mlx5_rxq_start(struct rte_eth_dev *dev) ret = priv->obj_ops.rxq_obj_new(dev, i); if (ret) { mlx5_free(rxq_ctrl->obj); + rxq_ctrl->obj = NULL; goto error; } DRV_LOG(DEBUG, "Port %u rxq %u updated with %p.", -- 2.25.1