From: William Tu <u9012063@gmail.com>
To: dev@dpdk.org
Cc: Haiyue Wang <haiyue.wang@intel.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Subject: [dpdk-dev] [PATCH v4] net/e1000: build on Windows
Date: Tue, 19 Oct 2021 20:47:49 -0700 [thread overview]
Message-ID: <20211020034749.1285-1-u9012063@gmail.com> (raw)
In-Reply-To: <20211009163103.297-1-u9012063@gmail.com>
This patch enables building the e1000 driver for Windows.
I tested using two Windows VM on top of VMware Fusion,
creating two e1000 devices with device ID 0x10D3 (8274L),
verifying rx/tx works correctly using dpdk-testpmd.exe
rxonly and txonly mode.
Signed-off-by: William Tu <u9012063@gmail.com>
Acked-by: Haiyue Wang <haiyue.wang@intel.com>
Acked-by: Pallavi Kadam <pallavi.kadam@intel.com>
Tested-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Tested-by: Pallavi Kadam <pallavi.kadam@intel.com>
---
v4:
* remove the documentation about Windows setup.
this is already mention in doc/windows_gsg
v3:
* Add acked and tested by tags
* @Dmitry: I think it's better keep the doc for
people to reference NetUIO setup.
* I will send corresponding netuio device id patch
to dpdk-kmods
* A short demo:
https://youtu.be/UZ9hm2jQa2Y
---
doc/guides/nics/features/e1000.ini | 1 +
doc/guides/rel_notes/release_21_11.rst | 4 ++++
drivers/net/e1000/base/e1000_osdep.h | 2 ++
drivers/net/e1000/e1000_ethdev.h | 1 +
drivers/net/e1000/meson.build | 6 ------
5 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/doc/guides/nics/features/e1000.ini b/doc/guides/nics/features/e1000.ini
index 5af6040e375b..b33f5a86e2e9 100644
--- a/doc/guides/nics/features/e1000.ini
+++ b/doc/guides/nics/features/e1000.ini
@@ -27,6 +27,7 @@ Tx descriptor status = Y
Basic stats = Y
FreeBSD = Y
Linux = Y
+Windows = Y
x86-32 = Y
x86-64 = Y
diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst
index 3362c52a738c..876b5f1886bb 100644
--- a/doc/guides/rel_notes/release_21_11.rst
+++ b/doc/guides/rel_notes/release_21_11.rst
@@ -91,6 +91,10 @@ New Features
* Implement support for tunnel offload.
* Updated HWRM API to version 1.10.2.44
+* **Updated Intel e1000 emulated driver.**
+
+ * Added Intel e1000 support on Windows.
+
* **Updated Intel iavf driver.**
* Added Intel iavf support on Windows.
diff --git a/drivers/net/e1000/base/e1000_osdep.h b/drivers/net/e1000/base/e1000_osdep.h
index 94a49f340446..cd90228cef59 100644
--- a/drivers/net/e1000/base/e1000_osdep.h
+++ b/drivers/net/e1000/base/e1000_osdep.h
@@ -34,7 +34,9 @@
#define DEBUGOUT6(S, args...) DEBUGOUT(S, ##args)
#define DEBUGOUT7(S, args...) DEBUGOUT(S, ##args)
+#ifndef UNREFERENCED_PARAMETER
#define UNREFERENCED_PARAMETER(_p)
+#endif
#define UNREFERENCED_1PARAMETER(_p)
#define UNREFERENCED_2PARAMETER(_p, _q)
#define UNREFERENCED_3PARAMETER(_p, _q, _r)
diff --git a/drivers/net/e1000/e1000_ethdev.h b/drivers/net/e1000/e1000_ethdev.h
index 8e10e2777e64..bf0e902991a7 100644
--- a/drivers/net/e1000/e1000_ethdev.h
+++ b/drivers/net/e1000/e1000_ethdev.h
@@ -6,6 +6,7 @@
#define _E1000_ETHDEV_H_
#include <stdint.h>
+#include <sys/queue.h>
#include <rte_flow.h>
#include <rte_time.h>
diff --git a/drivers/net/e1000/meson.build b/drivers/net/e1000/meson.build
index c5e48c6bc7fc..296ec25f2ce7 100644
--- a/drivers/net/e1000/meson.build
+++ b/drivers/net/e1000/meson.build
@@ -1,12 +1,6 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017 Intel Corporation
-if is_windows
- build = false
- reason = 'not supported on Windows'
- subdir_done()
-endif
-
subdir('base')
objs = [base_objs]
--
2.33.0.windows.2
next prev parent reply other threads:[~2021-10-20 3:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 20:24 [dpdk-dev] [PATCH] " William Tu
2021-10-08 6:54 ` David Marchand
2021-10-08 6:55 ` David Marchand
2021-10-08 12:20 ` William Tu
2021-10-08 12:24 ` David Marchand
2021-10-08 13:53 ` [dpdk-dev] [PATCH v2] " William Tu
2021-10-08 16:08 ` Wang, Haiyue
2021-10-08 21:12 ` Kadam, Pallavi
2021-10-08 20:35 ` Dmitry Kozlyuk
2021-10-08 21:41 ` William Tu
2021-10-09 16:37 ` William Tu
2021-10-09 0:02 ` Kadam, Pallavi
2021-10-09 0:14 ` William Tu
2021-10-09 18:40 ` Kadam, Pallavi
2021-10-09 16:31 ` [dpdk-dev] [PATCH v3] " William Tu
2021-10-09 17:28 ` Dmitry Kozlyuk
2021-10-10 10:56 ` Wang, Haiyue
2021-10-19 19:05 ` William Tu
2021-10-19 19:12 ` Thomas Monjalon
2021-10-20 3:47 ` William Tu [this message]
2021-10-21 2:56 ` [dpdk-dev] [PATCH v4] " Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211020034749.1285-1-u9012063@gmail.com \
--to=u9012063@gmail.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=haiyue.wang@intel.com \
--cc=pallavi.kadam@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).