From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E340DA0C45; Wed, 20 Oct 2021 09:32:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37B4341175; Wed, 20 Oct 2021 09:32:28 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2083.outbound.protection.outlook.com [40.107.212.83]) by mails.dpdk.org (Postfix) with ESMTP id 770D440E6E for ; Wed, 20 Oct 2021 09:32:19 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B0JBEv6TbvrPj61JnDInKvHh8usyCIGiyzHKCvUFh1chPKZek3gufbAKTUG0pD4pSN7zCOQ42uZhPVUvc9Rk+O8/ABKIP36FKKABIaJJ8Sm9hBfbk3jtEIV2ulzFbU+zI8jyJacjg20Y1+dB0diJaGYdtl0RpYINOatFIxCpWYUl9JaZBgWchnOeCi3zP77u1UvmjezvTePaKQvmvTtt7tpTFPiHjPKvruXtoF4Nw24gUyfHBqxqzhwsdWm9r+fpRpwtZPTCvx22c5r19Qw65MOiV5z8/is1bdY74bwPbEdlk0kexDGIrDdbF6uO+Lsm/qw+3exwiSnBDhnudGh1aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4KAr2LwsyxrUUvrTws8k1F5IP+hGZvUFWm83+R5viwk=; b=FNRR6In54HCAgnNJMEYj4IIO4sH0bTkNystDQ+59hu7GaLSRGs8Fm+5Q9niGiDgZjAXYdRvpjyPrQykB8nV0NWfoldxAxJAkbXq2wuWtiNh5AYFPNYxpTYpzlNZOoROXokiED5Hrz1WqZkDPbQ/CmOsIGl7dZCeZNIwUJDmLByj6CIBE+OB4NTciMP4MkTb1aX8fwrkEf8TSCyRgCTYHqPbPE2+fJuPhUlAQmINFZS1wEM3yEmavkMz7kRXTquTVZdo0P9RmC6+0dTQ2FVM4alKhnzVm7c9Ne1YGLuuFqrQW12O2sGiEIP0riGWV+ourl7vDPTZpR7nlFKvQqAp8kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4KAr2LwsyxrUUvrTws8k1F5IP+hGZvUFWm83+R5viwk=; b=arJU0/bGW+P3Xzai6loQki/uNzjBPrxR84oq5UCH6wiE8OUS/JGKmKKhTTWMt4E9pe637GoXR3cI9FaxKvFh/SbY1cQusc4+d7ITUpdXpnBPkTZrdA3leVX/IWYHxQNp5CZ+wrNGn7/yDO9yK3qPN1QOz4VYhn11RIUmRPhZXuJP4BtOKNF2Voz6qIlXpFtXmrpV+G0zwMe98k7NubqCFdEkpiZJ0NTZED4i2VVdu2ekY7+V/ugh1eEdi3fp51SiHSJHLfJ39/D6LSouyeQWQnHoBCMv04KdvnmAuMwfHB8CZ3CslERf4dkS/pPpmEb3P75ATyXPo1D2d17sedTOjQ== Received: from DM6PR06CA0001.namprd06.prod.outlook.com (2603:10b6:5:120::14) by SN6PR12MB2623.namprd12.prod.outlook.com (2603:10b6:805:6f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Wed, 20 Oct 2021 07:32:18 +0000 Received: from DM6NAM11FT008.eop-nam11.prod.protection.outlook.com (2603:10b6:5:120:cafe::24) by DM6PR06CA0001.outlook.office365.com (2603:10b6:5:120::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.15 via Frontend Transport; Wed, 20 Oct 2021 07:32:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT008.mail.protection.outlook.com (10.13.172.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4628.16 via Frontend Transport; Wed, 20 Oct 2021 07:32:17 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 20 Oct 2021 07:32:13 +0000 From: Xueming Li To: , Gaetan Rivet CC: , Thomas Monjalon , "Lior Margalit" Date: Wed, 20 Oct 2021 15:31:50 +0800 Message-ID: <20211020073151.2374674-3-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211020073151.2374674-1-xuemingl@nvidia.com> References: <20211005155435.279043-1-xuemingl@nvidia.com> <20211020073151.2374674-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 597dbb51-b062-4432-f8ac-08d9939bbe96 X-MS-TrafficTypeDiagnostic: SN6PR12MB2623: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1443; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8d+HynTv/+//Mo4TdU0BTuKTWHOb0aqfebDMyiKvZtBNyFriZOaYmvSHO5qRQfQClfQqubhOouZrZvHQyYu1gGzM9zea/L1o3blWhxQAgR0tlLI5OZMJdqhiCSUdMjTCu2A2lX8wAJqvUITedhZmYIPaqAMz6QQHi5SzNHgStn9eR0VynKxCcncwr2ElsK610shPlguurk4m1NR4OsVlaCwf4K3hw05zFWY+M38tcIi1T3dM1ftCyIU8OAZEP7k3tZaQDQxY+j5mryjj02OxAL7LbN421IjDHTvD1VLzm8w4i1XWAxHU8fn11Bsn0UrSZ/fJD246jv5hwYQZ70lwhg37WlBtHPWkC5l3XgLzB3S7rDMfkdtydeVVMBznVQHgS+JNN9b8jsLoinL1FwFUKdJrBSq4dRr+c4FX1AOeCapNbJ1vlv6CgavSKumtM9iNCIMSjuziHKTFJuEElFkGkwj3n0qoxGWLlWlFz5H6Jw/+24d+dISOf29BCSelPo1BTPmw8/8iJq/JPfKanhddTNj4aUPFGu4owCxexKIlcBdOZ64+MQ5Skn3F08KqdamhEB181x4xtd0f8jAH1S9wCGh0cxhCzsDA4pCn2pNYp7ABxnrEBmwP9KinJYCI4SjHFrmHQMJaNKZ0cQMd93XEA9K54ynZ+c1PDqtbXKs70EJZrzIZWstLeKKqM48XdeBU6eWHtMfv3yzeY6VTpI6T0g== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(82310400003)(36860700001)(336012)(426003)(186003)(16526019)(6666004)(2616005)(86362001)(70586007)(316002)(83380400001)(6286002)(7696005)(107886003)(8936002)(508600001)(7636003)(54906003)(110136005)(70206006)(4326008)(55016002)(26005)(1076003)(47076005)(8676002)(36756003)(5660300002)(356005)(2906002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 07:32:17.3846 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 597dbb51-b062-4432-f8ac-08d9939bbe96 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT008.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2623 Subject: [dpdk-dev] [PATCH v2 2/3] devargs: make bus key parsing optional X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Global devargs syntax is used as device iteration filter like "class=vdpa", a devargs without bus args is valid from parsing perspective. This patch makes bus args optional. Fixes: d2a66ad79480 ("bus: add device arguments name parsing") Signed-off-by: Xueming Li Reviewed-by: Gaetan Rivet --- drivers/bus/pci/pci_params.c | 8 +++----- lib/eal/common/eal_common_devargs.c | 2 +- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/bus/pci/pci_params.c b/drivers/bus/pci/pci_params.c index 21c2e1d0368..60b424b8297 100644 --- a/drivers/bus/pci/pci_params.c +++ b/drivers/bus/pci/pci_params.c @@ -87,11 +87,10 @@ rte_pci_devargs_parse(struct rte_devargs *da) struct rte_kvargs *kvargs; const char *addr_str; struct rte_pci_addr addr; - int ret; + int ret = 0; - if (da == NULL) + if (da == NULL || da->bus_str == NULL) return 0; - RTE_ASSERT(da->bus_str != NULL); kvargs = rte_kvargs_parse(da->bus_str, NULL); if (kvargs == NULL) { @@ -103,9 +102,8 @@ rte_pci_devargs_parse(struct rte_devargs *da) addr_str = rte_kvargs_get(kvargs, pci_params_keys[RTE_PCI_PARAM_ADDR]); if (addr_str == NULL) { - RTE_LOG(ERR, EAL, "No PCI address specified using '%s=' in: %s\n", + RTE_LOG(DEBUG, EAL, "No PCI address specified using '%s=' in: %s\n", pci_params_keys[RTE_PCI_PARAM_ADDR], da->bus_str); - ret = -ENODEV; goto out; } diff --git a/lib/eal/common/eal_common_devargs.c b/lib/eal/common/eal_common_devargs.c index d673598032d..8c7650cf6c2 100644 --- a/lib/eal/common/eal_common_devargs.c +++ b/lib/eal/common/eal_common_devargs.c @@ -39,7 +39,7 @@ devargs_bus_parse_default(struct rte_devargs *devargs, /* Parse devargs name from bus key-value list. */ name = rte_kvargs_get(bus_args, "name"); if (name == NULL) { - RTE_LOG(INFO, EAL, "devargs name not found: %s\n", + RTE_LOG(DEBUG, EAL, "devargs name not found: %s\n", devargs->data); return 0; } -- 2.33.0