[dpdk-dev] [PATCH] crypto/ipsec_mb: fix ZUC PMD buffer initialisation

[dpdk-dev] [PATCH] crypto/ipsec_mb: fix ZUC PMD buffer initialisation

[Ciara Power]

The buffers used when processing a hash operation in the ZUC PMD should
be initialised to empty before use.
This fixes possible "may be used uninitialised" errors on compilation.

Fixes: e09b92e6474b ("drivers/crypto: move zuc PMD to IPsec-mb framework")
Cc: piotrx.bronowski@intel.com

Signed-off-by: Ciara Power <ciara.power@intel.com>
---
 drivers/crypto/ipsec_mb/pmd_zuc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/crypto/ipsec_mb/pmd_zuc.c b/drivers/crypto/ipsec_mb/pmd_zuc.c
index b542264069..2eae1d1ec7 100644
--- a/drivers/crypto/ipsec_mb/pmd_zuc.c
+++ b/drivers/crypto/ipsec_mb/pmd_zuc.c
@@ -138,11 +138,11 @@ process_zuc_hash_op(struct ipsec_mb_qp *qp, struct rte_crypto_op **ops,
 {
 	unsigned int i;
 	uint8_t processed_ops = 0;
-	uint8_t *src[ZUC_MAX_BURST];
+	uint8_t *src[ZUC_MAX_BURST] = { 0 };
 	uint32_t *dst[ZUC_MAX_BURST];
-	uint32_t length_in_bits[ZUC_MAX_BURST];
-	uint8_t *iv[ZUC_MAX_BURST];
-	const void *hash_keys[ZUC_MAX_BURST];
+	uint32_t length_in_bits[ZUC_MAX_BURST] = { 0 };
+	uint8_t *iv[ZUC_MAX_BURST] = { 0 };
+	const void *hash_keys[ZUC_MAX_BURST] = { 0 };
 	struct zuc_session *sess;
 	struct zuc_qp_data *qp_data = ipsec_mb_get_qp_private_data(qp);
 
-- 
2.25.1

Re: [dpdk-dev] [PATCH] crypto/ipsec_mb: fix ZUC PMD buffer initialisation

[Zhang, Roy Fan]

> -----Original Message-----
> From: Power, Ciara <ciara.power@intel.com>
> Sent: Wednesday, October 20, 2021 12:06 PM
> To: dev@dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; gakhil@marvell.com; De Lara
> Guarch, Pablo <pablo.de.lara.guarch@intel.com>; thomas@monjalon.net;
> Power, Ciara <ciara.power@intel.com>; Bronowski, PiotrX
> <piotrx.bronowski@intel.com>
> Subject: [PATCH] crypto/ipsec_mb: fix ZUC PMD buffer initialisation
> 
> The buffers used when processing a hash operation in the ZUC PMD should
> be initialised to empty before use.
> This fixes possible "may be used uninitialised" errors on compilation.
> 
> Fixes: e09b92e6474b ("drivers/crypto: move zuc PMD to IPsec-mb
> framework")
> Cc: piotrx.bronowski@intel.com
> 
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> ---
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>

Re: [dpdk-dev] [EXT] [PATCH] crypto/ipsec_mb: fix ZUC PMD buffer initialisation

[Akhil Goyal]

> The buffers used when processing a hash operation in the ZUC PMD should
> be initialised to empty before use.
> This fixes possible "may be used uninitialised" errors on compilation.
> 
> Fixes: e09b92e6474b ("drivers/crypto: move zuc PMD to IPsec-mb
> framework")
> Cc: piotrx.bronowski@intel.com
> 
> Signed-off-by: Ciara Power <ciara.power@intel.com>
Squashed to the original patch.

Thanks.