From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5D94A0C43; Wed, 20 Oct 2021 17:48:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 31504411FA; Wed, 20 Oct 2021 17:48:10 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2050.outbound.protection.outlook.com [40.107.236.50]) by mails.dpdk.org (Postfix) with ESMTP id DEC7541247 for ; Wed, 20 Oct 2021 17:48:05 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OnSd9C1sUJ4zqIUzz+aTdxCjs7VAMtDAmZBZPpuyUz8psD4KeJpnkBMTXpzMfzef2zdSQxK8ypAazWgxM+DIT3uQPqVrmTrGOh+ZA0UVmZEBHZoeBAJSpvKuEsGW6F8Nlx42rhWJkMQvOCRSQmuTAFqwIuHxJNK8QlLeAZ25GIzSLolWlnP2xOn77CebIOskZY74cljrVhOPrWLBWPP2CtGhxvDIJmDjrmFKg0m+kmCrfUqpKtvx9KrDNmt3NUb/lk8TfF9qOEzE2nio/tkUrqaTdgtnCMA5KfR3xv5CvdVE4B0L7EcZ5ZPWfYvRSyrLCRm6sXEtWFdxoHu5W7Iotw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4KAr2LwsyxrUUvrTws8k1F5IP+hGZvUFWm83+R5viwk=; b=UBqMJ/gEawu6iP7ibXeOBdgpsPRlNf7COp7nAtfOjwaB0SbWS3wWhyDk05GoydE5ibpcGUG66M4FO465D+bARvpL67WUSCMRwb1LDGaXUg4TNKObZg4TO4ZqrAuRqhpaG0Hk6muWqFTEMohc833E+qAvNMov3ympuKkqZuIZWp7lijuqf+8ryrQCkbLCLOnW5+vklb31kIC1y4aSpPQtFwjmEdMTXq2jCSFT+W7stop7pG5UuLUpoQ1HO3Tw+HQjMT/MPkjuL7d4JRZ/SQYwdsYn6qu5+WQzeAUSiWniE/SG7uChFtyApSuMypulJbj83waS/SrOttZ8IngRSJqA6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4KAr2LwsyxrUUvrTws8k1F5IP+hGZvUFWm83+R5viwk=; b=KJ9sM7+9EIlZUbl31apNXO/JF4/qFua7A9xAG3jTKBI/nAV9WbaBvCFju4q0LZIntL+yDiJjck17vDF4WmZC0ea+nwpfEOBFZwzUc4tz3b3fKt2VmrUU5MVuu7oT/qBR/MABa+OeL7DM0vJlky+dl8cPTD1g7L1UMnajHnlE+pSvYXN8gAd1D5R3ate1sKxgDBepohYJquxKP49BYQ+xVSh/Ar+J1+Ye+5KObrq6guBc5d606SvwhnAHgWu3Jlx9wDNYZXOlstpsvxz/zJ+NaSdEyQHoNCFl7j1zoakSmQSCL/jpi+IuDPRMndWZxXl88+/tTdSuHmuahr+T2TXC+Q== Received: from MWHPR08CA0050.namprd08.prod.outlook.com (2603:10b6:300:c0::24) by BL0PR12MB5521.namprd12.prod.outlook.com (2603:10b6:208:1c7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.15; Wed, 20 Oct 2021 15:48:03 +0000 Received: from CO1NAM11FT012.eop-nam11.prod.protection.outlook.com (2603:10b6:300:c0:cafe::2d) by MWHPR08CA0050.outlook.office365.com (2603:10b6:300:c0::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend Transport; Wed, 20 Oct 2021 15:48:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT012.mail.protection.outlook.com (10.13.175.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4628.16 via Frontend Transport; Wed, 20 Oct 2021 15:48:02 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 20 Oct 2021 15:47:53 +0000 From: Xueming Li To: , Gaetan Rivet , David Marchand CC: , Thomas Monjalon , "Lior Margalit" Date: Wed, 20 Oct 2021 23:47:38 +0800 Message-ID: <20211020154739.2514499-3-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211020154739.2514499-1-xuemingl@nvidia.com> References: <20211005123012.264727-1-xuemingl@nvidia.com> <20211020154739.2514499-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 448b1113-b565-4f88-a099-08d993e1007d X-MS-TrafficTypeDiagnostic: BL0PR12MB5521: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1443; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jGQCQQ+2dztdhlbtvcf+7VYKx2zQq9BqUhcLm8ZiFkuCGZKVfq/1N8BjroaWMMXXaKrNNW88SUyk631xciE5x2SV4EduGhzWN3AFtYwSd1o+l97xBut+kiJF+oDV+o67HCrBakBCwKy0pawoWOg+vrep3TmIMilRkAPCImZ5YIQ5o4cDrMwSJTyADafY6DqB/broFIGfuZxktYd+j3EMYOEB71io3HJlRps+0n3wpr8nEEUdW7YUe3G2qgFEKi1jEaWg4pykswY2uS3b4OOolGs/Xu2xMAoYieDD2FR35Wu7foJRawJOI605M2XwQmI++osCdDb+umI2s8xgWsx7yATwTho7x+h+7NaN9bkkQjIjl2+sU5OqJnnymMLxnY6cJaXhNZeoxorZNMtM4Nrp8KJ7o4fvkyWF4En7CK7sfjsytUnE8/VbIe/2ao5pqVIscG1BeB/ALzawYaRbjnFACqv08eOG8ZAyDydHyYXVWbX70zrHxu8QXoCICvtCRg2RiiBgIfoDzx88qB0HoHyQOi/yrS6/0AM4flHm91uumQ0ZInsBbBSswl130qj1jqGZp2BXs9WpZQc/MUgnNcrF3U5+zTmn2sGPAsfovu9wWL+kiKI9SDzrC2H3idbGekNTdAgTWHSk9/Q4BH7WNlaZlArXz+hJDOzswZ1jyZgxqp3ZJRxcumqpefCNiX9iUpS7DCzp3Qs31MG7Au2yD5oAug== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(356005)(82310400003)(8676002)(2906002)(70586007)(70206006)(83380400001)(508600001)(7636003)(2616005)(1076003)(5660300002)(426003)(6286002)(6666004)(26005)(107886003)(36756003)(336012)(7696005)(36860700001)(47076005)(186003)(54906003)(16526019)(36906005)(316002)(8936002)(4326008)(55016002)(86362001)(110136005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 15:48:02.9866 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 448b1113-b565-4f88-a099-08d993e1007d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT012.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB5521 Subject: [dpdk-dev] [PATCH v5 2/3] devargs: make bus key parsing optional X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Global devargs syntax is used as device iteration filter like "class=vdpa", a devargs without bus args is valid from parsing perspective. This patch makes bus args optional. Fixes: d2a66ad79480 ("bus: add device arguments name parsing") Signed-off-by: Xueming Li Reviewed-by: Gaetan Rivet --- drivers/bus/pci/pci_params.c | 8 +++----- lib/eal/common/eal_common_devargs.c | 2 +- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/bus/pci/pci_params.c b/drivers/bus/pci/pci_params.c index 21c2e1d0368..60b424b8297 100644 --- a/drivers/bus/pci/pci_params.c +++ b/drivers/bus/pci/pci_params.c @@ -87,11 +87,10 @@ rte_pci_devargs_parse(struct rte_devargs *da) struct rte_kvargs *kvargs; const char *addr_str; struct rte_pci_addr addr; - int ret; + int ret = 0; - if (da == NULL) + if (da == NULL || da->bus_str == NULL) return 0; - RTE_ASSERT(da->bus_str != NULL); kvargs = rte_kvargs_parse(da->bus_str, NULL); if (kvargs == NULL) { @@ -103,9 +102,8 @@ rte_pci_devargs_parse(struct rte_devargs *da) addr_str = rte_kvargs_get(kvargs, pci_params_keys[RTE_PCI_PARAM_ADDR]); if (addr_str == NULL) { - RTE_LOG(ERR, EAL, "No PCI address specified using '%s=' in: %s\n", + RTE_LOG(DEBUG, EAL, "No PCI address specified using '%s=' in: %s\n", pci_params_keys[RTE_PCI_PARAM_ADDR], da->bus_str); - ret = -ENODEV; goto out; } diff --git a/lib/eal/common/eal_common_devargs.c b/lib/eal/common/eal_common_devargs.c index d673598032d..8c7650cf6c2 100644 --- a/lib/eal/common/eal_common_devargs.c +++ b/lib/eal/common/eal_common_devargs.c @@ -39,7 +39,7 @@ devargs_bus_parse_default(struct rte_devargs *devargs, /* Parse devargs name from bus key-value list. */ name = rte_kvargs_get(bus_args, "name"); if (name == NULL) { - RTE_LOG(INFO, EAL, "devargs name not found: %s\n", + RTE_LOG(DEBUG, EAL, "devargs name not found: %s\n", devargs->data); return 0; } -- 2.33.0