* [dpdk-dev] [PATCH] eventdev: fix free of adapters storage
@ 2021-10-20 20:20 Erik Gabriel Carrillo
2021-10-21 7:34 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
0 siblings, 1 reply; 3+ messages in thread
From: Erik Gabriel Carrillo @ 2021-10-20 20:20 UTC (permalink / raw)
To: jerinj, pbhagavatula; +Cc: dev
Fix a typo that can cause the hugepage memory that backs the adapters
array to be freed unexpectedly.
Fixes: e9caa6a09a "eventdev: move timer adapters memory to hugepage")
Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
---
lib/eventdev/rte_event_timer_adapter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/eventdev/rte_event_timer_adapter.c b/lib/eventdev/rte_event_timer_adapter.c
index 86b6c3fc6f..0e21b7c475 100644
--- a/lib/eventdev/rte_event_timer_adapter.c
+++ b/lib/eventdev/rte_event_timer_adapter.c
@@ -407,7 +407,7 @@ rte_event_timer_adapter_free(struct rte_event_timer_adapter *adapter)
ret = 0;
for (i = 0; i < RTE_EVENT_TIMER_ADAPTER_NUM_MAX; i++)
if (adapters[i].allocated)
- ret = adapter[i].allocated;
+ ret = adapters[i].allocated;
if (!ret) {
rte_free(adapters);
--
2.23.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [EXT] [PATCH] eventdev: fix free of adapters storage
2021-10-20 20:20 [dpdk-dev] [PATCH] eventdev: fix free of adapters storage Erik Gabriel Carrillo
@ 2021-10-21 7:34 ` Pavan Nikhilesh Bhagavatula
2021-10-21 8:43 ` Jerin Jacob
0 siblings, 1 reply; 3+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2021-10-21 7:34 UTC (permalink / raw)
To: Erik Gabriel Carrillo, Jerin Jacob Kollanukkaran; +Cc: dev
>-----Original Message-----
>From: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
>Sent: Thursday, October 21, 2021 1:50 AM
>To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Pavan Nikhilesh
>Bhagavatula <pbhagavatula@marvell.com>
>Cc: dev@dpdk.org
>Subject: [EXT] [PATCH] eventdev: fix free of adapters storage
>
>External Email
>
>----------------------------------------------------------------------
>Fix a typo that can cause the hugepage memory that backs the adapters
>array to be freed unexpectedly.
>
>Fixes: e9caa6a09a "eventdev: move timer adapters memory to
>hugepage")
>
>Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
LGTM, Jerin please squash as the series is not in main branch yet.
Thanks.
Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>---
> lib/eventdev/rte_event_timer_adapter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/lib/eventdev/rte_event_timer_adapter.c
>b/lib/eventdev/rte_event_timer_adapter.c
>index 86b6c3fc6f..0e21b7c475 100644
>--- a/lib/eventdev/rte_event_timer_adapter.c
>+++ b/lib/eventdev/rte_event_timer_adapter.c
>@@ -407,7 +407,7 @@ rte_event_timer_adapter_free(struct
>rte_event_timer_adapter *adapter)
> ret = 0;
> for (i = 0; i < RTE_EVENT_TIMER_ADAPTER_NUM_MAX; i++)
> if (adapters[i].allocated)
>- ret = adapter[i].allocated;
>+ ret = adapters[i].allocated;
>
> if (!ret) {
> rte_free(adapters);
>--
>2.23.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [EXT] [PATCH] eventdev: fix free of adapters storage
2021-10-21 7:34 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
@ 2021-10-21 8:43 ` Jerin Jacob
0 siblings, 0 replies; 3+ messages in thread
From: Jerin Jacob @ 2021-10-21 8:43 UTC (permalink / raw)
To: Pavan Nikhilesh Bhagavatula
Cc: Erik Gabriel Carrillo, Jerin Jacob Kollanukkaran, dev
On Thu, Oct 21, 2021 at 1:05 PM Pavan Nikhilesh Bhagavatula
<pbhagavatula@marvell.com> wrote:
>
>
>
> >-----Original Message-----
> >From: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> >Sent: Thursday, October 21, 2021 1:50 AM
> >To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Pavan Nikhilesh
> >Bhagavatula <pbhagavatula@marvell.com>
> >Cc: dev@dpdk.org
> >Subject: [EXT] [PATCH] eventdev: fix free of adapters storage
> >
> >External Email
> >
> >----------------------------------------------------------------------
> >Fix a typo that can cause the hugepage memory that backs the adapters
> >array to be freed unexpectedly.
> >
> >Fixes: e9caa6a09a "eventdev: move timer adapters memory to
> >hugepage")
> >
> >Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
>
> LGTM, Jerin please squash as the series is not in main branch yet.
Thanks Eric. Squashed the patch in the series in next-event
>
> Thanks.
>
> Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> >---
> > lib/eventdev/rte_event_timer_adapter.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/lib/eventdev/rte_event_timer_adapter.c
> >b/lib/eventdev/rte_event_timer_adapter.c
> >index 86b6c3fc6f..0e21b7c475 100644
> >--- a/lib/eventdev/rte_event_timer_adapter.c
> >+++ b/lib/eventdev/rte_event_timer_adapter.c
> >@@ -407,7 +407,7 @@ rte_event_timer_adapter_free(struct
> >rte_event_timer_adapter *adapter)
> > ret = 0;
> > for (i = 0; i < RTE_EVENT_TIMER_ADAPTER_NUM_MAX; i++)
> > if (adapters[i].allocated)
> >- ret = adapter[i].allocated;
> >+ ret = adapters[i].allocated;
> >
> > if (!ret) {
> > rte_free(adapters);
> >--
> >2.23.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-21 8:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-20 20:20 [dpdk-dev] [PATCH] eventdev: fix free of adapters storage Erik Gabriel Carrillo
2021-10-21 7:34 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2021-10-21 8:43 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).