From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7AA9FA0C43; Wed, 20 Oct 2021 23:42:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0D8D840150; Wed, 20 Oct 2021 23:42:43 +0200 (CEST) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id 1A1BC40142 for ; Wed, 20 Oct 2021 23:42:40 +0200 (CEST) Received: by mail-pl1-f172.google.com with SMTP id y1so17056844plk.10 for ; Wed, 20 Oct 2021 14:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/q8+PH7JUYdM5UAT4vsH7LaBIAejPpMgl6S/8vEpXwQ=; b=dA1ElVt4U/10o8hO1qpuGKPNtVHDxL8WlHB021tSrfpfWlV7bBcE40NfMVE4D351Ws QSc99rN4q8GL908g5gB/jGoRrMXlrZ/GJnwIXRGHYknCafgamrrnPlgyh/Wnk+gGbYLG HY47Jc0y1Cloah+9DJ+RC3F2Wp261bUh28hNBDg6ZEF01fyggVWhwvd7pN0ihkRxMx1O GF+9GsydsHMTifefTkM2UocA07pEirnk9mxIUyfO0xE0W1dwkoO0Jw6zb5DGv1XAFjfq 6+UF7sNFcS90h9blcNXLeh28fGYixERMPcfAd34FFx3EW6NW3YCmswn3lGN9/Bsn2/RH vNFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/q8+PH7JUYdM5UAT4vsH7LaBIAejPpMgl6S/8vEpXwQ=; b=7xk31tp3LFuPMVYDJvxb/jiKEmSn9v+b6eViNoFWnGqTuKIlVAOfYWpVyZmqEaSuv5 8iTy/HMq4saXTFiXevFoy6oT3WrK+e6WWZv1lPB7B3PlP3dAqLI5ORfcImUNbZUxCBqw 2LbLWb5Bbw03qgI8/Gbh0J5NmQTws3llVbYXrsDJs3uezUzvb/6QhQqXStEigckReJbO 5rLrYylQzn9cln/Dt06k56xGzHTf84AqXrg/kd32G+5+hF+prI3OYERAXztG4JlFKbhi IXhPBr3XPWaxDrV4f6DAUI0pjx4aYqgQWI4DXR3bmkSjM9tuYT6HvsO/9toIo9tenmX9 zQIw== X-Gm-Message-State: AOAM5339Gsqg97YWgqNKZrfgtJGq03d+zFyJyAfvEMM/WjA+vziPVh86 zbWzuU28V9MJJlws4WhfY3P6OAJai+G4HQ== X-Google-Smtp-Source: ABdhPJyd0w8D5iaif2KmE4mKsL/NVlIbGGzHRvHMGSet3Fr42TYkSD42wVrOSutx3qrMCDDWnetiNA== X-Received: by 2002:a17:902:ed0b:b0:13f:4318:491a with SMTP id b11-20020a170902ed0b00b0013f4318491amr1568065pld.4.1634766159597; Wed, 20 Oct 2021 14:42:39 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id d20sm3304480pfl.82.2021.10.20.14.42.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Oct 2021 14:42:38 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Wed, 20 Oct 2021 14:42:24 -0700 Message-Id: <20211020214236.71444-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210903004732.109023-1-stephen@networkplumber.org> References: <20210903004732.109023-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v15 00/12] Packet capture framework update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch set is a more complete version of the the enhanced packet capture support described last year. The new capture library and utility are: - faster avoids lots of extra I/O, does bursting, etc. - gives more information (multiple ports, queues, etc) - has a better user interface (same as Wireshark dumpcap) - fixes structural problems with VLAN's and timestamps There are no blocker items. The following are worth noting: * bogus checkpatch warnings - the correct flag to open is O_CREAT - intentionally keeping macro with goto since that was in original code and is clearer - the tempfile name can not be const since it is overwritten by tmpfile() call v15 - fix minor spelling in doc make sure CI tests are rerun after test/bpf fix v14 - fix checkpatch whitespace warning - enhance the pcapng prog guide documentation v13 - integrate feedback in documentation and pcapng library - rebase to align with rte_ether_addr changes v12 - fixes for capture offloaded VLAN tags. look at direction flag and handle QinQ offload. v11 - address review comments for pdump (patch 6) v10: - fix to rte_bpf_dump to handle more instructions make sure all bpf_test cases are decoded v9: - incorporate suggested change to BPF XOR - make autotest for pcapng more complete by reading the resulting file with libpcap v8: - enable BPF tests in autotest - add more BPF test strings - use rte_strscpy to satisfy checkpatch - merge MAINTAINERS (put this in with existing pdump) v7: - add functional tests for pcapng lib - bug fix for error returns in pcapng lib - handle long osname on FreeBSD - resolve almost all checkpatch issues v5: - minor build and checkpatch fixes for RHEL/FreeBSD - disable lib/pdump on Windows. It was not useful before and now pdump depends on bpf. v4: - minor checkpatch fixes. Note: some of the checkpatch warnings are bogus and won't be fixed. - fix build of dumpcap on FreeBSD v3: - introduce packet filters using classic BPF to eBPF converter required small fix to DPDK BPF interpreter - introduce function to decode eBPF instructions - add option to dumpcap to show both classic BPF and eBPF result - drop some un-useful stubs - minor checkpatch warning cleanup v2: fix formatting of packet blocks fix the new packet capture statistics fix crash when primary process exits record start/end time various whitespace/checkpatch warnings Stephen Hemminger (12): lib: pdump is not supported on Windows librte_pcapng: add new library for writing pcapng files bpf: allow self-xor operation bpf: add function to convert classic BPF to DPDK BPF bpf: add function to dump eBPF instructions pdump: support pcapng and filtering app/dumpcap: add new packet capture application test: add test for bpf_convert test: add a test for pcapng library test: enable bpf autotest doc: changes for new pcapng and dumpcap utility MAINTAINERS: add entry for new packet capture features MAINTAINERS | 11 +- app/dumpcap/main.c | 844 ++++++++++++++++++ app/dumpcap/meson.build | 16 + app/meson.build | 1 + app/test/meson.build | 6 + app/test/test_bpf.c | 200 +++++ app/test/test_pcapng.c | 272 ++++++ doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf.in | 1 + .../howto/img/packet_capture_framework.svg | 96 +- doc/guides/howto/packet_capture_framework.rst | 69 +- doc/guides/prog_guide/index.rst | 1 + doc/guides/prog_guide/pcapng_lib.rst | 46 + doc/guides/prog_guide/pdump_lib.rst | 28 +- doc/guides/rel_notes/release_21_11.rst | 10 + doc/guides/tools/dumpcap.rst | 86 ++ doc/guides/tools/index.rst | 1 + lib/bpf/bpf_convert.c | 575 ++++++++++++ lib/bpf/bpf_dump.c | 139 +++ lib/bpf/bpf_validate.c | 9 +- lib/bpf/meson.build | 6 + lib/bpf/rte_bpf.h | 39 + lib/bpf/version.map | 7 + lib/meson.build | 6 +- lib/pcapng/meson.build | 8 + lib/pcapng/pcapng_proto.h | 129 +++ lib/pcapng/rte_pcapng.c | 607 +++++++++++++ lib/pcapng/rte_pcapng.h | 195 ++++ lib/pcapng/version.map | 12 + lib/pdump/meson.build | 2 +- lib/pdump/rte_pdump.c | 432 ++++++--- lib/pdump/rte_pdump.h | 113 ++- lib/pdump/version.map | 8 + 33 files changed, 3757 insertions(+), 219 deletions(-) create mode 100644 app/dumpcap/main.c create mode 100644 app/dumpcap/meson.build create mode 100644 app/test/test_pcapng.c create mode 100644 doc/guides/prog_guide/pcapng_lib.rst create mode 100644 doc/guides/tools/dumpcap.rst create mode 100644 lib/bpf/bpf_convert.c create mode 100644 lib/bpf/bpf_dump.c create mode 100644 lib/pcapng/meson.build create mode 100644 lib/pcapng/pcapng_proto.h create mode 100644 lib/pcapng/rte_pcapng.c create mode 100644 lib/pcapng/rte_pcapng.h create mode 100644 lib/pcapng/version.map -- 2.30.2