From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29A86A0C52; Thu, 21 Oct 2021 17:29:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B3979411FE; Thu, 21 Oct 2021 17:29:16 +0200 (CEST) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mails.dpdk.org (Postfix) with ESMTP id 16B064118E for <dev@dpdk.org>; Thu, 21 Oct 2021 17:29:15 +0200 (CEST) Received: by mail-pj1-f43.google.com with SMTP id na16-20020a17090b4c1000b0019f5bb661f9so843872pjb.0 for <dev@dpdk.org>; Thu, 21 Oct 2021 08:29:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=G/iX937onzyaEMvJweCOTvVStCemAiwRNCZa8Xr/WqE=; b=TXVY9WsAlnjezf4i+czteOTvltcRuG11es1xE9VYhgZojC4Qm1WcDYoX1DZ1atdBw5 u2qifm7dRpi9RqwNvBmCpe4t87IsnPMqn2RvjNjlmL8KKpqHZe/0SP0yfwg/7i7XK5su ZhI7xaiT57Lz9tAdOQvpTpTL1VhExPBpW3zoe5UDHazUxKIJxOz56zXca5YPMoEN0luE MSZ1jA7iSEdq2GUBDQ2vYFIk5QS8cnrFyi6854TZLkkgR4zdTELwgX9sHIOYw+lYIwMG cr+0I4EtjK0fz9KTdsY00zgPMb0A1nGlThlpoZ2PH8K3zpt615LZxg+4ON6rsuLmhFfd /rhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=G/iX937onzyaEMvJweCOTvVStCemAiwRNCZa8Xr/WqE=; b=Q1VbL4N+EzdDpB8hEiVv9a8xA+FH2gfPIskwFYxYJFr8KvMCoEv/2ptTHa760/nmZ+ cYam/9Qiy0f+xvpJVTunkC3JtLVyuuuajvFfU+JXeYTRPMum/nv10m2pqA5sPY0gxauk k7MkJE6DAf/jUANVWvCuRCA8XQgZxbFvzf99b4nITrp4QzuGbq/L6BkzXva7GyzQ0jWr s2H7GXeJwIm240AVIWiYzC1JNjG/fGQqCRwC/Rl1bGXqzE6tzZO8uc08JvJhOeDi79Wp 4Uq0DmWQAF2MaTUjXiJ33frUFMd/opJ+JpsveqoCYOi0aiiI74sR1jmqYu728OETfrfF YjmQ== X-Gm-Message-State: AOAM53323cUzFWNbB1RR4f89Ov3dtWLR16WGruRaLZyfj04hzTSmzr8Q SfTUYhAM7mZF7LbLFQx21jmzsg== X-Google-Smtp-Source: ABdhPJwvxjps97zKvtgJku6u3i+BfM0JftKLyni6Wzpe9/w6MkovM2zPT7Wiynm/Sh4VeQEueXezbQ== X-Received: by 2002:a17:90b:188b:: with SMTP id mn11mr7567451pjb.170.1634830155042; Thu, 21 Oct 2021 08:29:15 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id x17sm3922977pfh.153.2021.10.21.08.29.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Oct 2021 08:29:14 -0700 (PDT) Date: Thu, 21 Oct 2021 08:29:11 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: "Kinsella, Ray" <mdr@ashroe.eu> Cc: dev@dpdk.org, Reshma Pattan <reshma.pattan@intel.com> Message-ID: <20211021082911.37133f62@hermes.local> In-Reply-To: <d18ecb9c-270e-5b63-4514-71b81a11b42c@ashroe.eu> References: <20210903004732.109023-1-stephen@networkplumber.org> <20211020214236.71444-1-stephen@networkplumber.org> <20211020214236.71444-3-stephen@networkplumber.org> <d18ecb9c-270e-5b63-4514-71b81a11b42c@ashroe.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v15 02/12] librte_pcapng: add new library for writing pcapng files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Thu, 21 Oct 2021 15:14:38 +0100 "Kinsella, Ray" <mdr@ashroe.eu> wrote: > On 20/10/2021 22:42, Stephen Hemminger wrote: > > This is utility library for writing pcapng format files > > used by Wireshark family of utilities. Older tcpdump > > also knows how to read (but not write) this format. > > > > See > > https://github.com/pcapng/pcapng/ > > > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > > Acked-by: Reshma Pattan <reshma.pattan@intel.com> > > --- > > lib/meson.build | 1 + > > lib/pcapng/meson.build | 8 + > > lib/pcapng/pcapng_proto.h | 129 ++++++++ > > lib/pcapng/rte_pcapng.c | 607 ++++++++++++++++++++++++++++++++++++++ > > lib/pcapng/rte_pcapng.h | 195 ++++++++++++ > > lib/pcapng/version.map | 12 + > > 6 files changed, 952 insertions(+) > > create mode 100644 lib/pcapng/meson.build > > create mode 100644 lib/pcapng/pcapng_proto.h > > create mode 100644 lib/pcapng/rte_pcapng.c > > create mode 100644 lib/pcapng/rte_pcapng.h > > create mode 100644 lib/pcapng/version.map > > > > Minor niggle, does this need a MAINTAINERS entry? > > Acked-by: Ray Kinsella <mdr@ashroe.eu> It doesn't need its own entry in MAINTAINERS. If you look at the last patch, added that directory under the Packet Capture section.