From: Chengwen Feng <fengchengwen@huawei.com>
To: <dev@dpdk.org>
Cc: <david.marchand@redhat.com>, <mdr@ashroe.eu>,
<conor.walsh@intel.com>, <kevin.laatz@intel.com>,
<bruce.richardson@intel.com>
Subject: [dpdk-dev] [PATCH v2 1/3] dmadev: hide devices array
Date: Thu, 21 Oct 2021 20:59:36 +0800 [thread overview]
Message-ID: <20211021125938.52401-1-fengchengwen@huawei.com> (raw)
In-Reply-To: <20211020065944.19617-1-david.marchand@redhat.com>
From: David Marchand <david.marchand@redhat.com>
No need to expose rte_dma_devices out of the dmadev library.
Existing helpers should be enough, and inlines make use of
rte_dma_fp_objs.
Signed-off-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: Chengwen Feng <fengchengwen@huawei.com>
Tested-by: Conor Walsh <conor.walsh@intel.com>
---
app/test/test_dmadev.c | 5 +++--
lib/dmadev/rte_dmadev.c | 2 +-
lib/dmadev/rte_dmadev_pmd.h | 2 --
lib/dmadev/version.map | 1 -
4 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c
index 1e327bd45f..8b58256afc 100644
--- a/app/test/test_dmadev.c
+++ b/app/test/test_dmadev.c
@@ -747,10 +747,11 @@ test_dmadev_instance(int16_t dev_id)
};
const int vchan = 0;
+ rte_dma_info_get(dev_id, &info);
+
printf("\n### Test dmadev instance %u [%s]\n",
- dev_id, rte_dma_devices[dev_id].data->dev_name);
+ dev_id, info.dev_name);
- rte_dma_info_get(dev_id, &info);
if (info.max_vchans < 1)
ERR_RETURN("Error, no channels available on device id %u\n", dev_id);
diff --git a/lib/dmadev/rte_dmadev.c b/lib/dmadev/rte_dmadev.c
index 182d32aedb..d4b32b2971 100644
--- a/lib/dmadev/rte_dmadev.c
+++ b/lib/dmadev/rte_dmadev.c
@@ -18,7 +18,7 @@
static int16_t dma_devices_max;
struct rte_dma_fp_object *rte_dma_fp_objs;
-struct rte_dma_dev *rte_dma_devices;
+static struct rte_dma_dev *rte_dma_devices;
static struct {
/* Hold the dev_max information of the primary process. This field is
* set by the primary process and is read by the secondary process.
diff --git a/lib/dmadev/rte_dmadev_pmd.h b/lib/dmadev/rte_dmadev_pmd.h
index b97b5bf10b..5316ad5b5f 100644
--- a/lib/dmadev/rte_dmadev_pmd.h
+++ b/lib/dmadev/rte_dmadev_pmd.h
@@ -131,8 +131,6 @@ struct rte_dma_dev {
uint64_t reserved[2]; /**< Reserved for future fields. */
} __rte_cache_aligned;
-extern struct rte_dma_dev *rte_dma_devices;
-
/**
* @internal
* Allocate a new dmadev slot for an DMA device and return the pointer to that
diff --git a/lib/dmadev/version.map b/lib/dmadev/version.map
index ef561acd46..89f7a5b1d3 100644
--- a/lib/dmadev/version.map
+++ b/lib/dmadev/version.map
@@ -30,7 +30,6 @@ EXPERIMENTAL {
INTERNAL {
global:
- rte_dma_devices;
rte_dma_fp_objs;
rte_dma_pmd_allocate;
rte_dma_pmd_release;
--
2.33.0
next prev parent reply other threads:[~2021-10-21 13:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 6:59 [dpdk-dev] [PATCH 1/2] " David Marchand
2021-10-20 6:59 ` [dpdk-dev] [PATCH 2/2] dmadev: remove symbol versioning for inline helpers David Marchand
2021-10-20 9:40 ` Bruce Richardson
2021-10-20 9:47 ` [dpdk-dev] [PATCH 1/2] dmadev: hide devices array fengchengwen
2021-10-20 9:55 ` David Marchand
2021-10-20 10:01 ` Walsh, Conor
2021-10-21 12:59 ` Chengwen Feng [this message]
2021-10-21 12:59 ` [dpdk-dev] [PATCH v2 2/3] app/test: add check for DMA info get API Chengwen Feng
2021-10-21 13:43 ` David Marchand
2021-10-21 14:03 ` Kevin Laatz
2021-10-21 14:26 ` Walsh, Conor
2021-10-21 12:59 ` [dpdk-dev] [PATCH v2 3/3] dmadev: fix compile error in debug mode Chengwen Feng
2021-10-21 13:42 ` David Marchand
2021-10-21 14:04 ` Kevin Laatz
2021-10-21 14:26 ` Walsh, Conor
2021-10-21 20:20 ` David Marchand
2021-10-21 14:03 ` [dpdk-dev] [PATCH v2 1/3] dmadev: hide devices array Kevin Laatz
2021-10-26 6:04 ` Radha Mohan
2021-10-26 6:20 ` fengchengwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211021125938.52401-1-fengchengwen@huawei.com \
--to=fengchengwen@huawei.com \
--cc=bruce.richardson@intel.com \
--cc=conor.walsh@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
--cc=mdr@ashroe.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).