From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED117A0C4E; Thu, 21 Oct 2021 15:04:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 368114122E; Thu, 21 Oct 2021 15:04:21 +0200 (CEST) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id AECF441224 for ; Thu, 21 Oct 2021 15:04:16 +0200 (CEST) Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4HZngy69htz1DHhC; Thu, 21 Oct 2021 21:02:22 +0800 (CST) Received: from dggpeml500024.china.huawei.com (7.185.36.10) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Thu, 21 Oct 2021 21:04:10 +0800 Received: from localhost.localdomain (10.67.165.24) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Thu, 21 Oct 2021 21:04:10 +0800 From: Chengwen Feng To: CC: , , , , Date: Thu, 21 Oct 2021 20:59:36 +0800 Message-ID: <20211021125938.52401-1-fengchengwen@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211020065944.19617-1-david.marchand@redhat.com> References: <20211020065944.19617-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected Subject: [dpdk-dev] [PATCH v2 1/3] dmadev: hide devices array X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: David Marchand No need to expose rte_dma_devices out of the dmadev library. Existing helpers should be enough, and inlines make use of rte_dma_fp_objs. Signed-off-by: David Marchand Reviewed-by: Chengwen Feng Tested-by: Conor Walsh --- app/test/test_dmadev.c | 5 +++-- lib/dmadev/rte_dmadev.c | 2 +- lib/dmadev/rte_dmadev_pmd.h | 2 -- lib/dmadev/version.map | 1 - 4 files changed, 4 insertions(+), 6 deletions(-) diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c index 1e327bd45f..8b58256afc 100644 --- a/app/test/test_dmadev.c +++ b/app/test/test_dmadev.c @@ -747,10 +747,11 @@ test_dmadev_instance(int16_t dev_id) }; const int vchan = 0; + rte_dma_info_get(dev_id, &info); + printf("\n### Test dmadev instance %u [%s]\n", - dev_id, rte_dma_devices[dev_id].data->dev_name); + dev_id, info.dev_name); - rte_dma_info_get(dev_id, &info); if (info.max_vchans < 1) ERR_RETURN("Error, no channels available on device id %u\n", dev_id); diff --git a/lib/dmadev/rte_dmadev.c b/lib/dmadev/rte_dmadev.c index 182d32aedb..d4b32b2971 100644 --- a/lib/dmadev/rte_dmadev.c +++ b/lib/dmadev/rte_dmadev.c @@ -18,7 +18,7 @@ static int16_t dma_devices_max; struct rte_dma_fp_object *rte_dma_fp_objs; -struct rte_dma_dev *rte_dma_devices; +static struct rte_dma_dev *rte_dma_devices; static struct { /* Hold the dev_max information of the primary process. This field is * set by the primary process and is read by the secondary process. diff --git a/lib/dmadev/rte_dmadev_pmd.h b/lib/dmadev/rte_dmadev_pmd.h index b97b5bf10b..5316ad5b5f 100644 --- a/lib/dmadev/rte_dmadev_pmd.h +++ b/lib/dmadev/rte_dmadev_pmd.h @@ -131,8 +131,6 @@ struct rte_dma_dev { uint64_t reserved[2]; /**< Reserved for future fields. */ } __rte_cache_aligned; -extern struct rte_dma_dev *rte_dma_devices; - /** * @internal * Allocate a new dmadev slot for an DMA device and return the pointer to that diff --git a/lib/dmadev/version.map b/lib/dmadev/version.map index ef561acd46..89f7a5b1d3 100644 --- a/lib/dmadev/version.map +++ b/lib/dmadev/version.map @@ -30,7 +30,6 @@ EXPERIMENTAL { INTERNAL { global: - rte_dma_devices; rte_dma_fp_objs; rte_dma_pmd_allocate; rte_dma_pmd_release; -- 2.33.0