DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bing Zhao <bingz@nvidia.com>
To: <thomas@monjalon.net>, <ferruh.yigit@intel.com>,
	<andrew.rybchenko@oktetlabs.ru>
Cc: <dev@dpdk.org>, <konstantin.ananyev@intel.com>
Subject: [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions
Date: Sat, 23 Oct 2021 00:14:06 +0300	[thread overview]
Message-ID: <20211022211407.315068-1-bingz@nvidia.com> (raw)

When stopping a port, the data path Tx and Rx burst functions should
be stopped firstly conventionally. Then the dummy functions are used
to replace the callback functions provided by the PMD.

When the application stops a port without or before stopping the data
path handling. The dummy functions may be invoked heavily and a lot
of logs in these dummy functions will result in a flood.

Debug level log should be enough instead of the error level.

Fixes: c87d435a4d79 ("ethdev: copy fast-path API into separate structure")
Cc: konstantin.ananyev@intel.com

Signed-off-by: Bing Zhao <bingz@nvidia.com>
---
 lib/ethdev/ethdev_private.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/ethdev/ethdev_private.c b/lib/ethdev/ethdev_private.c
index c905c2df6f..fbc3df91ad 100644
--- a/lib/ethdev/ethdev_private.c
+++ b/lib/ethdev/ethdev_private.c
@@ -180,7 +180,7 @@ dummy_eth_rx_burst(__rte_unused void *rxq,
 		__rte_unused struct rte_mbuf **rx_pkts,
 		__rte_unused uint16_t nb_pkts)
 {
-	RTE_ETHDEV_LOG(ERR, "rx_pkt_burst for not ready port\n");
+	RTE_ETHDEV_LOG(DEBUG, "rx_pkt_burst for not ready port\n");
 	rte_errno = ENOTSUP;
 	return 0;
 }
@@ -190,7 +190,7 @@ dummy_eth_tx_burst(__rte_unused void *txq,
 		__rte_unused struct rte_mbuf **tx_pkts,
 		__rte_unused uint16_t nb_pkts)
 {
-	RTE_ETHDEV_LOG(ERR, "tx_pkt_burst for not ready port\n");
+	RTE_ETHDEV_LOG(DEBUG, "tx_pkt_burst for not ready port\n");
 	rte_errno = ENOTSUP;
 	return 0;
 }
-- 
2.27.0


             reply	other threads:[~2021-10-22 21:14 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-22 21:14 Bing Zhao [this message]
2021-10-22 21:14 ` [dpdk-dev] [PATCH 2/2] ethdev: fix the race condition for fp ops reset Bing Zhao
2021-10-23  8:34   ` Thomas Monjalon
2021-10-23 11:39     ` Ananyev, Konstantin
2021-11-10 14:34       ` Ferruh Yigit
2021-11-10 14:37         ` Ananyev, Konstantin
2021-11-10 14:57           ` Thomas Monjalon
2021-11-10 15:24             ` Bing Zhao
2021-10-23 16:13   ` [dpdk-dev] " Stephen Hemminger
2021-10-24  5:54     ` Bing Zhao
2021-10-23  8:32 ` [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions Thomas Monjalon
2021-10-23 11:46   ` Ananyev, Konstantin
2021-10-23 12:45     ` Bing Zhao
2021-10-24 11:48       ` Ananyev, Konstantin
2021-10-25  9:43         ` Thomas Monjalon
2021-10-25  9:51           ` David Marchand
2021-10-25 12:55             ` Ananyev, Konstantin
2021-10-25 13:27               ` Thomas Monjalon
2021-10-25 13:31                 ` David Marchand
2021-10-25 20:29                   ` Ananyev, Konstantin
2021-10-25 20:38                     ` Thomas Monjalon
2021-10-26 12:38                       ` Ananyev, Konstantin
2021-10-26 12:59                         ` Thomas Monjalon
2021-10-26  3:18                   ` Bing Zhao
2021-10-23 12:12   ` Bing Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211022211407.315068-1-bingz@nvidia.com \
    --to=bingz@nvidia.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).