From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 395C2A0C52;
Mon, 25 Oct 2021 12:49:30 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id B86CB40E32;
Mon, 25 Oct 2021 12:49:29 +0200 (CEST)
Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com
[209.85.167.51]) by mails.dpdk.org (Postfix) with ESMTP id 61DE1407FF
for <dev@dpdk.org>; Mon, 25 Oct 2021 12:49:28 +0200 (CEST)
Received: by mail-lf1-f51.google.com with SMTP id u11so2791936lfs.1
for <dev@dpdk.org>; Mon, 25 Oct 2021 03:49:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=date:from:to:cc:subject:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=L7bKhNxlnOOOO0N/FmAprM5SteB2zTVAmyu9+3tvw3c=;
b=D4AWdpbS9Q0IkNwmMqz78l8jk9upHxJjLSK+mhFTc0hlfEhU7DlkzuIl8FYBWu0WQm
u1yM+g+mDNHpPjITEAfSJ8la6euXPBEbVl9n39Gd3AKw7JrVn4e9NBFcnFrF07rufJOk
5O1R8Xn1atCxDX5elkNLDFvjjo2Q8jUybf1IGrseT0XctKYdy62TiS2iVXH0WQyJNpQ7
kA05ngZRW5olr2f4T9lLnqeK4bOLKpa35V9Jq9WjS8tOE5S4b3syPzjKLqHEg3CQjLCx
1cM42Zojs+r80wno2bFkhmrPevJvBHOSl7jqKHObw3SB8cCNxekn5trGccDo4duNSrcP
ecvA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=L7bKhNxlnOOOO0N/FmAprM5SteB2zTVAmyu9+3tvw3c=;
b=qOsjK9/4aY0P3N+Yd9vlitZHqMXut6H1N3z7IS00R2f+msMEYIBjeVw69OQFxzdufD
8cxOz/t5EIJx94vfW3IN8YRVsRJYTictrnzSub4VmrqzGv1XYG6X/6YNNF73RvS7zopU
VG60VEhUkA/xJc0K4P5IzglIXLzwDLa8IiwdfUU6oezAkFNHlnOGO44BztopH5rhFieW
sRMQwpqyRGoqidYbwCvl+eTm5TC9b5NKnjTc96zGT3PEAXOuzpfSqzEfFC8DgO887/nE
qHuRx9/lJ1wsFPaB5yY1Yuri1pUfkLnTQTZCemmLhKGTgTMZA7X/Bi+RMOcqZhlfqokr
VNKw==
X-Gm-Message-State: AOAM5329Lk6eKGfEoCMnfrNK9hU+Fo2cglo9EUPQFYrG02Dbwsa58+3v
f6jKk+88AIXxreTu38vfp64=
X-Google-Smtp-Source: ABdhPJyXDoVG1Tr7Gnk8Vasj3aVoTDRxtY0TZmkaQzCU4qGJYtDOzqVvhOsR6j6UYrHPlFDy0PRfcQ==
X-Received: by 2002:a05:6512:2341:: with SMTP id
p1mr16231411lfu.204.1635158967861;
Mon, 25 Oct 2021 03:49:27 -0700 (PDT)
Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru.
[37.110.65.23])
by smtp.gmail.com with ESMTPSA id j8sm679456lfg.263.2021.10.25.03.49.27
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 25 Oct 2021 03:49:27 -0700 (PDT)
Date: Mon, 25 Oct 2021 13:49:26 +0300
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: David Marchand <david.marchand@redhat.com>
Cc: hkalra@marvell.com, dev@dpdk.org, Bruce Richardson
<bruce.richardson@intel.com>
Message-ID: <20211025134926.52a6925e@sovereign>
In-Reply-To: <20211024200449.12024-5-david.marchand@redhat.com>
References: <20211022204934.132186-1-hkalra@marvell.com>
<20211024200449.12024-1-david.marchand@redhat.com>
<20211024200449.12024-5-david.marchand@redhat.com>
X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v6 4/9] alarm: remove direct access to
interrupt handle
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
2021-10-24 22:04 (UTC+0200), David Marchand:
> From: Harman Kalra <hkalra@marvell.com>
>
> Removing direct access to interrupt handle structure fields,
> rather use respective get set APIs for the same.
> Making changes to all the libraries access the interrupt handle fields.
>
> Implementing alarm cleanup routine, where the memory allocated
> for interrupt instance can be freed.
>
> Signed-off-by: Harman Kalra <hkalra@marvell.com>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Changes since v5:
> - split from patch4,
> - merged patch6,
> - renamed rte_eal_alarm_fini as rte_eal_alarm_cleanup,
>
> ---
[...]
> diff --git a/lib/eal/freebsd/eal_alarm.c b/lib/eal/freebsd/eal_alarm.c
> index c38b2e04f8..1a8fcf24c5 100644
> --- a/lib/eal/freebsd/eal_alarm.c
> +++ b/lib/eal/freebsd/eal_alarm.c
> @@ -32,7 +32,7 @@
>
> struct alarm_entry {
> LIST_ENTRY(alarm_entry) next;
> - struct rte_intr_handle handle;
> + struct rte_intr_handle *handle;
This field is never used and can be just removed.
> struct timespec time;
> rte_eal_alarm_callback cb_fn;
> void *cb_arg;
[...]