From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 070B4A0C47;
	Tue, 26 Oct 2021 02:47:46 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 8BE3840A4B;
	Tue, 26 Oct 2021 02:47:46 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 0C4AF4003E
 for <dev@dpdk.org>; Tue, 26 Oct 2021 02:47:45 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1061)
 id 1DA8D20A1AF3; Mon, 25 Oct 2021 17:47:44 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1DA8D20A1AF3
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1635209264;
 bh=bOmaa3FWuICKXQ/3oQg8rndgAiuAY/CXRwcxRgZnlk0=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=Z7LIZSwy1jfIzr3pQLWujTbiF18CNA/l2olDzQ8Lkh8viBImujf8mqZ60Fnh6QrNn
 J3hdJDg+6XsaZJfDyH7OR8aKXlN/c+sPIeSM2CP+aSHEUajklga3OeI19vZ44l1CjR
 8Ydm82uGEk0UJmO3OvvBSez9yq9uXwHV/9MDvQkk=
Date: Mon, 25 Oct 2021 17:47:44 -0700
From: Jie Zhou <jizh@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com, roretzla@microsoft.com,
 navasile@linux.microsoft.com, dmitrym@microsoft.com,
 pallavi.kadam@intel.com, talshn@nvidia.com, aconole@redhat.com
Message-ID: <20211026004744.GA5912@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1634187170-3986-1-git-send-email-jizh@linux.microsoft.com>
 <1634228502-14701-1-git-send-email-jizh@linux.microsoft.com>
 <1634228502-14701-2-git-send-email-jizh@linux.microsoft.com>
 <1800954.qoURpX2mz1@thomas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1800954.qoURpX2mz1@thomas>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH v6 01/12] lib: build libraries that some
 tests depend on
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Oct 25, 2021 at 05:38:42PM +0200, Thomas Monjalon wrote:
> 14/10/2021 18:21, Jie Zhou:
> > Enable building subset of libraries that tests depend on for Windows
> > 
> > Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
> > ---
> >  lib/meson.build | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/lib/meson.build b/lib/meson.build
> > index b2ba7258d8..bd6c27deef 100644
> > --- a/lib/meson.build
> > +++ b/lib/meson.build
> > @@ -82,9 +82,11 @@ if is_windows
> >              'bitratestats',
> >              'cryptodev',
> >              'cfgfile',
> > +            'efd',
> >              'gro',
> >              'gso',
> >              'latencystats',
> > +            'lpm',
> >              'pdump',
> >              'stack',
> >              'security',
> > 
> 
> It needs to be rebased after the recent changes to disable libs on Windows.
> But instead of such patch, I would prefer one patch per lib,
> with Tested-by tags showing that the lib is tested and working on Windows.
> Also you need to Cc the maintainer of the lib being enabled.
>
Thanks Thomas. Will rebase in V7, and will separately enabling efd, lpm, and their corresponding unit tests in two patches after this one.