From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: dev@dpdk.org
Cc: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>
Subject: [dpdk-dev] [PATCH] net/bnxt: fix RSS action parser
Date: Mon, 25 Oct 2021 22:14:32 -0700 [thread overview]
Message-ID: <20211026051432.83989-1-ajit.khaparde@broadcom.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1947 bytes --]
Minor fixes are needed in the RTE_FLOW RSS action parser.
1. Update the comment in the parser to indicate rss level 1 implies
RSS on outer header.
2. RSS action will not be supported if level is > 1.
3. RSS action will not be supported if user or application specifies
MARK or COUNT action.
4. If RSS types is not specified i.e., is 0, the best effort RSS should
use IPV4 and IPV6 headers. Currently we are considering only IPV4.
Fixes: fe0bab7eb34e ("net/bnxt: enhance support for RSS action")
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Acked-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Acked-by: Somnath Kotur <somnath.kotur@broadcom.com>
---
drivers/net/bnxt/bnxt_flow.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c
index ced697a739..9526a8fc5a 100644
--- a/drivers/net/bnxt/bnxt_flow.c
+++ b/drivers/net/bnxt/bnxt_flow.c
@@ -1084,10 +1084,6 @@ bnxt_validate_rss_action(const struct rte_flow_action actions[])
break;
case RTE_FLOW_ACTION_TYPE_RSS:
break;
- case RTE_FLOW_ACTION_TYPE_MARK:
- break;
- case RTE_FLOW_ACTION_TYPE_COUNT:
- break;
default:
return -ENOTSUP;
}
@@ -1151,11 +1147,10 @@ bnxt_vnic_rss_cfg_update(struct bnxt *bp,
}
/* Currently RSS hash on inner and outer headers are supported.
- * 0 => Default setting
- * 1 => Inner
- * 2 => Outer
+ * 0 => Default (innermost RSS) setting
+ * 1 => Outermost
*/
- if (rss->level > 2) {
+ if (rss->level > 1) {
rte_flow_error_set(error,
ENOTSUP,
RTE_FLOW_ERROR_TYPE_ACTION,
@@ -1177,7 +1172,7 @@ bnxt_vnic_rss_cfg_update(struct bnxt *bp,
}
/* If RSS types is 0, use a best effort configuration */
- types = rss->types ? rss->types : RTE_ETH_RSS_IPV4;
+ types = rss->types ? rss->types : ETH_RSS_IPV4 | ETH_RSS_IPV6;
hash_type = bnxt_rte_to_hwrm_hash_types(types);
--
2.30.1 (Apple Git-130)
next reply other threads:[~2021-10-26 5:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 5:14 Ajit Khaparde [this message]
2021-10-27 1:51 ` Ajit Khaparde
2021-10-29 17:22 ` Ferruh Yigit
2021-10-29 17:35 ` Ajit Khaparde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211026051432.83989-1-ajit.khaparde@broadcom.com \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).