From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBBE1A0547; Tue, 26 Oct 2021 22:47:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B89DD410D5; Tue, 26 Oct 2021 22:47:29 +0200 (CEST) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id 936AD407FF for ; Tue, 26 Oct 2021 22:47:28 +0200 (CEST) Received: by mail-pl1-f179.google.com with SMTP id n18so429033plc.2 for ; Tue, 26 Oct 2021 13:47:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=N+W3EWI8v2J3Zp2UD/s/QVzc5iGCIWs9txaJkW2Bt0M=; b=o+luGiJ6hrRi8KMe+rb4khR7XYEAejOLMPN81eE0hdc4Px9In90IEIh2CseqLNp/Gl 5L4KTuEZqlKAzGJhvuRHr/vffc78m8m90Z2OfEDxsOJnhYVtfTl3T2SDWZ7H2j239K4B Dxzmc6tPhj7Yd3qM/bbyG+WBeQ10lgfcfvRUwRcVI84sR8+sxQATV31U7JcDJ37p0dB8 RvYbXLw4/mxz9Cpf24CgUmm33Sdo6OMlzCW+WW1T98eBl9fJZvy8Dx7nIve9VgiAVnaV zVnwfMkuo0i6Ka/rRSwkuhZuJSD2rtpQV8tjKxM9HTzCjT/LCRWySF8H+1eO5oFoslTX ED8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=N+W3EWI8v2J3Zp2UD/s/QVzc5iGCIWs9txaJkW2Bt0M=; b=fpK9MA8qo3qKUtPli4A+K96DFFMUMnkUd+vVj0vJThvll/rtRC2HpvMyUvNuwUxx+a NpJoLal9fYCRBHm9inJPP1deV+uSdKyBXFS43UEfiFuANtxXwzU1ERyHawDne1mikuKX 1OJNcy7w6DhJhVKaAdHP8hK4tVLIA4ThuhR/Tk7srBcguhwbDhqgftkLjROBPbfvtD+v 6mTkUBnwycy0lSdqNYu+44z7nFpEtPF/ToPZjU7/0IUd1F+tn6x6cggk7pq1xCdVA//q DSzXS1H0fkrMy+qd9Rp2EAdUJGhIIJsbXY6b5kQ1YQrd2kiYghfAhr0fHRDhoqcrHGGB x9kA== X-Gm-Message-State: AOAM531ck9YlRAVL+ieQIckTeh4s2xa08S8R3lxn3uUGtCUFTr8/CZ1y U3aAlp8oWRniaA+7UWoIunJR2UaOr7PSWQ== X-Google-Smtp-Source: ABdhPJwPnXe1MQZfsi4+aKIaomVd/6HFeT0umocxffKZ5CMFGw6ogJU5CUs6WMGRNxhBsgXm/0wKCA== X-Received: by 2002:a17:90a:650:: with SMTP id q16mr1231218pje.72.1635281247873; Tue, 26 Oct 2021 13:47:27 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id y19sm4953507pfn.23.2021.10.26.13.47.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Oct 2021 13:47:27 -0700 (PDT) Date: Tue, 26 Oct 2021 13:47:24 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: Jakub Grajciar , Somnath Kotur , Rosen Xu , Andrew Rybchenko , Ajit Khaparde , dev@dpdk.org Message-ID: <20211026134724.5478f4c1@hermes.local> In-Reply-To: <20211026153802.1820636-2-ferruh.yigit@intel.com> References: <20211026153802.1820636-1-ferruh.yigit@intel.com> <20211026153802.1820636-2-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/2] net/memif: fix driver init with default MTU X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 26 Oct 2021 16:38:01 +0100 Ferruh Yigit wrote: > diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c > index 8cec493ffdb9..cbc99067c1c8 100644 > --- a/drivers/net/memif/rte_eth_memif.c > +++ b/drivers/net/memif/rte_eth_memif.c > @@ -195,7 +195,7 @@ static int > memif_dev_info(struct rte_eth_dev *dev __rte_unused, struct rte_eth_dev_info *dev_info) > { > dev_info->max_mac_addrs = 1; > - dev_info->max_rx_pktlen = (uint32_t)ETH_FRAME_LEN; > + dev_info->max_rx_pktlen = (uint32_t)RTE_ETHER_MAX_LEN; The cast is not necessary here. Not sure why the original code had it?