DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: dev@dpdk.org, chenbo.xia@intel.com, amorenoz@redhat.com,
	david.marchand@redhat.com, andrew.rybchenko@oktetlabs.ru,
	ferruh.yigit@intel.com, michaelba@nvidia.com,
	viacheslavo@nvidia.com, xiaoyun.li@intel.com
Cc: nelio.laranjeiro@6wind.com, yvugenfi@redhat.com,
	ybendito@redhat.com, Maxime Coquelin <maxime.coquelin@redhat.com>,
	stable@dpdk.org
Subject: [dpdk-dev] [PATCH v6 3/5] app/testpmd: fix RSS type display
Date: Wed, 27 Oct 2021 16:22:11 +0200	[thread overview]
Message-ID: <20211027142213.556166-4-maxime.coquelin@redhat.com> (raw)
In-Reply-To: <20211027142213.556166-1-maxime.coquelin@redhat.com>

This patch fixes the display of the RSS hash types
configured in the port, which displayed "all" even
if only a single type was configured

Fixes: 3c90743dd3b9 ("app/testpmd: support more types for flow RSS")
Cc: stable@dpdk.org

Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
---
 app/test-pmd/config.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index e5c58ceb37..2e52664964 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -3019,7 +3019,9 @@ port_rss_hash_conf_show(portid_t port_id, int show_rss_key)
 	}
 	printf("RSS functions:\n ");
 	for (i = 0; rss_type_table[i].str; i++) {
-		if (rss_hf & rss_type_table[i].rss_type)
+		if (rss_type_table[i].rss_type == 0)
+			continue;
+		if ((rss_hf & rss_type_table[i].rss_type) == rss_type_table[i].rss_type)
 			printf("%s ", rss_type_table[i].str);
 	}
 	printf("\n");
-- 
2.31.1


  parent reply	other threads:[~2021-10-27 14:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-27 14:22 [dpdk-dev] [PATCH v6 0/5] Virtio PMD RSS support & RSS fixes Maxime Coquelin
2021-10-27 14:22 ` [dpdk-dev] [PATCH v6 1/5] net/virtio: add initial RSS support Maxime Coquelin
2021-10-27 14:58   ` Andrew Rybchenko
2021-10-29 17:40   ` Ferruh Yigit
2021-10-29 17:54     ` Maxime Coquelin
2021-10-27 14:22 ` [dpdk-dev] [PATCH v6 2/5] app/testpmd: fix RSS key length Maxime Coquelin
2021-10-27 14:22 ` Maxime Coquelin [this message]
2021-10-27 14:22 ` [dpdk-dev] [PATCH v6 4/5] net/mlx5: fix RSS RETA update Maxime Coquelin
2021-10-27 14:22 ` [dpdk-dev] [PATCH v6 5/5] app/testpmd: add missing flow types in port info Maxime Coquelin
2021-10-29 10:36 ` [dpdk-dev] [PATCH v6 0/5] Virtio PMD RSS support & RSS fixes Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211027142213.556166-4-maxime.coquelin@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=amorenoz@redhat.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=chenbo.xia@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=michaelba@nvidia.com \
    --cc=nelio.laranjeiro@6wind.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    --cc=xiaoyun.li@intel.com \
    --cc=ybendito@redhat.com \
    --cc=yvugenfi@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).