* [dpdk-dev] [PATCH] net/bnxt: fix to set flow error in case of failure
@ 2021-10-28 2:29 Kalesh A P
2021-10-28 4:24 ` Ajit Khaparde
0 siblings, 1 reply; 2+ messages in thread
From: Kalesh A P @ 2021-10-28 2:29 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, ajit.khaparde
From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
With commit 239695f754cb ("net/bnxt: enhance RSS action support"),
when bnxt_hwrm_vnic_rss_cfg() call fails, driver was not setting
flow error using "rte_flow_error_set".
Fixes: 239695f754cb ("net/bnxt: enhance RSS action support")
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
---
drivers/net/bnxt/bnxt_flow.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c
index 9526a8f..b3c68b1 100644
--- a/drivers/net/bnxt/bnxt_flow.c
+++ b/drivers/net/bnxt/bnxt_flow.c
@@ -1226,6 +1226,15 @@ bnxt_vnic_rss_cfg_update(struct bnxt *bp,
skip_rss_table:
rc = bnxt_hwrm_vnic_rss_cfg(bp, vnic);
+ if (rc != 0) {
+ rte_flow_error_set(error,
+ -rc,
+ RTE_FLOW_ERROR_TYPE_ACTION,
+ act,
+ "VNIC RSS configure failed");
+ rc = -rte_errno;
+ goto ret;
+ }
ret:
return rc;
}
@@ -1515,7 +1524,7 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,
/* RSS config update requested */
rc = bnxt_vnic_rss_cfg_update(bp, vnic, act, error);
if (rc != 0)
- return -rte_errno;
+ goto ret;
filter->dst_id = vnic->fw_vnic_id;
break;
--
2.10.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/bnxt: fix to set flow error in case of failure
2021-10-28 2:29 [dpdk-dev] [PATCH] net/bnxt: fix to set flow error in case of failure Kalesh A P
@ 2021-10-28 4:24 ` Ajit Khaparde
0 siblings, 0 replies; 2+ messages in thread
From: Ajit Khaparde @ 2021-10-28 4:24 UTC (permalink / raw)
To: Kalesh A P; +Cc: dpdk-dev, Ferruh Yigit
On Wed, Oct 27, 2021 at 7:09 PM Kalesh A P
<kalesh-anakkur.purayil@broadcom.com> wrote:
>
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> With commit 239695f754cb ("net/bnxt: enhance RSS action support"),
> when bnxt_hwrm_vnic_rss_cfg() call fails, driver was not setting
> flow error using "rte_flow_error_set".
>
> Fixes: 239695f754cb ("net/bnxt: enhance RSS action support")
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Patch applied to dpdk-next-net-brcm. Thanks
> ---
> drivers/net/bnxt/bnxt_flow.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c
> index 9526a8f..b3c68b1 100644
> --- a/drivers/net/bnxt/bnxt_flow.c
> +++ b/drivers/net/bnxt/bnxt_flow.c
> @@ -1226,6 +1226,15 @@ bnxt_vnic_rss_cfg_update(struct bnxt *bp,
>
> skip_rss_table:
> rc = bnxt_hwrm_vnic_rss_cfg(bp, vnic);
> + if (rc != 0) {
> + rte_flow_error_set(error,
> + -rc,
> + RTE_FLOW_ERROR_TYPE_ACTION,
> + act,
> + "VNIC RSS configure failed");
> + rc = -rte_errno;
> + goto ret;
> + }
> ret:
> return rc;
> }
> @@ -1515,7 +1524,7 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,
> /* RSS config update requested */
> rc = bnxt_vnic_rss_cfg_update(bp, vnic, act, error);
> if (rc != 0)
> - return -rte_errno;
> + goto ret;
>
> filter->dst_id = vnic->fw_vnic_id;
> break;
> --
> 2.10.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-28 4:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-28 2:29 [dpdk-dev] [PATCH] net/bnxt: fix to set flow error in case of failure Kalesh A P
2021-10-28 4:24 ` Ajit Khaparde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).