From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8BB6A0547; Thu, 28 Oct 2021 19:21:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 98A9B40DF4; Thu, 28 Oct 2021 19:21:51 +0200 (CEST) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id CD3A140DDB for ; Thu, 28 Oct 2021 19:21:50 +0200 (CEST) Received: by mail-pl1-f173.google.com with SMTP id w16so4927659plg.3 for ; Thu, 28 Oct 2021 10:21:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:subject:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=KTTh19rkdzrcbpF5DedNyLIy6umUYkkA96Bz557Osic=; b=i5a2rhBhk4cEiLTLF5r1zpy4Dkhs7p6HCvzuKl/251xzm6bxYa6mk5vwc1zoDAOHtb HuJw5J3erqMSnDheUtUvEOde/l/r6sw6YrvfdzJAfmgOHZI14Afj5Kmu0A8ltXBteSv1 tuQjIdIqqcn++Guy0F3v6VrJ3KY/SlmIZ+qhxfLjKVKH7upIQ9ZXXm2hHggaMWkqLmKg 0QhbKzL5YLwTOB549ANhR+RS9hS+/B56YJAP5nwZz7CciVYi8NTayOGhQJVgF7XQVY9Y ewuJruWxgPjvqQBn32+abeSiFbCWNNiXkhZzw9CZF5ureETRqeyKdLNUBAmkvzNzQjtV fsQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KTTh19rkdzrcbpF5DedNyLIy6umUYkkA96Bz557Osic=; b=7rRRoiYc4184H/eLKmJpWhD43mGxeNmU7JE2cF+myduVZfdPw+JVvGhsmIvAmgZNk9 mQ38YaCOdGDaCbwX0NCBX1LgKzCLZfT22lciMx+cntPgxUUNJBwFv0j4W/bYn5EDR5o6 bOoJvmq5Xoj/O7qGOSdFZ3Osx1Z4WVEfWtb3QVSc3kWzX9n3XfTBy1tdNcd0i/MEWwLq BHBzfd5gO6X/VsLpaskvYsFzc9sO7DtXU+F/XfLlHmaXxPSoQjpFha6Y+uYErRx0Vq10 85Rl4pOs6hAzt5D0nzsdMYXUjHuj+UH4j2Uw536wDXuIEM6WVDNWB6/I90iPUSgMQ487 IIPA== X-Gm-Message-State: AOAM531VxfDBCYgVl5vBnOeMQq+5uIKijFy7rIHDH2ZR/8yrOdfQt2HY kXo21j6IaBTSt/XKWDbJrWfenYlewXqmbw== X-Google-Smtp-Source: ABdhPJxxRSyYydU9RfnSCSDHe/bHk4ZY03SIIOR7jEZwIeNp9jjl205DVepuk/3Oga+rdPTifebKqg== X-Received: by 2002:a17:902:a983:b0:141:9407:1fb3 with SMTP id bh3-20020a170902a98300b0014194071fb3mr3352019plb.35.1635441709439; Thu, 28 Oct 2021 10:21:49 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id o10sm8303264pjh.23.2021.10.28.10.21.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Oct 2021 10:21:49 -0700 (PDT) Date: Thu, 28 Oct 2021 10:21:46 -0700 From: Stephen Hemminger To: dev@dpdk.org Message-ID: <20211028102146.10fa1652@hermes.local> In-Reply-To: <20211027180847.66572-1-stephen@networkplumber.org> References: <20211027180847.66572-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] pdump: initialize snaplen if enabled by device id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 27 Oct 2021 11:08:47 -0700 Stephen Hemminger wrote: > If packet dump was enabled via pdump_enable_by_deviceid > the packet snapshot length was not being set. > > Bugzilla ID: 840 > Fixes: 10f726efe26c ("pdump: support pcapng and filtering") > > Signed-off-by: Stephen Hemminger > --- > lib/pdump/rte_pdump.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c > index 71602685d544..3086b2a1688b 100644 > --- a/lib/pdump/rte_pdump.c > +++ b/lib/pdump/rte_pdump.c > @@ -631,6 +631,9 @@ pdump_enable_by_deviceid(const char *device_id, uint16_t queue, > if (ret < 0) > return ret; > > + if (snaplen == 0) > + snaplen = UINT32_MAX; > + > return pdump_prepare_client_request(device_id, queue, flags, snaplen, > ENABLE, ring, mp, prm); > } There appears to be bug in the CI system reporting bogus failure on this patch.