[dpdk-dev] [PATCH 0/2] fix MMO QP usage

[dpdk-dev] [PATCH 0/2] fix MMO QP usage

[Raja Zidane]

0x20 reserved bytes were missed in the HCA cap PRM structure before the
newly added fields for MMO QP capabilities, that caused reading MMO QP
caps incorrectly.
The QP extension valid bit was not set in the QP creation for MMO
configuration.
That caused the QP not to be connected to the GGA MMO engines,
and any MMO WQE job got CQE with an error.

Raja Zidane (2):
  common/mlx5: fix HCA cap PRM alignment
  common/mlx5: fix MMO configuration in QP

 drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++
 drivers/common/mlx5/mlx5_prm.h       | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

-- 
2.17.1

[dpdk-dev] [PATCH 1/2] common/mlx5: fix HCA cap PRM alignment

[Raja Zidane]

0x20 reserved bytes were missed in the HCA cap PRM structure before the
newly added fields for MMO QP capabilities.
That caused reading MMO QP caps incorrectly.
Add the reserved fields in the HCA cap structure.

Fixes: cbc4c13a255e ("common/mlx5: update MMO HCA capabilities")

Signed-off-by: Raja Zidane <rzidane@nvidia.com>
---
 drivers/common/mlx5/mlx5_prm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h
index eab80eaead..f14727877c 100644
--- a/drivers/common/mlx5/mlx5_prm.h
+++ b/drivers/common/mlx5/mlx5_prm.h
@@ -1636,7 +1636,7 @@ struct mlx5_ifc_cmd_hca_cap_bits {
 	u8 num_vhca_ports[0x8];
 	u8 reserved_at_618[0x6];
 	u8 sw_owner_id[0x1];
-	u8 reserved_at_61f[0x109];
+	u8 reserved_at_61f[0x129];
 	u8 dma_mmo_qp[0x1];
 	u8 regexp_mmo_qp[0x1];
 	u8 compress_mmo_qp[0x1];
-- 
2.17.1

[dpdk-dev] [PATCH 2/2] common/mlx5: fix MMO configuration in QP

[Raja Zidane]

The QP extension valid bit was not set in the QP creation for MMO
configuration.
That caused the QP not to be connected to the GGA MMO engines,
and any MMO WQE job got CQE with an error.
Set the QP ext bit when MMO is configured.

Fixes: ddda0006188a ("common/mlx5: add MMO configuration for DevX queue pair")

Signed-off-by: Raja Zidane <rzidane@nvidia.com>
---
 drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c
index fb7c8e986f..4f6a73510d 100644
--- a/drivers/common/mlx5/mlx5_devx_cmds.c
+++ b/drivers/common/mlx5/mlx5_devx_cmds.c
@@ -2055,6 +2055,8 @@ mlx5_devx_cmd_create_qp(void *ctx,
 				in, qpc_extension_and_pas_list);
 			void *qpc_ext = MLX5_ADDR_OF(qpc_extension_and_pas_list,
 				qpc_ext_and_pas_list, qpc_data_extension);
+
+			MLX5_SET(create_qp_in, in, qpc_ext, 1);
 			MLX5_SET(qpc_extension, qpc_ext, mmo, 1);
 		}
 		MLX5_SET(qpc, qpc, pm_state, MLX5_QP_PM_MIGRATED);
-- 
2.17.1

Re: [dpdk-dev] [PATCH 0/2] fix MMO QP usage

[Matan Azrad]

From: Raja Zidane
> 0x20 reserved bytes were missed in the HCA cap PRM structure before the newly
> added fields for MMO QP capabilities, that caused reading MMO QP caps
> incorrectly.
> The QP extension valid bit was not set in the QP creation for MMO
> configuration.
> That caused the QP not to be connected to the GGA MMO engines, and any
> MMO WQE job got CQE with an error.
> 
> Raja Zidane (2):
>   common/mlx5: fix HCA cap PRM alignment
>   common/mlx5: fix MMO configuration in QP
> 
>  drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++
>  drivers/common/mlx5/mlx5_prm.h       | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)

Series-acked-by: Matan Azrad <matan@nvidia.com>

Re: [dpdk-dev] [PATCH 0/2] fix MMO QP usage

[Matan Azrad]

From: Raja Zidane
> 0x20 reserved bytes were missed in the HCA cap PRM structure before the
> newly added fields for MMO QP capabilities, that caused reading MMO QP
> caps incorrectly.
> The QP extension valid bit was not set in the QP creation for MMO
> configuration.
> That caused the QP not to be connected to the GGA MMO engines, and any
> MMO WQE job got CQE with an error.
> 
> Raja Zidane (2):
>   common/mlx5: fix HCA cap PRM alignment
>   common/mlx5: fix MMO configuration in QP
> 
>  drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++
>  drivers/common/mlx5/mlx5_prm.h       | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)

Series-acked-by: Matan Azrad <matan@nvidia.com>

> --
> 2.17.1

Re: [dpdk-dev] [PATCH 0/2] fix MMO QP usage

[Thomas Monjalon]

28/10/2021 20:17, Matan Azrad:
> From: Raja Zidane
> > 0x20 reserved bytes were missed in the HCA cap PRM structure before the newly
> > added fields for MMO QP capabilities, that caused reading MMO QP caps
> > incorrectly.
> > The QP extension valid bit was not set in the QP creation for MMO
> > configuration.
> > That caused the QP not to be connected to the GGA MMO engines, and any
> > MMO WQE job got CQE with an error.
> > 
> > Raja Zidane (2):
> >   common/mlx5: fix HCA cap PRM alignment
> >   common/mlx5: fix MMO configuration in QP
> > 
> >  drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++
> >  drivers/common/mlx5/mlx5_prm.h       | 2 +-
> >  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> Series-acked-by: Matan Azrad <matan@nvidia.com>

Applied, thanks.